archive/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-09-20 11:21:43 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #9144 from JosJuice/confirm-runnable-finish

Browse source 
Android: Remove finish from ConfirmRunnableViewHolder
This commit is contained in:
JosJuice 2020-10-15 18:44:01 +02:00 committed by GitHub
commit 16f5a50cfc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java
View file

@ -331,6 +331,7 @@ public final class SettingsAdapter extends RecyclerView.Adapter<SettingViewHolde
StringSetting.MAIN_RESOURCEPACK_PATH.delete(settings);
StringSetting.MAIN_SD_PATH.delete(settings);
notifyItemRangeChanged(0, getItemCount());
mView.onSettingChanged();
}
@ -344,6 +345,7 @@ public final class SettingsAdapter extends RecyclerView.Adapter<SettingViewHolde
false).setBoolean(settings, value);
}
notifyItemRangeChanged(0, getItemCount());
mView.onSettingChanged();
}

3
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/ConfirmRunnableViewHolder.java
View file

@ -73,9 +73,6 @@ public final class ConfirmRunnableViewHolder extends SettingViewHolder
Toast.makeText(mContext, confirmationText, Toast.LENGTH_SHORT).show();
}
dialog.dismiss();
// TODO: Remove finish and properly update dynamic settings descriptions.
mView.getActivity().finish();
})
.setNegativeButton("No", (dialog, whichButton) ->
dialog.dismiss());