From 4aba0135e1c9137c551267f274abfbb7d78d975f Mon Sep 17 00:00:00 2001 From: Ryan Houdek Date: Fri, 26 Jul 2013 21:49:48 -0500 Subject: [PATCH] [Android] Qualcomm Swap hack isn't needed anymore due to the new StreamBuffer type. --- Source/Core/VideoCommon/Src/DriverDetails.cpp | 1 - Source/Core/VideoCommon/Src/DriverDetails.h | 10 ---------- Source/Plugins/Plugin_VideoOGL/Src/VertexManager.cpp | 2 -- 3 files changed, 13 deletions(-) diff --git a/Source/Core/VideoCommon/Src/DriverDetails.cpp b/Source/Core/VideoCommon/Src/DriverDetails.cpp index 567d140329..76cf08dce9 100644 --- a/Source/Core/VideoCommon/Src/DriverDetails.cpp +++ b/Source/Core/VideoCommon/Src/DriverDetails.cpp @@ -29,7 +29,6 @@ namespace DriverDetails {BUG_NODYNUBOACCESS, 300, 14.0, -1.0}, {BUG_BROKENCENTROID, 300, 14.0, -1.0}, {BUG_BROKENINFOLOG, 300, -1.0, -1.0}, - {BUG_BROKENBUFFERS, 300, 14.0, -1.0}, }; std::map, BugInfo> m_bugs; diff --git a/Source/Core/VideoCommon/Src/DriverDetails.h b/Source/Core/VideoCommon/Src/DriverDetails.h index f2f3480f70..bfa9c572d0 100644 --- a/Source/Core/VideoCommon/Src/DriverDetails.h +++ b/Source/Core/VideoCommon/Src/DriverDetails.h @@ -52,16 +52,6 @@ namespace DriverDetails // Adreno devices /always/ return 0 when querying GL_INFO_LOG_LENGTH // They also max out at 1024 bytes(1023 characters + null terminator) for the log BUG_BROKENINFOLOG, - // Bug: Uploading data with rendering causes issues - // Affected devices: Qualcomm/Adreno - // Started Version: 14 - // Ended Version: -1 - // When drawing our elements, the instruction buffer on Adreno devices - // becomes too long, causing the device to quickly run out of RAM - // I've watched the kernel module go up to ~700MB of RAM in a few seconds - // The "workaround" is calling swapbuffers every single time we flush - // This causes flickering, but it is the only known way to work around it - BUG_BROKENBUFFERS, }; // Initializes our internal vendor, device family, and driver version diff --git a/Source/Plugins/Plugin_VideoOGL/Src/VertexManager.cpp b/Source/Plugins/Plugin_VideoOGL/Src/VertexManager.cpp index 5caecf1c37..47f714cc47 100644 --- a/Source/Plugins/Plugin_VideoOGL/Src/VertexManager.cpp +++ b/Source/Plugins/Plugin_VideoOGL/Src/VertexManager.cpp @@ -268,8 +268,6 @@ void VertexManager::vFlush() g_perf_query->EnableQuery(bpmem.zcontrol.early_ztest ? PQG_ZCOMP_ZCOMPLOC : PQG_ZCOMP); Draw(stride); - if (DriverDetails::HasBug(DriverDetails::BUG_BROKENBUFFERS)) - GLInterface->Swap(); g_perf_query->DisableQuery(bpmem.zcontrol.early_ztest ? PQG_ZCOMP_ZCOMPLOC : PQG_ZCOMP); //ERROR_LOG(VIDEO, "PerfQuery result: %d", g_perf_query->GetQueryResult(bpmem.zcontrol.early_ztest ? PQ_ZCOMP_OUTPUT_ZCOMPLOC : PQ_ZCOMP_OUTPUT));