archive/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-09-21 03:41:42 +02:00
Code Issues Projects Releases Packages Wiki Activity

ControllerEmu: Fix incorrect default radius being set in AnalogStick

Browse source 
The three parameter AnalogStick constructor takes an internal name, a
display name, and a default radius argument. The delegated constructor is
the one that calls the ControlGroup constructor, setting the group type,
so passing the group type here is a logic bug.

The only reason this appeared to work despite this bug is because
GROUP_TYPE_STICK has a value of 1, and the default radius value used for
attachment sticks is 1.0.
This commit is contained in:
Lioncash 2017-02-08 23:03:37 -05:00
parent 73382852b7
commit 56531a0b7f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/Core/InputCommon/ControllerEmu/ControllerEmu.cpp
View file

@ -172,7 +172,7 @@ void ControllerEmu::ControlGroup::SetControlExpression(int index, const std::str
}
ControllerEmu::AnalogStick::AnalogStick(const char* const _name, ControlState default_radius)
: AnalogStick(_name, _name, GROUP_TYPE_STICK)
: AnalogStick(_name, _name, default_radius)
{
}