archive/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-09-20 03:11:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

GBAWidget: Use std::span with SetVideoBuffer()

Browse source 
Previously we were always taking the buffer by value, even if it wasn't
being stored anywhere and only read from.

We can use a std::span for the same thing.
This commit is contained in:
Lioncash 2023-12-13 10:04:44 -05:00
parent 3f06d32dcd
commit 67a06d17b1
2 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Source/Core/DolphinQt/GBAWidget.cpp
View file

@ -106,7 +106,7 @@ void GBAWidget::GameChanged(const HW::GBA::CoreInfo& info)
update();
}
void GBAWidget::SetVideoBuffer(std::vector<u32> video_buffer)
void GBAWidget::SetVideoBuffer(std::span<const u32> video_buffer)
{
m_previous_frame = std::move(m_last_frame);
if (video_buffer.size() == static_cast<size_t>(m_core_info.width * m_core_info.height))
@ -608,7 +608,7 @@ void GBAWidgetController::GameChanged(const HW::GBA::CoreInfo& info)
m_widget->GameChanged(info);
}
void GBAWidgetController::FrameEnded(std::vector<u32> video_buffer)
void GBAWidgetController::FrameEnded(std::span<const u32> video_buffer)
{
m_widget->SetVideoBuffer(std::move(video_buffer));
m_widget->SetVideoBuffer(video_buffer);
}

5
Source/Core/DolphinQt/GBAWidget.h
View file

@ -5,6 +5,7 @@
#include <memory>
#include <optional>
#include <span>
#include <string>
#include <string_view>
#include <vector>
@ -37,7 +38,7 @@ public:
~GBAWidget();
void GameChanged(const HW::GBA::CoreInfo& info);
void SetVideoBuffer(std::vector<u32> video_buffer);
void SetVideoBuffer(std::span<const u32> video_buffer);
void SetVolume(int volume);
void VolumeDown();
@ -106,7 +107,7 @@ public:
void Create(std::weak_ptr<HW::GBA::Core> core, const HW::GBA::CoreInfo& info);
void GameChanged(const HW::GBA::CoreInfo& info);
void FrameEnded(std::vector<u32> video_buffer);
void FrameEnded(std::span<const u32> video_buffer);
private:
GBAWidget* m_widget{};