archive/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-09-20 03:11:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

cmake: Don't use unqualified target_link_libraries

Browse source 
You can't mix unqualified and qualified link libraries (PUBLIC / PRIVATE).
Use the modern form.
This commit is contained in:
Florent Castelli 2017-02-08 02:57:36 +01:00
parent a9ed44cd48
commit 8c82607c95
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/CMakeLists.txt
View file

@ -21,7 +21,7 @@ add_definitions(-D__STDC_CONSTANT_MACROS)
macro(add_dolphin_library lib srcs libs) macro(add_dolphin_library lib srcs libs)
add_library(${lib} STATIC ${srcs}) add_library(${lib} STATIC ${srcs})
target_link_libraries(${lib} ${libs}) target_link_libraries(${lib} PUBLIC ${libs})
endmacro() endmacro()
add_subdirectory(Core) add_subdirectory(Core)

2
Source/Core/VideoBackends/Vulkan/CMakeLists.txt
View file

@ -37,5 +37,5 @@ include_directories(SYSTEM ${CMAKE_SOURCE_DIR}/Externals/glslang/SPIRV)
# Link against glslang, the other necessary libraries are referenced by the executable. # Link against glslang, the other necessary libraries are referenced by the executable.
add_dolphin_library(videovulkan "${SRCS}" "${LIBS}") add_dolphin_library(videovulkan "${SRCS}" "${LIBS}")
target_link_libraries(videovulkan glslang) target_link_libraries(videovulkan PRIVATE glslang)

2
Source/Core/VideoCommon/CMakeLists.txt
View file

@ -62,5 +62,5 @@ endif()
add_dolphin_library(videocommon "${SRCS}" "${LIBS}") add_dolphin_library(videocommon "${SRCS}" "${LIBS}")
if(LIBAV_FOUND) if(LIBAV_FOUND)
target_link_libraries(videocommon ${LIBS} ${LIBAV_LIBRARIES}) target_link_libraries(videocommon PRIVATE ${LIBS} ${LIBAV_LIBRARIES})
endif() endif()