archive/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-09-20 11:21:43 +02:00
Code Issues Projects Releases Packages Wiki Activity

AudioCommon: get rid of Update(), it never does anything

Browse source
This commit is contained in:
Tillmann Karras 2021-08-07 22:02:10 +01:00
parent c2d396526b
commit d14b9a73b2
8 changed files with 0 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Source/Core/AudioCommon/AlsaSoundStream.cpp
View file

@ -41,11 +41,6 @@ bool AlsaSound::Init()
return true; return true;
} }
void AlsaSound::Update()
{
// don't need to do anything here.
}
// Called on audio thread. // Called on audio thread.
void AlsaSound::SoundLoop() void AlsaSound::SoundLoop()
{ {

1
Source/Core/AudioCommon/AlsaSoundStream.h
View file

@ -24,7 +24,6 @@ public:
bool Init() override; bool Init() override;
void SoundLoop() override; void SoundLoop() override;
void Update() override;
bool SetRunning(bool running) override; bool SetRunning(bool running) override;
static bool isValid() { return true; } static bool isValid() { return true; }

2
Source/Core/AudioCommon/AudioCommon.cpp
View file

@ -197,8 +197,6 @@ void SendAIBuffer(const short* samples, unsigned int num_samples)
{ {
pMixer->PushSamples(samples, num_samples); pMixer->PushSamples(samples, num_samples);
} }
g_sound_stream->Update();
} }
void StartAudioDump() void StartAudioDump()

4
Source/Core/AudioCommon/NullSoundStream.cpp
View file

@ -20,7 +20,3 @@ bool NullSound::SetRunning(bool running)
void NullSound::SetVolume(int volume) void NullSound::SetVolume(int volume)
{ {
} }
void NullSound::Update()
{
}

1
Source/Core/AudioCommon/NullSoundStream.h
View file

@ -12,7 +12,6 @@ public:
void SoundLoop() override; void SoundLoop() override;
bool SetRunning(bool running) override; bool SetRunning(bool running) override;
void SetVolume(int volume) override; void SetVolume(int volume) override;
void Update() override;
static bool isValid() { return true; } static bool isValid() { return true; }
}; };

8
Source/Core/AudioCommon/OpenALStream.cpp
View file

@ -126,9 +126,6 @@ bool OpenALStream::Init()
OpenALStream::~OpenALStream() OpenALStream::~OpenALStream()
{ {
m_run_thread.Clear(); m_run_thread.Clear();
// kick the thread if it's waiting
m_sound_sync_event.Set();
m_thread.join(); m_thread.join();
palSourceStop(m_source); palSourceStop(m_source);
@ -155,11 +152,6 @@ void OpenALStream::SetVolume(int volume)
palSourcef(m_source, AL_GAIN, m_volume); palSourcef(m_source, AL_GAIN, m_volume);
} }
void OpenALStream::Update()
{
m_sound_sync_event.Set();
}
bool OpenALStream::SetRunning(bool running) bool OpenALStream::SetRunning(bool running)
{ {
if (running) if (running)

3
Source/Core/AudioCommon/OpenALStream.h
View file

@ -59,7 +59,6 @@ public:
void SoundLoop() override; void SoundLoop() override;
void SetVolume(int volume) override; void SetVolume(int volume) override;
bool SetRunning(bool running) override; bool SetRunning(bool running) override;
void Update() override;
static bool isValid(); static bool isValid();
@ -67,8 +66,6 @@ private:
std::thread m_thread; std::thread m_thread;
Common::Flag m_run_thread; Common::Flag m_run_thread;
Common::Event m_sound_sync_event;
std::vector<short> m_realtime_buffer; std::vector<short> m_realtime_buffer;
std::array<ALuint, OAL_BUFFERS> m_buffers; std::array<ALuint, OAL_BUFFERS> m_buffers;
ALuint m_source; ALuint m_source;

1
Source/Core/AudioCommon/SoundStream.h
View file

@ -21,7 +21,6 @@ public:
virtual bool Init() { return false; } virtual bool Init() { return false; }
virtual void SetVolume(int) {} virtual void SetVolume(int) {}
virtual void SoundLoop() {} virtual void SoundLoop() {}
virtual void Update() {}
// Returns true if successful. // Returns true if successful.
virtual bool SetRunning(bool running) { return false; } virtual bool SetRunning(bool running) { return false; }
}; };