archive/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-09-20 19:31:53 +02:00
Code Issues Projects Releases Packages Wiki Activity

VideoCommon: Fix D3D shader warning X3557 (single iteration loop)

Browse source 
Fix warning "loop only executes for 1 iteration(s), forcing loop to
unroll" when vertex_in == 1
This commit is contained in:
Dentomologist 2022-07-07 17:00:21 -07:00
parent 71541c1324
commit e1e0f42b37
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Source/Core/VideoCommon/GeometryShaderGen.cpp
View file

@ -216,7 +216,11 @@ ShaderCode GenerateGeometryShaderCode(APIType api_type, const ShaderHostConfig&
if (wireframe) if (wireframe)
out.Write("\tVS_OUTPUT first;\n"); out.Write("\tVS_OUTPUT first;\n");
// Avoid D3D warning about forced unrolling of single-iteration loop
if (vertex_in > 1)
out.Write("\tfor (int i = 0; i < {}; ++i) {{\n", vertex_in); out.Write("\tfor (int i = 0; i < {}; ++i) {{\n", vertex_in);
else
out.Write("\tint i = 0;\n");
if (api_type == APIType::OpenGL || api_type == APIType::Vulkan) if (api_type == APIType::OpenGL || api_type == APIType::Vulkan)
{ {
@ -307,6 +311,8 @@ ShaderCode GenerateGeometryShaderCode(APIType api_type, const ShaderHostConfig&
EmitVertex(out, host_config, uid_data, "f", api_type, wireframe, stereo, true); EmitVertex(out, host_config, uid_data, "f", api_type, wireframe, stereo, true);
} }
// Only close loop if previous code was in one (See D3D warning above)
if (vertex_in > 1)
out.Write("\t}}\n"); out.Write("\t}}\n");
EndPrimitive(out, host_config, uid_data, api_type, wireframe, stereo); EndPrimitive(out, host_config, uid_data, api_type, wireframe, stereo);