From 7ef0262f8ae0f5cb76fb7029b17b963947253da4 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 23 Jan 2024 16:05:01 -0500 Subject: [PATCH] PPCAnalyst: Merge duplicate expression in ReorderInstructionsCore() The type checking is duplicated here, which makes this seem a little weird, so we can get rid of it. --- Source/Core/Core/PowerPC/PPCAnalyst.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/Core/PowerPC/PPCAnalyst.cpp b/Source/Core/Core/PowerPC/PPCAnalyst.cpp index 3bf85b3dfb..978edfba80 100644 --- a/Source/Core/Core/PowerPC/PPCAnalyst.cpp +++ b/Source/Core/Core/PowerPC/PPCAnalyst.cpp @@ -512,7 +512,7 @@ void PPCAnalyzer::ReorderInstructionsCore(u32 instructions, CodeOp* code, bool r // Reorder integer compares, rlwinm., and carry-affecting ops // (if we add more merged branch instructions, add them here!) if ((type == ReorderType::CROR && isCror(a)) || (type == ReorderType::Carry && isCarryOp(a)) || - (type == ReorderType::CMP && (type == ReorderType::CMP && a.crOut))) + (type == ReorderType::CMP && a.crOut)) { // once we're next to a carry instruction, don't move away! if (type == ReorderType::Carry && i != start)