From f424e7815aa6b3223ebbc4d028932a970b546f77 Mon Sep 17 00:00:00 2001 From: "Michael Cook (mackal)" <277429+mackal@users.noreply.github.com> Date: Tue, 4 Apr 2023 16:10:31 -0400 Subject: [PATCH] DolphinQt: Fix memory leaks in MemoryWidget QMenuBar::addMenu does not take ownership of the QMenu, setting their parent allows them to be cleaned up --- Source/Core/DolphinQt/Debugger/MemoryWidget.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp b/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp index 0c3646ec7a..34dd7b767e 100644 --- a/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/MemoryWidget.cpp @@ -249,12 +249,12 @@ void MemoryWidget::CreateWidgets() QMenuBar* menubar = new QMenuBar(sidebar); menubar->setNativeMenuBar(false); - QMenu* menu_import = new QMenu(tr("&Import")); + QMenu* menu_import = new QMenu(tr("&Import"), menubar); menu_import->addAction(tr("&Load file to current address"), this, &MemoryWidget::OnSetValueFromFile); menubar->addMenu(menu_import); - QMenu* menu_export = new QMenu(tr("&Export")); + QMenu* menu_export = new QMenu(tr("&Export"), menubar); menu_export->addAction(tr("Dump &MRAM"), this, &MemoryWidget::OnDumpMRAM); menu_export->addAction(tr("Dump &ExRAM"), this, &MemoryWidget::OnDumpExRAM); menu_export->addAction(tr("Dump &ARAM"), this, &MemoryWidget::OnDumpARAM);