archive/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-09-21 11:51:48 +02:00
Code Issues Projects Releases Packages Wiki Activity
32431 commits 5 branches 11 tags 1.3 GiB
Commit graph

27889 commits

Author SHA1 Message Date
JosJuice
1b97f081b8
Merge pull request #7920 from Ebola16/DISO 
Android: Add Paths to UI
 2020-03-29 15:13:27 +02:00
JosJuice
5988d20917
Merge pull request #8698 from howard0su/warning_capture 
Cleanup warnings of -Wunused-lambda-capture
 2020-03-26 10:37:33 +01:00
Jun Su
81f8099cc6 Remove warnings of -Wsign-compare 
Cast the variable to the coresponding type.
 2020-03-25 07:57:14 +08:00
Ryan Meredith
d15d6e70d7 Android: Don't let onSettingChanged clobber ConfirmRunnable changes 2020-03-24 17:08:35 -04:00
JosJuice
5d6f23e424 SettingsHandler: Don't output null bytes 
https://bugs.dolphin-emu.org/issues/12019, take two.
 2020-03-24 17:01:15 +01:00
Connor McLaughlin
651595c521
Merge pull request #8701 from howard0su/static_wiimote 
Wiimote: Cleanup warnings of -Wmissing-variable-declarations
 2020-03-24 23:14:46 +10:00
Jun Su
7885fdb1ae Remove warning of -Wstringop-truncation 
Fix the right length when strncpy. And use specific version of copy
to copy GameID.
 2020-03-24 20:26:20 +08:00
Jun Su
b6ff15c130 Cleanup warnings of -Wmissing-declarations 
Add static to the functions which is not intentionally
export to big scope.
 2020-03-24 20:16:10 +08:00
Jun Su
da223a2271 Cleanup warnings of -Wunused-lambda-capture 
Remove unused lambda captures.
 2020-03-24 20:14:10 +08:00
Jun Su
9dec1e9998 use s_ prefix for local variables 2020-03-24 20:13:20 +08:00
Léo Lam
5b10f4b71e
Merge pull request #8673 from JosJuice/preserve-setting-txt 
Boot: Do a better job of preserving certain parts of settings.txt
 2020-03-24 10:16:17 +01:00
Léo Lam
584eee818c
Merge pull request #8660 from TheRealPSV/master 
Android: Set up Day/Night mode for system-compatible optional dark theme
 2020-03-24 10:03:35 +01:00
Léo Lam
b3ad3c3b07
Merge pull request #8683 from AlexApps99/cmdl 
Parse arguments before Qt
 2020-03-24 10:02:24 +01:00
Connor McLaughlin
323bffed01
Merge pull request #8700 from howard0su/add_override 
NoGUI: missing override in PlatformX11
 2020-03-24 18:34:48 +10:00
Jun Su
3f72bc3e7e HW: cleanup warnings of -Wtype-limits 
ROM_BASE is 0, and address is unsigned. It is always
true that address >= 0. So just compare with ROM_SIZE
and don't use IN_RANGE macro to avoid the warning.
 2020-03-24 09:11:24 +08:00
JosJuice
76b97a4183
Merge pull request #8680 from Leseratte10/master 
SettingsHandler: Always decode the whole settings.txt file
 2020-03-24 00:21:29 +01:00
JosJuice
aee9c7390d
Merge pull request #8699 from howard0su/cleanup_move 
Cleanup warnings of -Wpessimizing-move
 2020-03-23 19:58:13 +01:00
JosJuice
a6d1fe59a3
Merge pull request #8693 from howard0su/warning_xinpu 
InputCommon: cleanup warnings of -Wclass-memaccess
 2020-03-23 19:18:08 +01:00
JosJuice
6fab09951b
Merge pull request #8692 from howard0su/warning_unused 
Cleanup warnings of -Wunused-[const]-variable
 2020-03-23 19:10:52 +01:00
JosJuice
623a50786d
Merge pull request #8702 from sl1pkn07/Qt5.15 
Fix build with Qt 5.15+
 2020-03-23 18:35:09 +01:00
sL1pKn07
4f7ea79ae4 Fix build with Qt 5.15+ 2020-03-23 17:58:39 +01:00
Jun Su
0bd6016ad0 Wiimote: Cleanup warnings of -Wmissing-variable-declarations 
While I am here, make g_wiimote_scanner as static as well.
 2020-03-23 16:43:21 +08:00
Jun Su
fb7fbb4a7b NoGUI: missing override keyword GetWindowSystemInfo 2020-03-23 16:35:45 +08:00
Jun Su
964a2e1e70 Cleanup warnings of -Wpessimizing-move 
moving a temporary object prevents copy elision. Remove std::move.
 2020-03-23 16:31:15 +08:00
Jun Su
500820b352 Cleanup warnings of -Wunused-const-variable 2020-03-23 16:28:25 +08:00
Jun Su
997cfa49fc InputCommon: cleanup warnings of -Wclass-memaccess 
Initialize m_state with the default constructor.
 2020-03-23 14:26:36 +08:00
Jun Su
7c7a41ecd8 Cleanup warnings of -Wunused-variable 
remove unused variables.
 2020-03-23 14:24:27 +08:00
Jun Su
d44c51b30c DiscIO: cleanup warnings of -Wmaybe-uninitialized 
replace {} with std::nullopt.
 2020-03-23 14:14:00 +08:00
JosJuice
de5430b222 Android: Don't use SettingsAdapter's static state in file picker 2020-03-23 00:53:22 -04:00
Ryan Meredith
ccda75f33f Android: Add Paths to UI 2020-03-22 06:43:35 -04:00
AlexApps99
d6fb0b44d7 Parse arguments before Qt 2020-03-22 17:49:32 +13:00
Sepalani
9ec5391bfb Improve "Generate Symbols From > RSO Modules" 
Add auto-detection option
 2020-03-21 12:03:12 +04:00
Admiral H. Curtiss
303b18ddaf Qt/CodeWidget: Typo in settings key. 2020-03-20 20:51:26 +01:00
Florian Bach
cba4acc54b SettingsHandler: Always decode the whole settings.txt file 2020-03-20 16:08:25 +01:00
Mat M
9ac28054df
Merge pull request #8678 from JosJuice/setting-txt-code-default 
Boot: Change pre-defined setting.txt CODE values
 2020-03-20 02:06:07 -04:00
Silent
4a438db2c9
Qt/GameListModel: Use native separators in File Path column 2020-03-19 18:03:35 +01:00
JosJuice
21d6c0a11a Boot: Change pre-defined setting.txt CODE values 
As suggested by
https://github.com/dolphin-emu/dolphin/pull/8673#discussion_r394945753
 2020-03-19 13:05:44 +01:00
Parthiv Vora
0ba3f497a7 Android: add lighter accent color for dark mode 2020-03-18 23:57:21 -04:00
Léo Lam
53c34d962d
Merge pull request #8665 from AdmiralCurtiss/debugger_columns 
Qt/CodeViewWidget: Make columns resizable by the user and set sensible defaults.
 2020-03-19 01:40:30 +01:00
Admiral H. Curtiss
e8dfb8f78d Qt/CodeViewWidget: Make columns resizable by the user and set sensible defaults. 2020-03-18 22:27:53 +01:00
Léo Lam
0b91ea28c1
Merge pull request #8677 from JosJuice/comma-operator 
Android/JNI: Remove odd usage of the comma operator
 2020-03-18 13:13:16 +01:00
JosJuice
868cc15b71 Android/JNI: Remove odd usage of the comma operator 
This was probably a copypaste mistake of mine.
(env is used as the first argument when calling ToJString.)
 2020-03-18 12:37:28 +01:00
Léo Lam
4711b76cc4
Merge pull request #8655 from Techjar/fix-hotkey-groups 
Core/HotkeyManager: Fix group names in config
 2020-03-18 12:03:07 +01:00
Léo Lam
bb430fb5a5
Merge pull request #8675 from Pokechu22/disc-update 
Fix Load Wii System Menu not updating after performing a disc update
 2020-03-18 11:54:07 +01:00
Léo Lam
d1e8e3e903
Merge pull request #8671 from leoetlino/bt-passthrough-error 
BTReal: Improve error handling for device opening
 2020-03-18 11:52:22 +01:00
Pokechu22
c59120f089 Fix Load Wii System Menu not updating after performing a disc update 
For a fresh install, the button was completely disabled even after the disc update; otherwise, the text on it was just out of date.
 2020-03-17 19:59:48 -07:00
Jordan Woyak
099e6bfab9 DolphinQt: Fix gyro mapping indicator's "jitter" drawing. 2020-03-17 19:19:58 -05:00
Techjar
ae0c91805c Core/HotkeyManager: Fix group names in config 
For some reason every button group was shoved into the same config
group called "Keys" which caused buggy behavior once someone tried to
have hotkeys with the same name in different groups. This fixes that,
and converts existing configs to the new group names so they don't get
reset.
 2020-03-17 05:42:26 -04:00
Parthiv Vora
5446e7b7d6 Android: Set up Day/Night mode for system-compatible optional dark theme 2020-03-17 01:00:59 -04:00
Léo Lam
0461170363
Merge pull request #8672 from JosJuice/wii-setting-backup 
Back up Wii setting.txt and SYSCONF while emulating
 2020-03-16 22:21:15 +01:00
JosJuice
1b844067aa Back up Wii setting.txt and SYSCONF while emulating 
When booting a Wii game, Dolphin can overwrite certain settings
in the SYSCONF file, such as turning off PAL60 for NTSC games.
Normally, these settings get reverted at the end of emulation, but
this does not happen if Dolphin crashes or force quits in some other
way. (Personally, I have a tendency to use Visual Studio's Stop
Debugging button, which kills the process...)

Dolphin also overwrites certain values in setting.txt when booting
a Wii game. Unlike with SYSCONF, we currently make no effort to
preserve the original values in this file.

This change fixes both of these problems by copying SYSCONF and
setting.txt to the Backup folder when booting a Wii game, and then
copying them back either when launching Dolphin (in case the
previous run of Dolphin crashed) or when ending emulation.
 2020-03-16 21:04:19 +01:00
JosJuice
5f6598f9e9 StringUtil: Add PathToFileName function 2020-03-16 21:03:34 +01:00
Léo Lam
d4085382dc
Merge pull request #8598 from JosJuice/channel-sync-android-tv 
Android: More robust check for whether to sync channels
 2020-03-16 20:53:47 +01:00
Sepalani
e06bdaf426 AddressSpace: Fix constness 2020-03-16 23:48:03 +04:00
JosJuice
3614e9fcc2 Boot: Preserve MODEL value in setting.txt 
It doesn't necessarily start with RVL-001.
 2020-03-16 20:38:07 +01:00
JosJuice
36c92294df Boot: Preserve CODE value in setting.txt if it already matches the region 
This is a part of fixing https://bugs.dolphin-emu.org/issues/11930.
 2020-03-16 20:34:40 +01:00
Léo Lam
c86832849a
Merge pull request #8535 from JosJuice/movie-save-detection 
Movie: Make checking for existing GC saves more reliable
 2020-03-16 00:19:14 +01:00
JosJuice
cb0fe3fc30 Movie: Make checking for existing GC saves more reliable 
The old code only handled a raw memory card in slot A, not taking
GCI folders into account at all.
 2020-03-15 23:56:34 +01:00
Léo Lam
f81c0658c0
Merge pull request #8503 from JosJuice/android-stick-calibration 
Android: Use square stick calibration
 2020-03-15 23:42:05 +01:00
Léo Lam
5038ae384b
Merge pull request #8427 from CookiePLMonster/wil-submodule 
Add Windows Implementation Libraries as an external library
 2020-03-15 23:28:53 +01:00
Léo Lam
57274cbf91
Merge pull request #8565 from Pokechu22/log-scroll-bar 
Always display the horizontal scroll bar when log word wrap is off
 2020-03-15 23:14:23 +01:00
Léo Lam
a66ee4ea42
Merge pull request #8597 from SirMangler/master 
Hotkeys: Toggle Freelook Hotkey
 2020-03-15 22:40:51 +01:00
Léo Lam
d9eec2ef04
Merge pull request #8609 from jordan-woyak/separate-hotkey-background-input 
DolphinQt: Give hotkeys their own "background input" setting.
 2020-03-15 22:35:49 +01:00
Léo Lam
466c079bf4
Merge pull request #8604 from Techjar/netplay-index-direct 
Core/NetPlayServer: Fix session not being added to index on direct connection type
 2020-03-15 22:22:00 +01:00
Léo Lam
73e7f2a839 BTReal: Improve error handling for device opening 
This commit attempts to improve error handling for device opening by
reducing panic alert spam when opening one or several devices fails.
Currently, Dolphin shows a panic alert for every device that we fail
to open, and another panic alert at the end if no usable device was
found. That is certainly a bit excessive -- we should only keep the
very last panic alert (the one that is shown if everything fails)
and we can just put the error for the last device open operation there.

This also changes the PanicAlert to a CriticalAlert to ensure the
message is visible even if the user has disabled regular panic alerts.

The message has also been reworded and should hopefully be clearer.
 2020-03-15 22:10:24 +01:00
Léo Lam
d297080f52
Merge pull request #8669 from container1234/mbp 
Breakpoints: Fix crash after clearing all memory breakpoints
 2020-03-15 18:40:05 +01:00
Léo Lam
3c1f5c675d
Merge pull request #8628 from iwubcode/texturepack_game_id_file 
VideoCommon: Allow texture folders to be determined by a <gameid>.txt
 2020-03-15 18:37:46 +01:00
iwubcode
bba92019dc VideoCommon: Allow texture folders to be determined by a <gameid>.txt file 2020-03-15 12:34:04 -05:00
Léo Lam
24a01642e0
Merge pull request #8642 from AdmiralCurtiss/debugger_branch_arrows 
Qt/CodeViewWidget: Implement branch arrows.
 2020-03-15 16:45:36 +01:00
Admiral H. Curtiss
9c98b659f1 Qt/CodeViewWidget: Indent branch arrows based on free space rather than reserving a full column for each. 2020-03-15 16:14:35 +01:00
Léo Lam
19a46dd67b
Merge pull request #8652 from sonic2kk/qtshortcuts 
Qt: Use Builtin QKeySequence Shortcuts
 2020-03-15 15:07:47 +01:00
Léo Lam
4944e4b429
Merge pull request #8647 from jordan-woyak/minor-input-cleanups 
InputCommon: Minor ReshapableInput related cleanups.
 2020-03-15 15:06:54 +01:00
Léo Lam
0bf05009d0
Merge pull request #8650 from jordan-woyak/ir-cleanup 
HW/WiimoteEmu: Camera logic cleanups.
 2020-03-15 15:04:48 +01:00
Eamonn Rea
cd2cf137ba Use ZoomIn/ZoomOut QKeySequence in GameList 2020-03-15 14:58:33 +01:00
Eamonn Rea
eda31c782e Qt: Add Configuration shortcut 2020-03-15 14:58:31 +01:00
Eamonn Rea
b82f54762b Qt: Use builtin Find and Quit key sequences 2020-03-15 14:58:24 +01:00
Florian Bach
3487e5037e Fix settings.txt parsing in case of weird line endings 2020-03-15 00:12:19 +01:00
container1234
75a69b1145 Breakpoints: Fix crash after clearing all memory breakpoints 2020-03-14 21:57:09 +09:00
Stenzek
cdb0aa850d Qt/RenderWidget: Remove fill background functionality 
We no longer need this since the video backend handles clearing the
window, and it fixes MoltenVK with Qt 5.14.
 2020-03-11 23:13:45 +10:00
Stenzek
2f016295a6 Core: Render a blank UI frame before booting 
This is related to https://bugs.dolphin-emu.org/issues/10958 which
uses Qt to clear out the window so the game list isn't displayed
while the core is booting. Instead, we use the video backend to
render a black screen, which means Qt doesn't have to flip between
paint engines.
 2020-03-11 23:13:18 +10:00
Stenzek
fb947296b0 Vulkan: Pass CAMetalLayer to MoltenVK instead of NSView 
Gets rid of the warning for calling [NSView layer] off the main thread.
 2020-03-11 23:11:26 +10:00
Stenzek
a545344268 VideoBackends: Make it possible for PrepareWindow to change the surface 
Again, needed for MoltenVK.
 2020-03-11 23:10:30 +10:00
Stenzek
86db015c23 Common: Add a render_window field to WindowSystemInfo 
We need this because we need to pass the layer to MoltenVK, not
the view handle. But the input subsystem still needs the window.
 2020-03-11 23:09:30 +10:00
Ryan Meredith
38fa38d424 Android: Add Set as Default ISO to UI 2020-03-11 01:06:32 -04:00
JosJuice
bb7623e3ba
Merge pull request #8659 from Ebola16/Q 
Android: Fix obscured Dolphin version
 2020-03-10 20:10:56 +01:00
Admiral H. Curtiss
18127e2554 Qt/CodeViewWidget: Implement branch arrows. 2020-03-07 01:52:53 +01:00
Silent
d1f6f12f78
AudioPane: Do not enable Dolby Pro Logic II quality slider if DPLII is disabled 2020-03-06 21:13:45 +01:00
spycrab
dcaabcac03
Merge pull request #8580 from AlexApps99/master 
DolphinQt: Add "File Path" column to Game Grid
 2020-03-06 08:22:44 +01:00
Sergei Trofimovich
879e8364af Source/Core/Core/DSP/DSPTables.cpp: include <cstdio> for sprintf 
Without included header build fails on gcc-10 as:
```
[ 52%] Building CXX object Source/Core/Core/CMakeFiles/core.dir/DSP/DSPTables.cpp.o
../../../../Source/Core/Core/DSP/DSPTables.cpp: In function 'const char* DSP::pdname(u16)':
../../../../Source/Core/Core/DSP/DSPTables.cpp:492:3: error: 'sprintf' was not declared in this scope
  492 |   sprintf(tmpstr, "0x%04x", val);
      |   ^~~~~~~
```

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
 2020-03-05 21:20:34 +00:00
Sergei Trofimovich
0478ce72f5 Source/Core/Common/StringUtil.h: include <limits> for std::numeric_limits 
Without included header build fails on gcc-10 as:

```
[ 13%] Building CXX object Source/Core/AudioCommon/CMakeFiles/audiocommon.dir/CubebUtils.cpp.o
In file included from ../../../../Source/Core/AudioCommon/CubebUtils.cpp:13:
../../../../Source/Core/Common/StringUtil.h: In function 'bool TryParse(const string&, T*)':
../../../../Source/Core/Common/StringUtil.h:84:20: error: 'numeric_limits' is not a member of 'std'
   84 |   if (value < std::numeric_limits<LimitsType>::min() ||
      |                    ^~~~~~~~~~~~~~
```

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
 2020-03-05 21:20:34 +00:00
Ryan Meredith
163d9506e8 Android: Fix obscured Dolphin version 2020-03-03 13:19:08 -05:00
AlexApps99
465e7c2521 Used whole path instead of relative path 2020-03-03 11:58:59 +13:00
AlexApps99
7408c388d6 Add path to File Name column of game grid 
Fixes https://bugs.dolphin-emu.org/issues/10567
 2020-03-02 17:38:28 +13:00
Techjar
08c95883e9 Common/IniFile: Add Exists function for section name only 2020-02-29 01:39:36 -05:00
Jordan Woyak
ccdfa43a3e HW/WiimoteEmu: Fix Classic Controller triggers. 2020-02-26 15:40:58 -06:00
Jordan Woyak
2451a41a48 DolphinQt: Fix calibration cancel behavior. 2020-02-25 18:36:56 -06:00
Jordan Woyak
2c843ae06b DolphinQt: Clean up calibration drawing a bit. 2020-02-25 17:58:32 -06:00
Jordan Woyak
ed24f32c5b InputCommon: Specify ini value default when saving calibration "center". 2020-02-25 17:19:48 -06:00
Jordan Woyak
bd43e084f4 InputCommon: Clamp calibration values within square shape. 2020-02-25 17:19:48 -06:00
Jordan Woyak
f8cca9fe5d InputCommon: RoundStickGate's ideal sample count can be 1. 2020-02-25 17:19:48 -06:00
spycrab
8233255b11 Qt: Re-enable Dark Mode support 2020-02-25 23:27:44 +01:00
Jordan Woyak
ef777c4186 HW/WiimoteEmu: Fill IR data with 0xFF on failed bus read. 2020-02-24 19:45:02 -06:00
Jordan Woyak
5361e66459 HW/WiimoteEmu: Camera logic cleanups. 2020-02-24 19:44:15 -06:00
Jordan Woyak
6b109bd2a6 DolphinQt: Tweak indicator raw-input/input-shape color for better contrast in some dark themes. 2020-02-24 16:26:28 -06:00
Jordan Woyak
122984b46e DolphinQt: Eliminiate redundant swing indicator logic. 2020-02-24 16:26:28 -06:00
Jordan Woyak
d80fd13b17 DolphinQt: Clean up mapping indicator code and draw lines on "pixel centers". 2020-02-24 16:26:26 -06:00
Jordan Woyak
f79ca680cb DolphinQt: Eliminate redundant cursor indicator logic. 2020-02-24 16:25:06 -06:00
Jordan Woyak
38f36be9ae DolphinQt: Break mapping indicators into separate classes. Ensure "state lock" is held on redraw. 2020-02-24 16:25:06 -06:00
Jordan Woyak
7accd9825f InputCommon: Remove racy UpdateInput call in DetectInput. 2020-02-24 16:25:06 -06:00
Jordan Woyak
1a3b4d91bf InputCommon: Mark GetStateLock with [[nodiscard]] and fix discarding calls. 2020-02-24 16:25:06 -06:00
spycrab
25d5f0d9ef
Merge pull request #8633 from spycrab/tas_window_fixes 
Qt/TAS: Improve TAS windows
 2020-02-24 07:26:49 +01:00
Admiral H. Curtiss
c70e004f53 Qt/CodeViewWidget: Use named constants for column IDs. 2020-02-23 18:49:27 +01:00
Jordan Woyak
da12f3eebc InputCommon: Constify Device::Input::IsDetectable function. 2020-02-22 10:27:43 -06:00
spycrab
29c7c12016 Qt/TAS: Improve TAS windows 
- Use the Dolphin Icon in TAS Windows
- Prevent deformation of the stick widget (#11988)
- Improve visual appearance
- Set a reasonable minimum size
 2020-02-18 16:13:31 +01:00
Techjar
06a9f6ef82 Core/NetPlayServer: Fix session not being added to index on direct connection type 2020-02-17 21:05:32 -05:00
Jordan Woyak
70ac9ad2e6 InputCommon: Remove Wii Remote real-time calibration of M+ in favor of functionality provided by ControllerEmu. 2020-02-17 16:14:03 -06:00
Jordan Woyak
58448d74c5 InputCommon: Add real Wii Remote support to ControllerInterface. Add option to connect additional Wii Remotes. 2020-02-17 16:14:01 -06:00
Jordan Woyak
4176cc77e1 InputCommon/ControllerInterface: Make devices mutex recursive so RemoveDevice can be used within UpdateInput. 2020-02-17 15:58:06 -06:00
Jordan Woyak
5af2081c75 Core/WiimoteEmu: Add functions to Nunchuk, Classic Controller, and MotionPlus extensions to get/set data without duplicate bithacks everywhere. 2020-02-17 15:57:58 -06:00
Jordan Woyak
8343dadd58 InputCommon: Add types to ControllerEmu that represent raw controller inputs and calibration data to calculate normalized input values. 2020-02-17 15:57:43 -06:00
Jordan Woyak
259a7191d2 Common: Add additional Vector operations. 2020-02-17 15:57:43 -06:00
Jordan Woyak
1e652d7d34 InputCommon: Add calibration functionality to IMUGyroscope. 2020-02-17 15:57:43 -06:00
Jordan Woyak
9efcd08ea3 MathUtil: Add RunningMean/RunningVariance classes. 2020-02-17 15:57:43 -06:00
Jordan Woyak
82a3aa5ff6 InputCommon: Add "Dead Zone" setting to raw gyro inputs. 2020-02-17 15:57:43 -06:00
spycrab
2d6a72e941
Merge pull request #8632 from jimbo1qaz/windows-menu-font 
Windows GUI: Use QMenu font (Segoe UI) for entire application
 2020-02-17 15:04:37 +01:00
nyanpasu64
44f602fe51 Windows GUI: Use QMenu font (Segoe UI) for entire application 
On Windows, Qt's default system font (MS Shell Dlg 2) is outdated.

Dolphin previously used over 15 lines of code to compute a font
closer to the proper font, but with an approximately correct font size.
Using the QMenu font directly is both more concise and more elegant
(in my opinion).
 2020-02-17 05:37:54 -08:00
Léo Lam
44b4c2db49 Common: Avoid std::function overhead in ScopeGuard 
So far in all our uses of ScopeGuard, the type of the callable is
usually just a lambda or a function pointer, so there is no need
to rely on std::function's type erasure.

While the cost of using std::function is probably negligible, it still
causes some unnecessary overhead that can be avoided by making
ScopeGuard a templated class. Thanks to class template argument
deduction in C++17 most existing usages do not even need to be changed.

See https://godbolt.org/z/KcoPni for a comparison between
a ScopeGuard that uses std::function and one that doesn't
 2020-02-15 21:33:31 +01:00
JosJuice
62046d93ce
Merge pull request #8542 from Itrimel/fix-gecko-loading 
Fix Gecko codes loading
 2020-02-15 16:28:32 +01:00
Itrimel
fe900e057b Core/GeckoCodeConfig : Fix Gecko codes formatting 
Some locales (e.g. fr_FR.UTF-8 on ArchLinux) don't split the string stream on a space. As such, when extracted formatted data from te stream, it will return the two numbers as one for the first call, effectively overflowing the u32 variable, then will do an out-of-bounds read for the second call. Forcing the use of the C locale on the streams where it would cause a problem allows to workaround this behavior.
 2020-02-14 11:51:36 +01:00
spycrab
213a9adcff CMake: Fix building ARM64 on Windows 2020-02-12 12:29:31 +01:00
Jordan Woyak
903db48280 DolphinQt: Give hotkeys their own "background input" setting. 2020-02-10 20:06:29 -06:00
Tilka
a9dc4ac3f0
Merge pull request #8603 from jordan-woyak/deadzone-too-dark 
DolphinQt/Mapping: Tweak "Dead Zone" and "Gate" colors.
 2020-02-10 23:28:56 +00:00
Tilka
103b3abf66 Merge pull request #8621 from JosJuice/volumeverifier-invalid-partition 
Fix VolumeVerifier not showing a problem for invalid partitions
 2020-02-10 09:33:29 +00:00
Jordan Woyak
47877ecf2c InputCommon: Clean up creation of inputs. 2020-02-09 19:08:26 -06:00
Tilka
01d69ba81a
Merge pull request #8624 from jordan-woyak/setting-expression-input-gate 
InputCommon: Only update setting expressions when the input gate is enabled.
 2020-02-10 00:47:30 +00:00
Jordan Woyak
53f2e275af InputCommon: Only update setting expressions when the input gate is enabled. 2020-02-09 18:42:42 -06:00
Tilka
c598772052
Merge pull request #8622 from JosJuice/volumeverifier-invalid-partition-biggest-offset 
VolumeVerifier: Ignore invalid partitions in GetBiggestReferencedOffset
 2020-02-10 00:31:49 +00:00
Tilka
d129fae8fc
Merge pull request #8623 from spycrab/qt_5.14.1 
Update to Qt 5.14.1
 2020-02-10 00:06:11 +00:00
Tilka
db65b9a766 Merge pull request #8616 from jordan-woyak/threshold-cleanup 
InputCommon: Eliminate some duplicated button threshold logic.
 2020-02-10 00:05:10 +00:00
spycrab
6a3bd259a7 Update to Qt 5.14.1 2020-02-09 22:30:57 +01:00
Jordan Woyak
7cbb9822c1 VideoCommon: Remove widescreen heuristic debug logs. 2020-02-09 13:22:27 -06:00
Jordan Woyak
10223da6a8 VideoCommon: Tweak widescreen heuristic and clean up some related Renderer logic. 2020-02-09 13:22:25 -06:00
JosJuice
829f3cff6f VolumeVerifier: Ignore invalid partitions in GetBiggestReferencedOffset 
Otherwise GetBiggestReferencedOffset might treat garbage data as a valid
large offset, making Dolphin incorrectly say that the disc is too small.
 2020-02-09 19:05:44 +01:00
Silent
f52a0aba24
Add Windows Implementation Libraries 2020-02-09 19:01:44 +01:00
JosJuice
07df6597a5 Fix VolumeVerifier not showing a problem for invalid partitions 2020-02-09 18:58:15 +01:00
Jordan Woyak
f07457b6cc InputCommon: Eliminate some duplicated button threshold logic. 2020-02-09 10:37:18 -06:00
magiblot
55e8601192
Fix another implicit false-to-nullptr conversion 2020-02-09 15:51:30 +01:00
Léo Lam
aa21fe17b8
Merge pull request #8618 from encounter/debugger-floating-fix 
DolphinQt/Debugger: Fix crash with floating debugger windows
 2020-02-09 15:50:47 +01:00
Léo Lam
166e86b97f
Merge pull request #8619 from JosJuice/directoryblob-check-seek 
DiscIO: Check for DirectoryBlob seek failure
 2020-02-09 15:49:37 +01:00
Léo Lam
fb0f543777
Merge pull request #8574 from JosJuice/volumeverifier-assert-small-file 
VolumeVerifier: Improve the messages shown for files that are too small
 2020-02-09 15:48:57 +01:00
JMC47
5ab846ad12 Merge pull request #8614 from jordan-woyak/xinput-battery 
InputCommon/XInput: Expose battery as input and cleanups.
 2020-02-09 09:29:00 -05:00
JosJuice
9a348ae654 DiscIO: Check for DirectoryBlob seek failure 
Someone reported a problem with DirectoryBlob at
https://forums.dolphin-emu.org/Thread-feature-request-thread?pid=502820#pid502820.
I'm not sure if the change in this commit actually fixes that problem,
but it's something I found that should be changed regardless.
 2020-02-09 11:21:10 +01:00
Luke Street
3e94366fe0 DolphinQt/Debugger: Fix crash with floating debugger windows 2020-02-09 02:32:04 -05:00
Tilka
3cec5443cd
Merge pull request #8605 from Techjar/netplay-hostpoll-doc 
Core/NetPlayClient: Add documentation for SendPadHostPoll
 2020-02-09 02:32:50 +00:00
Tilka
2e2540317e Merge pull request #8417 from jordan-woyak/setting-expressions 
InputCommon: Allow controller settings specified with input expresions.
 2020-02-09 01:37:30 +00:00
Michael M
73711ef995 CMake: add DOLPHIN_CXX_FLAGS option 
Lets you do fun stuff like turning off warnings globally, then re-enabling all warnings + extra warnings + warnings as errors for Dolphin only.
 2020-02-09 01:03:36 +00:00
Tilka
0043a2cf3c Merge pull request #8615 from jordan-woyak/std-abs 
Cleanup: Use std::abs instead of abs.
 2020-02-09 00:39:30 +00:00
Jordan Woyak
4f47cccd9f Cleanup: Use std::abs instead of abs. 2020-02-08 18:21:14 -06:00
Jordan Woyak
0a1634bedf InputCommon: Allow Wii remote extension to be set with an input expression. 2020-02-08 16:03:13 -06:00
Jordan Woyak
e7400cafd2 InputCommon: XInput cleanups. 2020-02-08 15:51:02 -06:00
Jordan Woyak
86e8745169 InputCommon: Expose XInput battery level as an input. 2020-02-08 15:03:56 -06:00
Jordan Woyak
e8152b700f InputCommon: Allow controller settings specified with input expresions. 2020-02-08 14:01:55 -06:00
JMC47
6a857df219
Merge pull request #8606 from jordan-woyak/tab-key-navigation 
DolphinQt: setTabKeyNavigation(false) on QTableWidget and QTableView.
 2020-02-08 14:18:09 -05:00
JMC47
3b0b264c84
Merge pull request #8608 from jordan-woyak/stereoscopy-hotkeys 
DolphinQt: Fix stereoscopy hotkeys.
 2020-02-08 14:17:42 -05:00
JMC47
dc5447fb30
Merge pull request #8612 from jordan-woyak/unused-members 
DolphinQt: Kill some unused member variables.
 2020-02-08 14:17:15 -05:00
Jordan Woyak
f94726068d DolphinQt: Kill some unused member variables. 2020-02-08 10:52:06 -06:00
Tilka
e323f47ceb
Merge pull request #8472 from degasus/jitsetting 
Core/Jits: Adds an option to disable the register cache.
 2020-02-08 13:49:33 +00:00
Jordan Woyak
9a34091b8b DolphinQt: Fix stereoscopy hotkeys. 2020-02-07 15:47:40 -06:00
Jordan Woyak
b9f34bc822 DolphinQt: setTabKeyNavigation(false) on QTableWidget and QTableView. 2020-02-06 20:48:45 -06:00
Techjar
e8e41d8529 Core/NetPlayClient: Add documentation for SendPadHostPoll 2020-02-06 07:24:00 -05:00
Jordan Woyak
b1a71b959b DolphinQt/Mapping: Change "Dead Zone" color from shadow color of palette to a transparent black or white depending on theme. Tweak order of "shake" indicator axis colors so red is more often shown. 2020-02-04 16:08:51 -06:00
Pierre Bourdon
a205ecb446
Merge pull request #8602 from lioncash/fmt 
Externals: Update fmt to 6.1.2
 2020-02-04 21:59:22 +01:00
Lioncash
91deb40a22 Common: Amend includes to handle the upgrade to fmt 2020-02-04 15:03:51 -05:00
Lioncash
aea76c7901 Core: Amend includes to handle the upgrade to fmt 2020-02-04 15:03:48 -05:00
Lioncash
abd2897377 VideoCommon: Amend formatting code to handle the upgrade to fmt 
It seems that the newer version of fmt gets tripped up by bitfields
within structs. However, we can just specify the intended type where
necessary to get around this.
 2020-02-04 14:55:20 -05:00
JosJuice
f8355d0f82 VolumeVerifier: Don't return early when file is too small 
Not sure why that was there.
 2020-02-02 17:09:58 +01:00
JosJuice
e449d23929 VolumeVerifier: Don't show an assert for files that are too small 2020-02-02 17:09:58 +01:00
Léo Lam
0491831483
Merge pull request #8592 from phcoder/devid 
ButtonManager: Fix handling of empty device id.
 2020-02-02 16:52:12 +01:00
Léo Lam
06d0b1ad48
Merge pull request #8594 from leoetlino/fs-createfullpath-fix 
IOS/FS: Fix CreateFullPath to not create directories that already exist
 2020-02-02 16:50:02 +01:00
Léo Lam
4c9b1f3e0b
Merge pull request #8599 from Pokechu22/di-interrupt-mask-ioctls 
Fix DI interrupt mask ioctl names
 2020-02-02 16:49:27 +01:00
Pokechu22
f527f382e8 Report use of DI interrupt mask commands as a game quirk 2020-02-02 00:44:12 -08:00
Jordan Woyak
d6515eee41 WiimoteEmu: Fix default IMU accelerometer mappings. 2020-02-01 23:32:09 -06:00
Pokechu22
bb5e5fd8f2 Fix assignment of DI interrupt mask ioctls 
0x85 is actually DVDLowMaskCoverInterrupt, while 0x89 is DVDLowUnmaskCoverInterrupt.  I'm also fairly sure that 0x87 is DVDLowUnmaskStatusInterrupts.
 2020-02-01 16:56:48 -08:00
JosJuice
64953bb63a Android: More robust check for whether to sync channels 
This changes channel syncing to happen when the operating system is
Android TV rather than when TvMainActivity is launched. (You can run
TvMainActivity on a phone by specifying a launch activity manually
in Android Studio, which I do sometimes for testing purposes. Without
this change, you get an exception when channel syncing runs.)
 2020-02-01 22:07:29 +01:00
Connor McLaughlin
69ee15e5ef
Merge pull request #8478 from jordan-woyak/dsu-client-cleanup 
ControllerInterface/DSUClient: Minor cleanup.
 2020-02-01 11:29:29 +10:00
SirMangler
ac34911f32 Added Toggle Freelook Hotkey 2020-01-31 20:45:08 +00:00
JosJuice
534547ee8b
Merge pull request #8595 from stenzek/android-10-vulkan-suboptimal 
Vulkan: Treat VK_SUBOPTIMAL_KHR as VK_SUCCESS on Android
 2020-01-31 15:57:58 +01:00
Stenzek
f83b2fc62d Android: Fix typo in Skip Presenting Duplicate Frames setting name 2020-01-31 22:14:51 +10:00
Stenzek
08cc73108a Vulkan: Treat VK_SUBOPTIMAL_KHR as VK_SUCCESS on Android 
Android 10 seems to expect a prerotated/transformed swap chain for optimal
presentation. For now, until we implement that, just ignore the hint.
 2020-01-31 19:16:06 +10:00
Stenzek
ead65b0d8c Vulkan: Log when a swap chain resize is occurring 
This may help us debug performance problems in the future.
 2020-01-31 19:11:43 +10:00
Léo Lam
bbc8631357 IOS/FS: Fix CreateFullPath to not create directories that already exist 
This fixes CreateFullPath to not create directories when it is known
that they already exist, instead of calling CreateDirectory anyway
and checking if the error is AlreadyExists. (That doesn't work
now that we have an accurate implementation of CreateDirectory
that performs permission checks before checking for existence.)

I'm not sure what I was thinking when I wrote that function.

Also adds some tests for CreateFullPath.
 2020-01-30 18:07:03 +01:00
Léo Lam
f1f293bd49 WiiRoot: Fix CopySysmenuFilesToFS directory creation 
Fixes a regression from #8539.

CreateDirectory was the correct function to use for creating
directories since parent directories already exist and are
not owned by the system menu.
 2020-01-30 13:53:39 +01:00
Vladimir Serbinenko
02c5d292fa ButtonManager: Fix handling of empty device id. 
Device id is "" on ChromeOS when using gamepad
 2020-01-29 02:47:18 +01:00
Léo Lam
57f4837e4d
Merge pull request #8589 from lioncash/translatable 
DolphinQt/GCMemcardManager: Mark string as translatable within GetErrorMessagesForErrorCode()
 2020-01-27 23:20:03 +01:00
Lioncash
7eaa769527 DolphinQt/GCMemcardManager: Make use of QLatin1Char within GetErrorMessagesForErrorCode() 
Same behavior, but eliminates the use of a program lifetime Qt string
literal.
 2020-01-27 15:59:33 -05:00
Lioncash
585ae8aedf DolphinQt/GCMemcardManager: Mark string as translatable within GetErrorMessagesForErrorCode() 
This is a string that can potentially be seen by a user, so it should be
marked as translatable, like the other strings are.
 2020-01-27 15:57:36 -05:00
Lioncash
dca201d5f3 DolphinQt/GameConfigWidget: Remove unimplemented EditUserConfig() member function 
This isn't implemented anywhere, so we can remove the member function
prototype.
 2020-01-27 15:46:52 -05:00
Lioncash
2fd628d017 DolphinQt/GameConfigEdit: Remove unimplemented SetReadOnly() member function 
This isn't implemented anywhere, so we can remove this prototype.
 2020-01-27 15:44:52 -05:00
Lioncash
c69cbceb59 DolphinQt/MainWindow: Surround prototype of OnSignal() with relevant ifdef 
This is only used on Apple and Unix-like machines, so we can enclose the
prototype with an ifdef like the implementation is. This prevents
false-positives about an unimplemented function prototype.
 2020-01-27 15:26:41 -05:00
Lioncash
e8ee4e835e DolphinQt/NetPlayDialog: Remove unimplemented SetGame() prototype 
This isn't implemented anywhere, so the prototype can be removed.
 2020-01-27 15:25:04 -05:00