39336 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Admiral H. Curtiss	c5775c5b90	Merge pull request #11566 from v1993/patch-2 ... Fix build when using mGBA in unorthodox location	2023-02-22 21:04:04 +01:00
Admiral H. Curtiss	ebd98226db	Merge pull request #11595 from AdmiralCurtiss/rename-file-copy ... Common/FileUtil: Rename Copy() to CopyRegularFile().	2023-02-22 20:28:11 +01:00
Admiral H. Curtiss	e52aa52a66	Common/FileUtil: Rename Copy() to CopyRegularFile(). ... This is to clarify that it can only copy files, not folders.	2023-02-22 11:43:58 +01:00
Léo Lam	3c4a21315d	Merge pull request #11592 from Pokechu22/fix-delete-ticket ... IOS/ES: Fix crash when deleting tickets	2023-02-21 10:53:37 +01:00
Pokechu22	f2ac3aec94	IOS/ES: Fix crash when deleting tickets ... This broke formatting the system memory; see https://bugs.dolphin-emu.org/issues/13176. After calling ticket.DeleteTicket(), ticket.m_bytes was 0-length, but calling ticket.IsV1Ticket() still attempted to read from m_bytes. This was introduced in 2fd9852ca8, although it didn't actually cause a crash until 929fba08e7.	2023-02-20 18:33:34 -08:00
JosJuice	2aedd8f568	Merge pull request #11590 from t895/unused-layout-class ... Android: Remove SettingsFrameLayout	2023-02-20 23:33:07 +01:00
JosJuice	0fb9105700	Merge pull request #11408 from t895/coil ... Android: Rewrite image loading with Kotlin and Coil	2023-02-20 20:51:36 +01:00
Charles Lombardo	0638e08989	Android: Remove SettingsFrameLayout	2023-02-20 14:11:08 -05:00
Mai	6f21ce7d95	Merge pull request #11555 from CookiePLMonster/wil-todos ... Address WIL todos in UICommon.cpp	2023-02-20 10:14:49 -05:00
Mai	c7f48c8f28	Merge pull request #11587 from AdmiralCurtiss/code-view-breakpoint-logic ... Qt/CodeViewWidget: Small fixes to Update().	2023-02-20 10:10:04 -05:00
Charles Lombardo	28faca63a6	Android: Replace Glide with Coil image loading	2023-02-20 00:38:24 -05:00
Admiral H. Curtiss	4e6c89fbfd	Qt/CodeViewWidget: Don't read PC in Update() if we don't have a CPU thread guard.	2023-02-20 03:10:12 +01:00
Admiral H. Curtiss	ef1520c2c6	Qt/CodeViewWidget: Don't try to pause emulator in Update() if we happen to be on a breakpoint.	2023-02-20 02:56:04 +01:00
Admiral H. Curtiss	ae7fc074f8	Merge pull request #11398 from SeekyCt/conditional-bp-streq ... Debugger: Add string comparison to conditional breakpoints	2023-02-20 02:26:23 +01:00
Seeky	4e6e510003	Debugger: Add string comparison to conditional breakpoints.	2023-02-20 01:40:33 +01:00
Admiral H. Curtiss	45b55f7ccd	Merge pull request #11581 from shuffle2/sdl ... update sdl	2023-02-19 00:41:56 +01:00
Shawn Hoffman	cea95146e0	update sdl	2023-02-18 12:34:44 -08:00
JosJuice	78c53bfec8	Jit64: Fix the offsetAddedToAddress correction ... The LEA that the signal handler is trying to undo the effects of is a 32-bit instruction, and the value in the register prior to the LEA is also 32-bit, so the signal handler should use a 32-bit write. (Actually, in the end this doesn't really matter, because the first instruction that reads this value after backpatching is also a 32-bit instruction...)	2023-02-18 21:14:31 +01:00
JosJuice	e65167f9cd	Merge pull request #11521 from t895/adjust-grid-options ... Android: Simplify the grid options dialog fragment	2023-02-18 15:42:46 +01:00
Admiral H. Curtiss	8db35e6d04	Merge pull request #11578 from Pokechu22/memory-leaks-feb-2023 ... Fix various memory leaks	2023-02-18 13:56:34 +01:00
Admiral H. Curtiss	dfc0f12483	Merge pull request #11579 from Pokechu22/audio-stretching-label-enable ... AudioPane: Fix inconsistent initial state of audio stretching labels	2023-02-18 13:45:57 +01:00
Pokechu22	c94aacc968	AudioPane: Fix inconsistent initial state of audio stretching labels ... This resulted in the labels being solid black even when audio stretching is disabled the first time the settings are opened, but then properly being greyed out after changing a setting (even the audio backend or DSP emulation engine, not just whether audio stretching is enabled).	2023-02-17 18:51:41 -08:00
Pokechu22	f1f3fd5d9d	InputCommon: Fix memory leak in ExpressionParser ... We allocate in MakeSuppressor via `return unique_ptr(std::make_unique<...>(...).release(), InvokingDeleter{}`, so it wasn't properly getting freed.	2023-02-17 18:29:36 -08:00
Pokechu22	b6d476241a	CodeViewWidget: Fix memory leak ... Per https://doc.qt.io/qt-6/qabstractitemview.html#setItemDelegateForColumn setItemDelegateForColumn does not take ownership of the parameter, so it was not being deleted. Specifying a parent to QObject (via QStyledItemDelegate's constructor) will allow it to automatically be deleted, per https://doc.qt.io/qt-6/objecttrees.html. The other instance of a QItemDelegate in IOWindow.cpp already used this.	2023-02-17 18:29:32 -08:00
Pokechu22	1c5e223532	MemoryViewWidget: Fix memory leaks ... bp_item/row_item/item were never deleted, and the normal Qt ownership system wasn't applying to them because they were being cloned.	2023-02-17 18:17:01 -08:00
Admiral H. Curtiss	74abf48234	Merge pull request #11576 from yannhodiesne/convert-prevent-file-deletion ... Check the input and destination paths before converting a game file onto itself	2023-02-17 18:49:15 +01:00
Markus Wick	b381df700c	Merge pull request #11577 from JosJuice/android-armeabi-v7a ... Android: Fix armeabi-v7a build	2023-02-17 17:57:38 +01:00
JosJuice	90b676d368	Android: Fix armeabi-v7a build ... This very much isn't a build configuration that we're going to ship, but I want to be able to tell people that they can build it on their own if they really want to see how terribly it performs :) Just like before, you'll need to edit two lines in app/build.gradle to define ENABLE_GENERIC=ON and actually enable armeabi-v7a if you want an armeabi-v7a build. This commit just fixes some compilations errors that crop up if you do so.	2023-02-17 16:58:24 +01:00
Yann Hodiesne	49e897422f	Use a success count instead of files count	2023-02-17 15:49:31 +01:00
Yann Hodiesne	cb42a03299	Check the input and destination paths before converting a game file onto itself ... Before these changes you could tell Dolphin to convert a game file into the same format it is already in, leading to the FileDialog using the input path as the default destination path An unsuspecting user could then click Save and Dolphin would try to convert the input file by writing the destination file on top of it... leading to an I/O error and the input file being entirely removed	2023-02-17 14:26:50 +01:00
Scott Mansell	28331c5905	Merge pull request #11574 from K0bin/val-fix ... VideoBackends:Vulkan: Fix printing validation errors	2023-02-17 14:52:45 +13:00
Markus Wick	1903116d8e	Merge pull request #11575 from AdmiralCurtiss/mtmsr-5byte-jmp ... Jit64: Use 5 byte jump in mtmsr for the CP interrupt check.	2023-02-16 19:38:13 +01:00
Admiral H. Curtiss	0c48324c75	Jit64: Use 5 byte jump in mtmsr for the CP interrupt check. ... WriteExternalExceptionExit() can write more than the maximum offset of the small jump.	2023-02-16 19:26:19 +01:00
Robin Kertels	2695666e6d	VideoBackends:Vulkan: Fix printing validation errors	2023-02-16 17:53:15 +01:00
Mai	f004080382	Merge pull request #11573 from Pokechu22/freesurround-bad-delete ... Externals/FreeSurround: Fix pointer created through new[] being freed via delete	2023-02-16 03:44:33 -05:00
Scott Mansell	6038a6e2db	Merge pull request #11569 from Hibyehello/patch-1 ... VideoBackend: Make Metal Default on MacOS	2023-02-16 21:08:35 +13:00
Pokechu22	a7026ca6d3	Externals/FreeSurround: Fix pointer created through new[] being freed via delete ... Doing so is not allowed (presumably because compilers are allowed to use a different algorithm for allocating between the two/store extra data such as the length of the array before the pointer). This bug existed in the original implementation at https://web.archive.org/web/20140708092159/http://www.hydrogenaud.io/forums/index.php?showtopic=52235 and causes Valgrind to emit a warning. Note that this ended up happening even if DSPLLE and the DPL decoder are not enabled in Dolphin.	2023-02-15 21:56:49 -08:00
Mai	19bf13d3bb	Merge pull request #11572 from Pokechu22/uninitialized-variables-feb-2023 ... Fix uninitialized variable warnings (C26495)	2023-02-16 00:56:01 -05:00
Pokechu22	74a14c7d1f	ControllerInterface: Fix uninitialized variables in DualShockUDPClient ... Strangely, this case did not trigger a C26495 warning in Visual Studio's analyzer; instead, I spotted this when using Valgrind.	2023-02-15 19:23:47 -08:00
Pokechu22	67381cdb8b	VideoCommon: Remove unused ShutdownImGui function declaration ... This was moved to the ~OnScreenUI() destructor in 0d4537d60f.	2023-02-15 19:20:59 -08:00
Pokechu22	8802f96b7e	Fix uninitialized variable warnings (C26495)	2023-02-15 19:18:39 -08:00
Charles Lombardo	8d16aed581	Android: Convert UserDataActivity to Kotlin	2023-02-15 18:50:33 -05:00
Josh	cd38ed76e2	Keep Vulkan precedence over OpenGL	2023-02-15 12:22:56 -06:00
Josh	546a016dc8	VideoBackend: Make Metal Default on MacOS	2023-02-15 12:05:54 -06:00
SMarioMan	301e97f7f7	Remove WinAPI-specific type from socket request	2023-02-15 09:29:21 -05:00
SMarioMan	a45f6d9438	Enable broadcast permissions in socket requests	2023-02-15 07:59:38 -05:00
Admiral H. Curtiss	089eab96d7	Merge pull request #11567 from AdmiralCurtiss/create-full-path-behavior-change ... Common/FileUtil: Revert behavior of CreateFullPath().	2023-02-15 03:12:24 +01:00
Admiral H. Curtiss	c36994a90d	Add unit test for File::CreateFullPath().	2023-02-15 02:56:10 +01:00
Admiral H. Curtiss	0758e00cfe	Common/FileUtil: Revert behavior of CreateFullPath(). ... This was accidentally changed in 7e6436db34.	2023-02-15 02:21:50 +01:00
Valeri	6aafbaf66f	Fix build when using mGBA in unorthodox location ... Includes use `mgba/` and `mgba-util/` as part of path, making compilation fail when relying on include directory supplied here was actually needed.	2023-02-14 22:24:02 +03:00