archive/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-09-21 20:01:40 +02:00
Code Issues Projects Releases Packages Wiki Activity
24835 commits 5 branches 11 tags 1.3 GiB
Commit graph

360 commits

Author SHA1 Message Date
Scott Mansell
bed102ae89 Revert "ShaderGen: Toggle value of uninitialized color." 2015-12-27 02:28:29 +13:00
Lioncash
8371c428cd VertexLoaderBase: Get rid of explicit delete and new 2015-12-22 20:09:54 -05:00
Jules Blok
8bda12bcfd Revert "Merge pull request #3076 from void-ghost/stereo3d_presets" 
This reverts commit 81414b4fa2, reversing
changes made to b926061f64.

Conflicts:
	Source/Core/DolphinWX/Frame.cpp
	Source/Core/VideoCommon/VideoConfig.cpp
	Source/Core/VideoCommon/VideoConfig.h
 2015-12-23 00:35:19 +01:00
Lioncash
f295182833 VideoBackends: Simplify initialization and deinitialization of resources 
Approximately three or four times now, the issue of pointers being
in an inconsistent state been an issue in the video backend renderers
with regards to tripping up other developers.

Global (ugh) resources are put into a unique_ptr and will always have a
well-defined state of being - null or not null
 2015-12-20 22:40:37 -05:00
degasus
5e9ab28ed1 VideoSW: Clear normal vertex data. 
This data might not be initialized but used for lighting.
This matches our ShaderGen usage in VertexShaderGen.cpp:166.
 2015-12-19 10:51:42 +01:00
Pierre Bourdon
de21da5fb2 Merge pull request #3315 from degasus/test 
ShaderGen: Toggle value of uninitialized color.
 2015-12-18 14:21:37 +01:00
degasus
f511e539c2 VideoSW: Use Zero for undefined colors. 2015-12-06 12:39:18 +01:00
Lioncash
7762d68c4b Rasterizer: Mark some references as const 2015-12-06 02:51:36 -05:00
Lioncash
0608ed5130 Rasterizer: Specify internal linkage on Draw 
It's not exposed in the header.
 2015-12-06 02:51:34 -05:00
Lioncash
a0924b5e1b Rasterizer: Convert BLOCK_SIZE into a constant variable 2015-12-06 02:51:33 -05:00
Lioncash
2793785e0c Rasterizer: Get rid of a clamp macro 2015-12-06 02:51:28 -05:00
Lioncash
9b921c2e7c Rasterizer: Get rid of a trivial pointer cast 2015-12-06 02:44:06 -05:00
degasus
d28c9ae354 VideoSW: Wipe output vertices 
They shall be overwritten afterwards.
 2015-12-02 21:37:12 +01:00
Markus Wick
4d3d947efc Merge pull request #3157 from degasus/videosw3 
VideoSW: Wipe alpha on bypass EFB
 2015-10-17 12:02:55 +02:00
flacs
d85344bd58 Merge pull request #3155 from degasus/videosw 
VideoSW: Split up OGL window handling
 2015-10-17 04:56:44 +02:00
Lioncash
b5b304cff2 VertexShaderManager: Get rid of float pointer casts 2015-10-15 23:34:54 -04:00
degasus
b69bff0690 VideoSW: Use OpenGL Core context 2015-10-14 00:13:54 +02:00
degasus
61c3a0d9e4 VideoSW: Split up OGL window handling 
This removes OSD support for video software, but it was already broken before.

This commit does not try to fix coding style issues, the rewrite of this presentation API is splitted up.
 2015-10-14 00:13:54 +02:00
Tillmann Karras
9f8981c7c0 VertexLoaderUtils: remove simple wrapper functions 2015-10-11 23:40:50 +02:00
Tillmann Karras
0f1b287402 Misc. style fixes 2015-10-10 17:44:42 +02:00
degasus
d4e447555e VideoSW: Wipe alpha on bypass EFB 
Alpha must not be displayed.
 2015-10-10 11:45:39 +02:00
shuffle2
81414b4fa2 Merge pull request #3076 from void-ghost/stereo3d_presets 
Stereo3d presets
 2015-10-03 18:10:23 -07:00
Lioncash
a10be26972 Tev: Don't savestate Zero16 
It's an array of zeroes. There's no need.
 2015-09-30 19:45:50 -04:00
Lioncash
c6678687b0 ChunkFile: Provide additional helpers for C-style arrays 
Gets rid of magic numbers in cases where the array size is known at compile time.
This is also useful for future entries that are stack allocated arrays as these
functions prevent incorrect sizes being provided.
 2015-09-30 19:45:46 -04:00
Lioncash
1d42db2439 Common: Move NonCopyable to its own header 2015-09-26 18:50:35 -04:00
ghost
07e4b4f7c4 VideoBackend: Video config filename is now exposed in VideoBackends. 
It reduces redundancy. Needed make possible to save current video config.
 2015-09-22 09:47:19 +03:00
Scott Mansell
95f3c956a8 Move GL interface code out of the OpenGL video backend. 2015-09-22 00:36:45 +12:00
degasus
be16901ae1 VideoSW: Don't raise a PanicAlert because of indices 
It's not panic, it may just render wrong. And this case seems to happen often.
 2015-09-20 13:13:47 +02:00
degasus
c976e14277 GLInterface: Fix VideoSW on linux + OSX (v2) 
Our Video Software backend isn't OpenGL Core compatible, so we need a flag to alloc a compatible one.

v2: Fix AGL profile selection.
 2015-09-19 13:22:55 +02:00
Markus Wick
a7e9a154a5 Revert "GLInterface: Fix VideoSW on linux + OSX" 2015-09-18 13:40:09 +02:00
degasus
baf09c3af6 VideoSW: Remove unused function 2015-09-17 19:44:44 +02:00
flacs
e4dfb2f6bf Merge pull request #3054 from degasus/master 
GLInterface: Fix VideoSW on linux + OSX
 2015-09-17 19:21:16 +02:00
degasus
3b5b80bf3c VideoSW: Drop SW bbox code 
The hardware backends don't use this shared code any more, and it's not needed for video sw either. So this was just dead code.
 2015-09-17 18:21:37 +02:00
degasus
e3e0399af2 VideoSW: Drop HwRasterizer 
I don't remember it being working, and nobody cares about performance of videosw.
 2015-09-17 18:21:37 +02:00
degasus
48279c1840 GLInterface: Fix VideoSW on linux + OSX 
Our Video Software backend isn't OpenGL Core compatible, so we need a flag to alloc a compatible one.
 2015-09-17 17:52:56 +02:00
Lioncash
a94300dd86 Rasterizer: Use multiplication instead of shifts in DrawTriangleFrontFace 
The left-hand-side is negative at some point which is considered undefined by the standard.
 2015-09-17 01:46:29 -04:00
Lioncash
b9e360df7b MathUtil: Convert Clamp into a constexpr function 2015-09-12 01:18:28 -04:00
Lioncash
633be0387d General: Remove unimplemented function prototypes 2015-09-05 22:01:07 -04:00
Shawn Hoffman
aa7208e270 [windows] Update projects to vs2015. 2015-09-03 04:23:01 -07:00
Markus Wick
6004ecc521 Merge pull request #2920 from rohit-n/build-pch 
Fix building with PCH disabled.
 2015-08-28 23:08:24 +02:00
Rohit Nirmal
6252d2d71a Fix building with PCH disabled. 2015-08-28 14:13:28 -05:00
Lioncash
e787501528 Vec3: Simplify operator== code 2015-08-28 14:46:40 -04:00
Lioncash
bb27f80a65 Vec3: Remove a memset call on the this pointer 2015-08-28 14:10:07 -04:00
Tillmann Karras
c9af7def28 Fix some warnings 2015-06-23 21:11:56 +02:00
degasus
c375111076 Options: merge SCoreStartupParameter into SConfig 2015-06-12 19:07:45 +02:00
Jules Blok
d5788f75a3 Merge pull request #2533 from degasus/syncgpu 
Fifo: Rewrite SyncGPU
 2015-06-09 09:43:26 +02:00
NanoByte011
59f273696a VideoSW: refactor shared lighting attenuation function 
- Refactored Light Attenuation into inline function in Software Renderer
- Corrected zero length light direction vector to resolve with normal direction (essentially becomes LIGHTDIF_NONE which was what I was after)
- Change the API of this shared function to use points for output variables (degasus)
 2015-06-08 23:20:27 +02:00
NanoByte011
06d1b8c63a VideoSW: rewrite lighting attenuation 
- Fixes remaining lighting issues (Mario Tennis, etc)
- Apply same fixes to Software Renderer
- Corrected zero length light direction vector to resolve with normal direction (essentially becomes LIGHTDIF_NONE which was what I was after)
 2015-06-08 23:20:27 +02:00
degasus
d31bed8b79 Fifo: Rewrite SyncGpu 
The new implementation has 3 options:
 SyncGpuMaxDistance
 SyncGpuMinDistance
 SyncGpuOverclock

The MaxDistance controlls how many CPU cycles the CPU is allowed to be in front
of the GPU. Too low values will slow down extremly, too high values are as
unsynchronized and half of the games will crash.
The -MinDistance (negative) set how many cycles the GPU is allowed to be in
front of the CPU. As we are used to emulate an infinitiv fast GPU, this may be
set to any high (negative) number.

The last parameter is to hack a faster (>1.0) or slower(<1.0) GPU. As we don't
emulate GPU timing very well (eg skip the timings of the pixel stage completely),
an overclock factor of ~0.5 is often much more accurate than 1.0
 2015-06-08 23:16:24 +02:00
Scott Mansell
7df6982973 Add a dirty flag for arraybases. 
Only loop through and call getPointers when something has actually
changed.
Worth about 2-4% speedup un SMG over the previous commit.
 2015-05-30 04:39:48 +12:00
Scott Mansell
f57517f1a0 Clean up cached_arraybases. Update VideoSW to new scheme. 
Move ownership of cached_arraybases from CPMemory to VertexLoaderManager
to better match it usage.
 2015-05-30 04:09:27 +12:00
Rohit Nirmal
c59bfd2b7f Fix building with PCH disabled. 2015-05-26 22:44:51 -05:00
Ryan Houdek
69963dc4b0 Merge pull request #2274 from degasus/disable_bbox 
Disable bbox
 2015-05-25 08:46:12 -04:00
Tillmann Karras
30ebb2459e Set copyright year to when a file was created 2015-05-25 13:22:31 +02:00
Tillmann Karras
cefcb0ace9 Update license headers to GPLv2+ 2015-05-25 13:22:31 +02:00
Tillmann Karras
268f52e054 Add missing license headers 2015-05-25 13:11:47 +02:00
degasus
6b2a1e57e2 BBox: remove now unreachable SW bbox implementation 2015-05-25 09:33:34 +02:00
Markus Wick
ad9dae30a8 Merge pull request #2410 from lioncash/swatomic 
Software: Convert most volatile variables to atomics
 2015-05-22 14:11:16 +02:00
Jules Blok
ef78941042 VideoBackends: Clamp depth to uint24 range. 2015-05-18 23:22:28 +02:00
Lioncash
26a3eaf959 Software: Convert most volatile variables to atomics 2015-05-14 12:33:19 -04:00
degasus
b020ae1c5d Fifo: rewrite sync on idle skipping hack 
Now it's done without a busy loop
 2015-04-06 12:35:35 +02:00
Tillmann Karras
5a51bc10e5 SWVertexLoader: fix truncated components 2015-03-18 12:09:06 +01:00
Stevoisiak
93b16a4a2d Formatting/Whitespace Cleanup 
Various fixes to formatting and whitespace
 2015-02-25 10:48:21 -05:00
Ryan Houdek
15e41c67f8 Change RunVertices' function arguments. 
This reduces some dumb state shuffling when calling the emitted vertex loaders.
 2015-02-13 12:16:06 -06:00
degasus
081137bd4f VideoBackends: set GLInterface to zero after deleting it 
This fixes a crash on opening the gfx settings after closing a game.
 2015-02-01 13:51:34 +01:00
Lioncash
9476756d43 OGL: Fix a memory leak that would occur every time a game is launched 2015-01-31 16:00:53 -05:00
Ryan Houdek
80e6367e46 Merge pull request #1869 from Stevoisiak/GeneralConsistency 
Minor consistency changes
 2015-01-21 13:46:53 -06:00
degasus
3630de99ed VideoSW: Fix vertex skipping 2015-01-18 04:52:56 +01:00
Stevoisiak
cb86db7b68 Minor consistency changes 
Mostly small changes, like capitalization and spelling
 2015-01-12 15:18:18 -05:00
Rohit Nirmal
bad5aef5df Fix building with PCH disabled. 2015-01-04 10:45:35 -06:00
degasus
809117102e VideoCommon: split VertexLoaderBase from VertexLoader 2014-12-21 14:12:43 +01:00
degasus
a71c8158d9 VertexLoader: remove inlined getters 
They just blow up the code.
 2014-12-21 13:47:43 +01:00
degasus
1281798992 VertexLoaderUid: remove operator< 
Not needed for unordered map.
 2014-12-21 13:47:43 +01:00
degasus
ec28a80e00 VideoLoader: remove VAT_*_FRACBITS 
They are used to remove the flush amounts, but as we don't
flush anymore on vertex loader changes (only on native
vertex format right now), this optimization is now unneeded.

This will allow us to hard code the frac factors within the
vertex loaders.
 2014-12-21 13:47:42 +01:00
degasus
d5eeb9b713 VideoSW: rewrite VertexLoader to use the VideoCommon one 2014-12-13 10:29:08 +01:00
skidau
d02eb3ca59 Merge pull request #1640 from rohit-n/switch-default 
Silence some -Wswitch-default warnings.
 2014-12-13 19:47:06 +11:00
Rohit Nirmal
b030d29067 Silence some -Wswitch-default warnings. 2014-12-11 22:23:05 -06:00
degasus
02cdb41d3d VideoCommon: Rename s_pCurBufferPointer 2014-12-09 18:56:27 +01:00
degasus
50de4238bb VertexLoader: Move the old Datareader function into VertexLoader 2014-12-09 18:56:27 +01:00
Stevoisiak
6da394a4d0 More formatting and consistency fixes 2014-11-24 17:16:59 -05:00
Fiora
3ddf82a318 Vertex Loader: SSE implementations of more position/texcoord/normal formats 
~35-45% faster NFS:HP2, possibly other vertex-bound games.
 2014-11-20 02:13:19 -08:00
degasus
c211450b99 OGL: implement bounding box support with ssbo 
This implemention tries to be as accurate as the old SW implemention, but it will remove the dependcy of our vertexloader on videosw.
 2014-11-17 21:20:32 +01:00
Stevoisiak
b25e1a2eb4 Various formatting and consistency fixes 2014-11-13 22:42:18 -05:00
Ryan Houdek
13d58b3f16 Merge pull request #1460 from phire/moreGetPointer 
Remove GetPointers in VideoSoftware.
 2014-11-02 09:57:16 -06:00
Lioncash
9ab924513e VideoCommon/VideoBackends: Remove unnecessary wxWidgets references. 
EmuWindow doesn't even exist anymore. wxWidgets is also decoupled from the backends.
 2014-11-01 19:19:00 -04:00
Scott Mansell
b929f764f2 Remove GetPointers in VideoSoftware. 
This same code was previously fixed in VideoCommon, just
updating this to match.

We are down to 121 GetPointers.
 2014-11-01 16:29:19 +13:00
Lioncash
49b94e5285 OGL: Get rid of error macros 2014-10-26 04:54:58 -04:00
comex
00c6ec97a6 Merge pull request #1347 from comex/header-hygiene 
Add missing includes where headers depend on other headers having been included first.
 2014-10-22 23:23:58 -04:00
comex
6e774f1b64 Add missing includes where headers depend on other headers having been included first. 
This is good hygiene, and also happens to be required to build Dolphin
using Clang modules.

(Under this setup, each header file becomes a module, and each #include
is automatically translated to a module import.  Recursive includes
still leak through (by default), but modules are compiled independently,
and can't depend on defines or types having previously been set up.  The
main reason to retrofit it onto Dolphin is compilation performance - no
more textual includes whatsoever, rather than putting a few blessed
common headers into a PCH.  Unfortunately, I found multiple Clang bugs
while trying to build Dolphin this way, so it's not ready yet, but I can
start with this prerequisite.)
 2014-10-21 21:22:16 -04:00
Ryan Houdek
e236d28585 Remove a hard dependency from libGL from the software renderer. 
I must have missed this when dropping OpenGL library includes. This is annoying when on a system that doesn't have libGL.
 2014-10-19 07:48:14 -05:00
skidau
8ef21bc5e2 Merge pull request #1272 from RisingFog/sconfig-dump-frames 
Move bDumpFrames to SConfig (and it's references)
 2014-10-15 13:42:37 +11:00
skidau
9551650c42 Merge pull request #1095 from crudelios/sw-bbox 
Reimplement Bounding Box calculation using the software renderer.
 2014-10-13 15:57:11 +11:00
Lioncash
01f1768c55 Merge pull request #1273 from lioncash/iamanidiot 
Software: Remove obsoleted VideoConfigDialog.
 2014-10-13 00:46:42 -04:00
Lioncash
b315040c6b Software: Remove obsoleted VideoConfigDialog. 2014-10-13 00:30:08 -04:00
Fog
8d424b114a Move bDumpFrames to SConfig (and it's references) 2014-10-12 23:56:16 -04:00
Fog
cd0c784d5a Changed Dump Frames References 2014-10-12 19:51:13 -04:00
crudelios
9786f54414 Fixed a small bug. 2014-10-10 12:28:17 +01:00
crudelios
987bd8bb8f Several small optimizations. 2014-10-10 12:28:16 +01:00
crudelios
176ea06e82 Get buildbot to compile. 2014-10-10 12:28:15 +01:00
crudelios
47c67f014f Fix linux build and various warnings. 
Increase savestate version.
 2014-10-10 12:28:13 +01:00
crudelios
2d4b7e3f3f Reimplement Bounding Box calculation using the software renderer. 2014-10-10 12:27:06 +01:00
comex
7f6284c2fc Change a bunch of reference function arguments to pointers. 
Per the coding style and sanity.
 2014-10-02 03:00:33 -04:00
comex
2eebdff01b Remove useless STACKALIGN macro. 
It only ever did anything on 32-bit OS X.

Anyway, it wasn't even on the right functions, and these days
ABI_PushRegistersAndAdjustStack should handle maintaining the ABI
correctly.
 2014-09-30 01:42:47 -04:00
comex
0ae9e398c8 Rejigger some FIFO buffer variables to be more rational. 
videoBuffer -> s_video_buffer
size -> s_video_buffer_write_ptr
g_pVideoData -> g_video_buffer_read_ptr (impl moved to Fifo.cpp)

This eradicates the wonderful use of 'size' as a global name, and makes
it clear that s_video_buffer_write_ptr and g_video_buffer_read_ptr are
the two ends of the FIFO buffer s_video_buffer.

Oh, and remove a useless namespace {}.
 2014-09-28 21:25:12 -04:00
comex
f0131c2e09 Mechanical changes to move most CP state to a struct rather than separate globals. 
The next commit will add a separate copy of the struct and the ability
for LoadCPReg to work on it.
 2014-09-28 21:23:29 -04:00
Tony Wasserka
1d23c2ca8b GPU: Only load the relevant color components upon writes to the tev color registers. 
The other two components need not be valid upon write, hence loading them results in glitches.

Fixes issue 6783.
 2014-09-21 10:38:22 +02:00
Ryan Houdek
eb23882398 Merge pull request #1120 from rohit-n/muh-precompiled-headers 
Fix build failing when disabling precompiled headers.
 2014-09-19 17:43:42 -05:00
Rohit Nirmal
46057db37d Fix build failing when disabling precompiled headers. 2014-09-19 18:17:51 -04:00
Ryan Houdek
c5f9301e6e Add a comment to the software renderer that stride should be implemented 2014-09-19 12:33:15 -05:00
magumagu
32e5043b29 WIP XFB scaling. 
Still an ugly mess.
 2014-09-19 12:33:15 -05:00
Ryan Houdek
71cb09f1ca Merge pull request #1027 from rohit-n/change-include 
Include CommonTypes.h instead of Common.h.
 2014-09-10 00:35:16 -05:00
Rachel Bryk
f93aa7087c Kill Core::g_CoreStartupParameter. 2014-09-09 00:24:49 -04:00
Rohit Nirmal
fbc64984ca Include CommonTypes.h instead of Common.h. 2014-09-08 15:39:58 -04:00
Jasper St. Pierre
ea1245d191 TextureDecoder: Pass the TLUT address straight into the texture decoder 
This removes the requirement for the TextureDecoder to have access to
global texture memory.
 2014-09-04 18:36:57 -07:00
Jasper St. Pierre
fcd4ecc942 TextureDecoder: Add an enum for the TLUT formats 
Quick code cleanup. The enum names and values come from libogc.
 2014-09-04 18:36:56 -07:00
Shawn Hoffman
266992684d msvc: remove some remnants of SDL and DSound from projects and general cleanup. 2014-09-01 21:27:44 -07:00
Pierre Bourdon
494a60e41b VertexLoader: Change VtxDesc to use u64 instead of u32 
This is required to make packing consistent between compilers: with u32, MSVC
would not allocate a bitfield that spans two u32s (it would leave a "hole").
 2014-09-01 11:18:02 +02:00
Lioncash
1d706b2311 Get rid of C-style empty function parameter indicators 2014-08-30 15:23:48 -04:00
comex
e0f35e0e59 Remove unused declarations. 2014-08-23 15:26:59 -04:00
Lioncash
f17dcd2019 Merge pull request #764 from magcius/new-nogui-2 
Rewrite GLInterface
 2014-08-21 14:14:54 -04:00
Shawn Hoffman
fd16065979 msvc: resolve all warnings in VideoBackends/Software. 2014-08-19 22:33:47 -07:00
Jasper St. Pierre
63f1a16969 Core: Remove UpdateFPSDisplay 
This is effectively unused, as the window handles that we pass to the
GLInterface are window handles for the frame which isn't ever a real
toplevel window. Host_UpdateTitle is what actually sets the proper title
on the render window.
 2014-08-19 10:05:58 -04:00
Jasper St. Pierre
7ca8d8dfc7 Core: Don't pass through a reference to the window handle 
Now that MainNoGUI is properly architected and GLX doesn't need to
sometimes craft its own windows sometimes which we have to thread back
into MainNoGUI, we don't need to thread the window handle that GLX
creates at all.

This removes the reference to pass back here, and the g_pWindowHandle
always be the same as the window returned by Host_GetRenderHandle().

A future cleanup could remove g_pWindowHandle entirely.
 2014-08-19 10:05:58 -04:00
Shawn Hoffman
f1b82a34b2 Windows: Use a shared precompiled header for dolphin code under Source/ 2014-08-14 23:51:13 -07:00
Lioncash
bcd10bfda6 Software: Fix function casing in SWRenderer 2014-08-10 22:28:18 -04:00
Lioncash
f9f46f33d6 Software: Fix some if-statement body placements 2014-08-10 22:28:17 -04:00
Lioncash
34eb0c6e1c Software: Fix over-indentation of SetupQuad() 2014-08-10 22:28:16 -04:00
Lioncash
4129cdeb4d Software: Apply static to some functions 2014-08-10 22:28:15 -04:00
Lioncash
568bdec598 Software: Fix function casing in TextureEncoder 2014-08-10 22:28:14 -04:00
Lioncash
2918f46d8b Software: Fix the formatting and function casing in Vec3.h 2014-08-10 22:28:04 -04:00
Lioncash
6625d9cba5 Software: Fix various brace styling errors 2014-08-10 21:18:38 -04:00
Lioncash
b95d9b43de Software: Make an enum into a static constant in DebugUtil.cpp 2014-08-10 20:51:10 -04:00
Lioncash
b050657322 Software: Make constants char_width and char_height private in RasterFont 2014-08-10 20:48:28 -04:00
Lioncash
6b49ddfec9 Software: Get rid of an unnecessary format string in SWmain.cpp 2014-08-10 04:38:12 -04:00
Lioncash
a66a7e1344 Isolate D3D and Software Renderer from wxWidgets code 2014-08-03 20:28:50 -04:00
Pierre Bourdon
226a9c2392 Move GLInterface around to remove VideoBackends dependency on DolphinWX 2014-08-02 09:34:39 -07:00
Lioncash
522a5c35ad Convert some more header inclusions into forward declarations 2014-07-29 20:55:07 -04:00
Lioncash
4fa71dd59e Remove fakepoll.h. 
It was only used for Windows XP and lower.

This also bumps the _WIN32_WINNT define in the stdafx precompiled headers to set the minimum version as Windows Vista.
 2014-07-26 22:53:40 -04:00
Lioncash
5767691f4e Get rid of a few C-style struct declarations 2014-07-23 20:36:45 -04:00
Pierre Bourdon
2fbdc03572 Merge pull request #642 from phire/vs-constants 
VideoSoftware: Use the same max XFB size as VideoCommon.
 2014-07-18 09:12:36 +02:00
Pierre Bourdon
d44fc48295 SW: Call OnFrameEnd in the FifoPlayer XFB hack. Required to dump DFF frames. 2014-07-17 13:20:13 +02:00
Scott Mansell
2be83c13be VideoSoftware: Use the same max XFB size as VideoCommon. 
And lets just use the same constant as videocommon, so if it ever
increases (again) VideoSoftware will be automatically updated.
 2014-07-17 22:39:09 +12:00
Dolphin Bot
51dff5a74e Merge pull request #622 from phire/sw-fix-frame-dump 
Fixed Frame dumping in VideoSoftware.
 2014-07-17 02:04:03 +02:00
Scott Mansell
92eed47213 Fixed Frame dumping in VideoSoftware. 
Old code dumped the efb, which was no-longer relevant since the
backend gained xfb support.
New code dumps the colour texture which is about to be rendered to
the screen so correctly reflects the bypassXFB option.
 2014-07-17 11:43:59 +12:00
Scott Mansell
b8695a57da Fix incorrect clamping in SWRenderer. 
A previous PR changed a whole lot of min/maxes to std::min/std::max
but made a mistake here and used a templated min which cast it's
arguments to unsigned instead of casting return value.

This resulted in glitchy artifacts in bright areas (See issue 7439)

I rewrote the code to use a proper clamping function so it's cleaner
to read.
 2014-07-15 21:15:49 +12:00
Tillmann Karras
0ccee6c87b Fix warnings unearthed by #579 2014-07-13 02:16:51 +02:00
degasus
7e79806efc remove unused globals 
Also change globals into statics which are only used in one file
 2014-07-11 16:10:20 +02:00
degasus
81ed17be53 avoid the extern keyword in .cpp files 2014-07-11 16:10:20 +02:00
degasus
6d3f249dcc mark all local variables as static 2014-07-11 16:10:20 +02:00
degasus
22e1aa5bb4 mark all local functions as static 2014-07-11 16:07:23 +02:00