310 commits

Author	SHA1	Message	Date
Lioncash	7d017be666	VideoCommon/TextureCacheBase: Make OnConfigChanged's parameter a const reference ... This reference isn't actually modified within this function	2019-08-04 22:31:27 -04:00
Stenzek	53e30c06e8	Config: Add an option to skip saving texture cache to save state	2019-07-24 05:19:22 +10:00
Stenzek	1082468133	TextureCache: Support saving cache entries, including EFB copies	2019-07-24 04:10:38 +10:00
Stenzek	6f53a4d0da	TextureCache: Don't crash when conversion pipelines fail to compile	2019-07-19 15:32:50 +10:00
Stenzek	946571b759	TextureCache: Support reinterpreting formats for VRAM textures	2019-07-14 19:16:27 +10:00
Stenzek	77f406c8a8	TextureCache: Combine ApplyPaletteToEntry and ConvertTexture	2019-07-14 14:07:37 +10:00
Lioncash	d4337eebde	VideoCommon/Statistics: Rename stats global to g_stats ... Makes the global variable follow our convention of prefixing g_ on global variables to make it obvious in surrounding code that it's not a local variable.	2019-07-10 23:34:54 -04:00
Lioncash	a99c7d01e1	VideoCommon/Statistics: Normalize statistic variable names ... Normalizes all variables related to statistics so that they follow our coding style. These are relatively low traffic areas, so this modification isn't too noisy.	2019-07-10 23:19:10 -04:00
Techjar	ff972e3673	Reformat repo to clang-format 7.0 rules	2019-05-06 18:48:04 +00:00
Léo Lam	ab9ece9bca	Replace MathUtil::Clamp with std::clamp	2019-05-04 23:12:17 +02:00
Léo Lam	99a4ca8de7	Merge pull request #7839 from ShFil119/impr/redundant ... Remove redundant initialization	2019-05-04 22:50:51 +02:00
Filip Gawin	c110ffcdaa	Remove redundant initialization	2019-04-30 01:22:24 +02:00
Connor McLaughlin	1b1662773e	Merge pull request #8048 from stenzek/vulkan-negative-scissor-rect ... Vulkan: Don't set a negative offset in scissor rect	2019-04-28 23:37:51 +10:00
Stenzek	53af27b133	FramebufferManager: Fix invalid transitions for 1xIR in EFB cache	2019-04-28 16:13:49 +10:00
Stenzek	d5b3595314	TextureCache: Fix incorrect format string in GetXFBTexture()	2019-04-28 14:32:37 +10:00
Stenzek	f8c1ba409c	Replace EFBRectangle/TargetRectangle with MathUtil::Rectangle	2019-04-21 14:28:14 +10:00
Stenzek	b09a0e1a60	TextureCache: Check for out-of-range partial copy rect after scaling	2019-04-21 12:54:32 +10:00
Stenzek	3791262d96	TextureCache: Use linear filtering on y-scaled and >1xIR VRAM copies	2019-04-21 12:41:15 +10:00
Stenzek	708bd3d9f7	TextureCache: Simplify XFB reconstruction ... This also better handles in-memory interlaced XFB data placed by the CPU by considering the stride from the VI.	2019-04-21 12:41:15 +10:00
Stenzek	3c455de799	FramebufferManager: Fix broken EFB peeks in GL with MSAA on	2019-03-30 03:14:29 +10:00
Stenzek	087b11e780	TextureCacheBase: Fix possible crash on shutdown with deferred EFB copies	2019-03-29 20:54:44 +10:00
Stenzek	bf0b52efc6	TextureCacheBase: Fix infinite loop in DoPartialTextureUpdates	2019-03-20 20:05:51 +10:00
Tilka	6be35422e9	Merge pull request #7832 from stenzek/xfb-decoding-regression ... TextureCache: Fix GPU decoding of XFB copies	2019-02-28 11:03:25 +00:00
Stenzek	db6763019d	TextureCache: Fix GPU decoding of XFB copies not falling back to CPU	2019-02-28 20:19:37 +10:00
Stenzek	7f0111b022	TextureCache: Fix EFB2RAM copies at >1xIR sampling out-of-range	2019-02-28 20:11:46 +10:00
Stenzek	f039149198	Move most backend functionality to VideoCommon	2019-02-19 16:57:54 +10:00
Stenzek	933f3ba008	TextureCache: Don't copy out-of-range rectangles when stitching textures ... This can cause driver crashes or GPU hangs if we do.	2019-02-17 16:35:43 +10:00
Stenzek	50bdcb8d9c	TextureCache: Bind textures/samplers after loading all textures ... Since loading textures can result in rendering, e.g. partial copies, we don't want to disturb partially-bound GX state.	2019-02-17 16:35:43 +10:00
Stenzek	1070192165	TextureCache: Fix a possible crash when partial updating palette textures	2019-01-19 23:38:02 +10:00
Stenzek	84bcbef944	TextureCache: Don't partial copy to non-existant texture layers	2019-01-19 23:38:00 +10:00
Stenzek	ade255a5ff	TextureCache: Fix broken XFB stitching with stereoscopy is enabled	2019-01-19 23:23:21 +10:00
weihuoya	184b2edc30	fx texture overlap	2018-12-25 21:24:25 +08:00
Stenzek	502c4c0e87	TextureCache: Recompute overlapping XFB copy hashes after copying to RAM	2018-11-13 12:48:27 +10:00
Stenzek	78056686fd	TextureCache: Fix leaking TCacheEntry instances	2018-11-08 11:52:17 +10:00
Stenzek	8e2c063d62	TextureCache: Implement deferred/batched EFB copies	2018-11-07 16:25:01 +10:00
Tilka	660fb3fca0	Merge pull request #7412 from AdmiralCurtiss/xfb-stitch-in-order ... Stitch together overlapping XFB regions in order of XFB copy creation.	2018-10-14 12:00:41 +01:00
Admiral H. Curtiss	f2fa63783b	Do not consider XFB copies for invalidating textures when loading a new texture. ... This fixes severe image flickering in some cutscenes of Twin Snakes. The game appears to sometimes load a previously made XFB copy as a texture before it is actually rendered to the screen, which we took as an invitation to invalidate the XFB copy.	2018-09-15 13:56:45 +02:00
Admiral H. Curtiss	3e95d3c477	Stitch together overlapping XFB regions in order of XFB copy creation.	2018-09-14 19:41:27 +02:00
Lioncash	34c3a65de6	VideoCommon/TextureCacheBase: Resolve a -Wmissing-braces warning in GetRAMCopyFilterCoefficients()	2018-07-06 19:56:35 -04:00
Techjar	80b05b6f0d	Make arbitrary mipmap detection toggle invalidate the texture cache ... We want this setting to invalidate the cache because it may affect the appearance of textures in the rendered scene, therefore one would expect changing it while the game is running to have the expected effect immediately.	2018-07-03 18:44:11 -04:00
Jonathan Hamilton	b54803a074	Remove unused sRGB conversion functions ... Now the arbitrary mipmap reference downsampling is just done in linear space, these are no longer used.	2018-07-02 09:53:54 -07:00
Jonathan Hamilton	ac05d1a593	Do all arbitrary mipmap detection in integer space ... This no longer converts from sRGB to linear for the reference mip downsample - even if the original mipmap creation tool used an sRGB colorspace (which isn't really guaranteed, and may even change per game), this is a "fast" heuristic that's only an estimate anyway. The average diff is also now stored in a u64, avoiding floating point calculations in the per-pixel hot loop. This should speed up the detection significantly, hopefully fixing jank when loading in new textures.	2018-07-02 09:52:15 -07:00
Markus Wick	0459a1a9e6	Merge pull request #6875 from JonnyH/WIP/mipmap-heuristic-tweaks ... Make arbitrary mipmap detection a config option	2018-06-21 10:19:47 +02:00
Stenzek	f74dbc794c	EFB2RAM: Apply copy filter as a float coefficient after sampling ... Using 8-bit integer math here lead to precision loss for depth copies, which broke various effects in games, e.g. lens flare in MK:DD. It's unlikely the console implements this as a floating-point multiply (fixed-point perhaps), but since we have the float round trip in our EFB2RAM shaders anyway, it's not going to make things any worse. If we do rewrite our shaders to use integer math completely, then it might be worth switching this conversion back to integers. However, the range of the values (format) should be known, or we should expand all values out to 24-bits first.	2018-05-22 12:24:08 +10:00
Emmanuel Gil Peyrot	17e65a7167	VideoCommon: Replace SOIL with libpng for hires textures	2018-05-20 13:44:38 +02:00
Jonathan Hamilton	b30d56ccc0	Texture AverageDiff: Do more in int space and avoid excessive float conversion ... Multiplying 2x 8bit values is guaranteed to fit in 16bits, 4 channels then in 18bits, which means an 'int' shouild be sufficient to avoid overflows	2018-05-17 09:39:39 -07:00
Markus Wick	c485efdfe1	Merge pull request #6743 from stenzek/faster-disabled-copy-filter ... TextureConversionShader: Don't sample from adjacent rows when not needed	2018-05-17 10:45:50 +02:00
Jonathan Hamilton	61a81795e5	Change the arbitrary mipmap detection to use the square of the error ... Hopefully this better matches the user's view of a texture - as large changes in colour should be weighted higher than lots of very small changes Note: This likely invalidates the current heuristic threshold default	2018-05-16 17:51:50 -07:00
Jonathan Hamilton	8be5cdfcad	Make the arbitrary mipmap detection threshold configureable ... This is likely a "superuser" option at best, but I want to be able to play with it without rebuilding if I want to tweak the heuristics	2018-05-16 17:49:19 -07:00
Jonathan Hamilton	29b7e33c14	Make arbitrary mipmap detection a config option ... Under GFX::Enhancements::ArbitraryMipmapDetection - default enabled	2018-05-16 17:15:38 -07:00
Lioncash	011ee110bc	Common/Hash: Namespace code under the Common namespace ... Brings more common code under the Common namespace.	2018-05-16 15:39:23 -04:00
Stenzek	0152f63655	TextureCacheBase: Make "disable vram copies" part of the active config	2018-05-03 14:24:44 +10:00
Stenzek	4faac3a627	TextureConversionShader: Don't sample from adjacent rows when not needed	2018-05-03 14:09:32 +10:00
Stenzek	9e798eec94	Implement EFB copy filter and gamma in hardware backends ... Also makes y_scale a dynamic parameter for EFB copies, as it doesn't make sense to keep it as part of the uid, otherwise we're generating redundant shaders.	2018-04-29 19:05:20 +10:00
spycrab	40bb9974f2	Reformat all the things!	2018-04-12 21:28:39 +02:00
Lioncash	50a476c371	Assert: Uppercase assertion macros ... Macros should be all upper-cased. This is also kind of a wart that's been sticking out for quite a while now (we avoid prefixing underscores).	2018-03-14 22:03:12 -04:00
Henrik Rydgård	6cbb716f60	SSE-optimize UninitializeXFBMemory ... Lowest hanging fruit I could find with a profiler. Not sure this stuff actually needs to be done, but assuming it is, why not do it quickly? 10x faster, goes from 1% CPU to 0.09%.	2018-03-13 11:55:28 +01:00
Stenzek	93fb0e1e1c	TextureCache: Add an option to disable EFB copies to VRAM ... The option is named DisableCopyToVRAM under the Hacks section in GFX.ini. It is intentionally not exposed to the GUI, as users should not need to use it under normal circumstances. The main use is debugging issues in the EFB-to-RAM shaders.	2018-02-11 15:48:46 +10:00
Stenzek	84b990faa0	VideoConfig: Remove bForceCopyToRam field ... It's the inverse of supports-copy-to-vram.	2018-02-11 15:29:37 +10:00
Stenzek	38e0b6e2ab	AbstractTexture: Move Bind() method to Renderer ... This makes state tracking simpler, and enables easier porting to command lists later on.	2018-01-22 13:22:09 +10:00
JosJuice	c25fffc9a0	Treat custom textures with "_arb" suffix as having arbitrary mipmaps ... This is adapted from Bighead's code that was posted at https://forums.dolphin-emu.org/Thread-dolphin-custom-texture-mipmaps?pid=460867#pid460867 In master, custom textures are never treated as having arbitrary mipmaps, so we need either a change like this or a change that makes us apply the arbitrary mipmap heuristic even when a custom texture is used.	2018-01-10 17:51:45 +01:00
Markus Wick	56d153f548	VideoCommon: Apply the yscale as upscaling of the XFB.	2018-01-06 10:36:33 +01:00
iwubcode	e1332b1d7e	Texture Cache Base: Move PAL vertical scaling to be baked into the texture size. This saves on a number of multiplications and fixes an issue where we were multiplying the y-scaling factor by the srcRectangle's height + 1 which was causing a crash in some GC titles	2017-12-21 21:19:26 -06:00
JosJuice	a3355a3e4a	Only use the "Scaled EFB Copy" setting for EFB, not XFB ... The hybrid XFB PR made it apply to both EFB copies and XFB copies.	2017-12-19 12:59:36 +01:00
Stenzek	2579f8eaa5	TextureCache: Don't dump custom textures ... They don't have a basename, therefore were being saved to empty files, and potentially can be compressed.	2017-12-10 15:31:46 +10:00
degasus	02dd062518	VideoCommon: Drop now unused efb2tex matrix generation.	2017-12-06 09:30:03 +01:00
Markus Wick	491c10ec96	VideoBackends: Use VideoCommon shader generators for efb2tex copies. ... This will generate one shader per copy format. For now, it is the same shader with the colmat hard coded. So it should already improve the GPU performance a bit, but a rewrite of the shader generator is suggested. Half of the patch is done by linkmauve1: VideoCommon: Reorganise the shader writes.	2017-12-02 15:17:39 +01:00
Stenzek	193763ca3a	TextureCacheBase: Don't crop last row/column of XFB copies ... Unsure why this was happening in the first place.	2017-11-22 18:49:33 +10:00
Stenzek	56afebeb44	AbstractTexture: Seperate CopyRectangleFromTexture to two methods ... ScaleRectangleFromTexture, which does a draw, and CopyRectangleFromTexture, which where possible, does a bit-for-bit copy.	2017-11-22 18:47:04 +10:00
Stenzek	49a9c33bd7	VideoCommon: Move abstract texture creation function to Renderer	2017-11-22 18:47:04 +10:00
Leo Lam	80bcc0d58d	Merge pull request #6186 from lioncash/enum-class ... VideoConfig: Make AspectMode and StereoMode enum classes	2017-11-19 15:08:16 +01:00
Lioncash	518f6a3624	VideoCommon: Resolve -Wmissing-brace warnings ... Resolves around 5 -Wmissing-brace warnings on macOS.	2017-11-19 01:49:39 -05:00
Lioncash	5337e58284	VideoConfig: Make StereoMode an enum class ... Makes for more strongly-typed identifiers (and doesn't pollute surrounding namespaces)	2017-11-18 23:19:53 -05:00
iwubcode	dd54617a08	TextureCacheBase: Set uninitialized XFB memory to fuchsia color	2017-11-17 22:11:34 -06:00
iwubcode	8d1cbeb25e	Hybrid XFB: Fix lint errors	2017-11-17 22:11:34 -06:00
iwubcode	61541ab243	Enhance xfb dumping to distinguish between the xfbs created from memory and the xfbs created from overlapping copies	2017-11-17 22:11:34 -06:00
iwubcode	8678e8ddd3	Texture Cache Base: Optimization to allow stitched or memory xfb textures to be looked up from cache directly if they were defined previously and their hash hasn't changed	2017-11-17 22:11:33 -06:00
iwubcode	332af8aa49	TextureCacheBase: Fix issue in Rogue Squadron 2 where overlapping textures caused a hash change which would cause us to do a lookup from memory that gave us an incorrect result in XFB2Ram	2017-11-17 22:11:33 -06:00
iwubcode	ada37ec642	TextureCacheBase: Remove vertical scaling from EFB path and have copy checks only check EFBs	2017-11-17 22:11:33 -06:00
iwubcode	7248dd47d5	Hybrid XFB: Fix lint errors	2017-11-17 22:11:32 -06:00
iwubcode	2c87a53f11	TextureCacheBase: make sure stitching rectangle bounds don't exceed the ... texture size they are meant to represent	2017-11-17 22:11:32 -06:00
iwubcode	74610646ce	TextureCacheBase: Add XFB specific functions	2017-11-17 22:11:32 -06:00
iwubcode	53684701fa	HybridXFB: Fix lint errors	2017-11-17 22:11:31 -06:00
iwubcode	1090549552	Software Backend: Force EFB/XFB to copy to ram	2017-11-17 22:11:31 -06:00
iwubcode	e6d85b0915	Video Common: Avoid 'presenting' duplicate frames by detecting when swap ... hasn't changed since the last frame	2017-11-17 22:11:31 -06:00
iwubcode	2295d60fdc	VideoCommon: Output gamma now comes from the xfb copy	2017-11-17 22:11:30 -06:00
iwubcode	b285188de1	Video Backends: Implement vertical scaling for xfb copies. This fixes the ... display of PAL games that run in 50hz mode.	2017-11-17 22:11:29 -06:00
iwubcode	2cd9565b18	Add an additional flag fo 'XFB Copy'	2017-11-17 22:11:29 -06:00
iwubcode	65cd085f9b	Add new GUI option to skip XFBToRam and remove old XFB options	2017-11-17 22:11:28 -06:00
iwubcode	198d3b69b4	Add ability to dump xfb copies to texture for debugging purposes	2017-11-17 22:11:28 -06:00
iwubcode	79387dddb2	Add support for hybrid XFB	2017-11-17 19:47:56 -06:00
Tommaso Checchi	aa23684d66	Improved detection: it doesn't desaturate the input anymore (woops) also it makes its own whole chain! This way it "notices" much better gradual divergences. Fixes Mario Sunshine, moss on the window in Zelda TP	2017-11-06 21:49:48 -08:00
Tommaso Checchi	5fb6ceac45	Fixed fog, lava, water in Mario Galaxy (and possibly other games) in higher IRs by detecting & fixing the mipmaps that aren't just used for downscaling, but are handmade to create a gradient.	2017-10-27 00:45:20 -07:00
Pierre Bourdon	425a8cb378	Merge pull request #5718 from mimimi085181/partial-updates-update ... Update to partial texture updates	2017-09-03 03:16:55 +02:00
N.E.C	b52aff7966	VideoCommon: Fix typo in comments introduced by #5849	2017-08-09 00:02:27 -07:00
mimimi085181	cdbd9863b4	Keep textures that are overwritten by efb copies, if the stride matches ... This is supposed to get efb2tex to the same texture as efb2ram, by applying the related efb copies as updates after each other, in the order of their creation.	2017-08-06 03:13:57 +02:00
mimimi085181	4e8ff42503	Do not load overwritten textures by hash ... In this case, comparing the hash is not enough to check, if two textures are identical.	2017-08-06 03:13:57 +02:00
mimimi085181	a21ac22e07	fix stored memory stride for normal textures	2017-08-06 03:13:57 +02:00
N.E.C	c3a57bbad5	Video: Clearly separate Texture and EFB Copy formats ... Improve bookkeeping around formats. Hopefully make code less confusing. - Rename TlutFormat -> TLUTFormat to follow conventions. - Use enum classes to prevent using a Texture format where an EFB Copy format is expected or vice-versa. - Use common EFBCopyFormat names regardless of depth and YUV configurations.	2017-08-03 18:35:29 -07:00
Anthony	ab5a5ee3ea	Merge pull request #5726 from mimimi085181/minimal-tmem-cache-emulation ... Implement minimal emulation of TMEM caching	2017-07-11 22:49:19 -07:00