4723 commits

Author	SHA1	Message	Date
Admiral H. Curtiss	0a343007cb	PowerPC: Parametrize LR macro.	2023-01-27 15:22:43 +01:00
Admiral H. Curtiss	be8d0b76ca	PowerPC: Remove PC macro.	2023-01-27 15:22:41 +01:00
Pierre Bourdon	9c9310bf44	Merge pull request #11208 from TellowKrinkle/CPUCull ... Cull vertices on the CPU	2023-01-26 23:15:23 +01:00
TellowKrinkle	a0e6d7c173	VideoCommon: Explicitly disable fp_contract for CPUCull	2023-01-25 02:21:56 -06:00
TellowKrinkle	1be0149146	VideoCommon: Cull vertices on the CPU	2023-01-25 02:21:56 -06:00
TellowKrinkle	b170ef9651	VideoCommon: Add class for quickly transforming and culling vertices on the CPU	2023-01-25 02:21:56 -06:00
Pierre Bourdon	8d5edb13a9	Merge pull request #11367 from Sam-Belliveau/lagbegone ... VideoCommon: VI Skip	2023-01-19 01:20:01 +01:00
Pierre Bourdon	a7d1683149	Merge pull request #11432 from Pokechu22/generic-vertex-loader-test-error ... VertexLoader: Fix loading tangent/binormal caches with NormalIndex3	2023-01-17 23:30:29 +01:00
Sam Belliveau	23ad07b368	Add VISkip	2023-01-14 01:56:37 -05:00
Pokechu22	3910bdd68b	VertexLoader: Don't write position_cache if vertex is skipped ... This is the behavior in the x64 and ARM64 vertex loaders. I don't know if it makes sense (the whole skipped vertex system seems jank, but several games behave incorrectly without it).	2023-01-13 15:38:00 -08:00
Pokechu22	16c0593a52	VertexLoader: Fix loading tangent/binormal caches with NormalIndex3	2023-01-13 15:38:00 -08:00
Pokechu22	2d53b73643	VertexLoaderTester: Add assertions for position/binormal/tangent caches	2023-01-13 15:38:00 -08:00
Pokechu22	c681d96d46	VertexLoaderTester: Use asserts instead of logs ... Logs don't show up in unit tests, and since this is debugging functionality (though not enabled for tests by default) it's better to do it this way.	2023-01-13 15:38:00 -08:00
Sam Belliveau	bc1cc9eeb4	CoreTiming: Throttle Before Every Event Using Chrono	2023-01-06 17:21:17 -05:00
Sam Belliveau	588a72a4fc	PerformanceTracker: Add ownership of m_log_name.	2023-01-06 20:27:25 +01:00
Sam Belliveau	bc46089ab0	PerformanceTracker: Use shared_mutex instead of mutex so multiple threads can read at the same time.	2023-01-06 20:27:25 +01:00
Sam Belliveau	9143eb00fb	PerformanceMetrics: Fix Line Width Issue on Non HiDPI Screens	2023-01-06 20:27:17 +01:00
Mai	cc14d60bbb	Merge pull request #11402 from Pokechu22/too-many-indices ... IndexGenerator: Fix off-by-one in GetRemainingIndices	2023-01-05 15:15:09 +00:00
Pokechu22	cefcd9c93c	IndexGenerator: Fix off-by-one in GetRemainingIndices ... Fixes https://bugs.dolphin-emu.org/issues/13136.	2023-01-04 10:42:00 -08:00
Pokechu22	6c58ba353c	IndexGenerator: Add assertion for overflow in GetRemainingIndices ... This assertion is currently triggered by Pocoyo Racing (https://bugs.dolphin-emu.org/issues/13136).	2023-01-04 10:41:14 -08:00
Admiral H. Curtiss	2fdaf0a86e	HW/ProcessorInterface: Rename member variables to fit naming convention.	2023-01-04 03:17:26 +01:00
Admiral H. Curtiss	74e1577a2c	HW/ProcessorInterface: Refactor to class, move to Core::System.	2023-01-04 03:00:10 +01:00
Pokechu22	d91f340c86	VertexManagerBase: Move free space check to after the buffer is reset ... Fixes incorrect logspam when the buffer needed to be reset on flushes (which we already were doing, but 52feed04db moved it to after the check was made). This is https://bugs.dolphin-emu.org/issues/10312. I also converted it to an assert, as if this does happen, things are going to render incorrectly, so we want to make it obvious.	2023-01-03 17:06:51 -08:00
Admiral H. Curtiss	ed9915308b	Merge pull request #11386 from Pokechu22/manual-texture-sampling-stereoscopic-layer-bounds-check ... PixelShaderGen: Clamp texture layer when using manual texture sampling with stereoscopic 3D	2023-01-03 18:07:06 +01:00
Admiral H. Curtiss	cb0a603c72	VideoCommon: De-globalize GeometryShaderManager class.	2022-12-29 15:33:19 +01:00
Admiral H. Curtiss	7e55cc9e90	VideoCommon/VertexShaderManager: Rename private variables.	2022-12-28 16:00:15 +01:00
Admiral H. Curtiss	50625728e0	VideoCommon: De-globalize VertexShaderManager class.	2022-12-28 15:52:29 +01:00
Pokechu22	f3df3a7727	PixelShaderGen: Clamp texture layer when using manual texture sampling with stereoscopic 3D ... Otherwise, texelFetch() will use an out-of-bounds layer for game textures (that have 1 layer; EFB copies have 2 layers in stereoscopic 3D mode), which is undefined behavior (often resulting in a black image). The fast texture sampling path uses texture(), which always clamps (see https://www.khronos.org/opengl/wiki/Array_Texture#Access_in_shaders), so it was unaffected by this difference.	2022-12-27 13:45:13 -08:00
Admiral H. Curtiss	4549fb4acb	VideoCommon/PixelShaderManager: Rename s_ variables.	2022-12-27 20:20:27 +01:00
Admiral H. Curtiss	725bd64ec2	VideoCommon: De-globalize PixelShaderManager class.	2022-12-27 20:13:24 +01:00
Sam Belliveau	6052a5ca9b	Fix Speed Counter Sample Size	2022-12-26 16:47:12 -05:00
Sam Belliveau	e1d078ada6	Remove Redundant Access Specifiers	2022-12-23 20:13:01 -05:00
Sam Belliveau	673f81c18a	New FrameTime/VBlank Analyzer + Graph	2022-12-23 19:52:53 -05:00
Minty-Meeo	05bebee802	Replace BitUtils with C++20: Counting Zeroes ... With the upgrade to C++20, std::countl_zero and std::countr_zero can replace these home-spun implementations from the BitUtil.h library.	2022-12-21 04:17:00 -06:00
JosJuice	547d956278	Common: Use C++20 <bit> header in BitSet.h	2022-12-18 16:51:32 +01:00
Admiral H. Curtiss	c486baffe6	VideoCommon/PixelEngine: Pass Core::System to methods.	2022-12-11 21:57:30 +01:00
Admiral H. Curtiss	ec8aaf1f30	VideoCommon/PixelEngine: Refactor to class, move to Core::System.	2022-12-11 21:57:19 +01:00
Admiral H. Curtiss	ceae4242fc	VideoCommon/Fifo: Pass Core::System to methods.	2022-12-10 17:16:26 +01:00
Admiral H. Curtiss	5624dd6d39	VideoCommon/Fifo: Refactor to class, move to Core::System.	2022-12-10 17:16:19 +01:00
Admiral H. Curtiss	8a3b8a925e	Core: Add option to force linear texture filtering.	2022-12-09 02:02:16 +01:00
Admiral H. Curtiss	839db591d9	HW/Memmap: Refactor Memory to class, move to Core::System.	2022-12-03 13:27:02 +01:00
Admiral H. Curtiss	6941d2e7e6	VideoCommon/CommandProcessor: Refactor to class, move to Core::System.	2022-11-29 08:15:01 +01:00
Admiral H. Curtiss	c9558ecb4c	CoreTiming: Refactor to class.	2022-11-27 03:47:12 +01:00
Mai	7be4c90f67	Merge pull request #11166 from AdmiralCurtiss/mmio-system ... HW: Pass System to MMIO handlers.	2022-11-24 00:58:45 +00:00
Pokechu22	cc5640245c	Fix build errors related to formatting non-scoped enums	2022-11-23 13:45:43 -08:00
Admiral H. Curtiss	545fee9c94	Core/CommandProcessor: Reformat single/dual core dependent MMIO handlers.	2022-11-23 21:58:18 +01:00
Admiral H. Curtiss	0a6fdb9c13	HW: Pass System to MMIO handlers.	2022-11-23 05:52:21 +01:00
Mai	a47ed2124f	Merge pull request #11253 from AdmiralCurtiss/core-timing-events-pass-system ... CoreTiming: Pass Core::System to Events.	2022-11-23 04:46:11 +00:00
Mai	cb232155d9	Merge pull request #11298 from Pokechu22/vertexloader-no-DataReader ... VertexLoader: Eliminate use of DataReader	2022-11-23 04:40:53 +00:00
Pokechu22	e13094766d	Fix VertexLoader.cpp using the wrong size for texture matrix indices without a corresponding texture ... This regressed in 0a906f553f, I think (though I haven't confirmed it). Mario Tennis and Luigi's Mansion both use these for some reason (as far as I can tell, the data isn't actually used; it's just extra data included for no reason)	2022-11-22 17:49:54 -08:00
Pokechu22	0bcd3c79bb	VertexLoader: Eliminate use of DataReader ... DataReader is generally jank - it has a start and end pointer, but the end pointer is generally not used, and all of the vertex loaders mostly bypassed it anyways. Wrapper code (the vertex loaer test, as well as Fifo.cpp and OpcodeDecoding.cpp) still uses it, as does the software vertex loader (which is not a subclass of VertexLoader). These can probably be eliminated later.	2022-11-22 17:17:11 -08:00
Sam Belliveau	edb2c90b38	Improve FPS/VPS Counting and Revamp Appearance	2022-11-23 00:11:47 +01:00
Pokechu22	8f5a58f8be	Merge pull request #11285 from K0bin/cp-checks ... VideoCommon:VertexLoaderManager: Reduce CPConfig checks	2022-11-21 15:35:06 -08:00
Robin Kertels	f179fd9c33	VideoCommon:VertexLoaderManager: Reduce CPConfig checks ... A bit of a micro optimization: CheckCPConfiguration is called 350 times instead of 35k times.	2022-11-18 01:42:30 +01:00
Pokechu22	1fdf15a1be	VideoCommon/FramebufferManager: Rename m_efb_cache_tiles_wide to m_efb_cache_tile_row_stride ... This also initializes it in the non-tiled case just for consistency, although it's not actually read in that case.	2022-11-15 16:04:41 -08:00
Pokechu22	55e1c3b51d	VideoCommon/FramebufferManager: use !IsUsingTiledEFBCache() in GetEFBCacheTileRect ... This is for readability only, and should behave identically.	2022-11-15 15:48:56 -08:00
Pokechu22	90d05fe37e	VideoCommon/FramebufferManager: Always update frame access mask on depth peeks ... 0e02ddcf52 removed separate logic for tiled versus non-tiled EFB peek caches, and as part of that made it so that color peeks updated the frame access mask even when a non-tiled cache is in use. However, the same change was not made for depth peeks. I'm not sure if this affected anything in practice.	2022-11-15 15:34:03 -08:00
JMC47	8a1c28be63	Merge pull request #11172 from K0bin/efb-refresh ... VideoCommon:FramebufferManager: Mark cache as valid after refresh	2022-11-15 16:33:46 -05:00
TellowKrinkle	37a51f1d09	VideoCommon: Add an option to disable mipmaps ... Needed by M1 fifoci to work around a minor non-determinism bug	2022-11-07 22:18:56 -06:00
Admiral H. Curtiss	a98df18947	VideoCommon: Hold ImGui lock while initializing and shutting down ImGui.	2022-11-06 21:48:55 +01:00
Admiral H. Curtiss	c931529e7a	Merge pull request #11225 from iwubcode/graphics-mod-textureload-callable ... VideoCommon: call texture load graphics mod hook when textures are loaded	2022-11-06 18:58:51 +01:00
Admiral H. Curtiss	1348337277	Merge pull request #11246 from tellowkrinkle/PVDMemset ... VideoCommon: Zero PortableVertexDeclarations on initialization	2022-11-06 18:54:21 +01:00
Admiral H. Curtiss	a36a5c1308	CoreTiming: Pass Core::System to Events.	2022-11-06 17:54:58 +01:00
TellowKrinkle	d9ed9ae331	VideoCommon: Zero PortableVertexDeclarations on initialization ... Fixes an issue where the default initializer wouldn't initialize padding, making for fun non-determinism	2022-11-05 02:02:53 -05:00
Robin Kertels	0e02ddcf52	VideoCommon:FramebufferManager: Cleanup	2022-11-04 01:18:23 +01:00
Robin Kertels	371935d61e	VideoCommon:FramebufferManager: Mark cache as valid after refresh ... Otherwise we might never hit the early return if either depth or color doesnt have any active tiles.	2022-11-04 01:18:23 +01:00
Pokechu22	fe559f3ed3	VideoCommon/Statistics: Require semicolons after statistics macros ... This is clearer and reduces IntelliSense problems.	2022-10-29 15:39:41 -07:00
iwubcode	ea3e133200	VideoCommon: call texture load graphics mod hook when Dolphin loads a texture	2022-10-28 19:24:43 -05:00
Pokechu22	581a575042	VertexLoader: Remove "too many initializer values" workaround functions ... I originally added these in 2b1d1038a6, for both the TPipelineFunction and the size. The size was moved into the header in fdcd2b7d00 (making the size functions obsolete), but it seems that the functions themselves are no longer needed now. I think I didn't use this approach before because it would have required ComponentFormatTable and ComponentCountRow to be templated, which would end up resulting in lines that were too long and thus wrapped in awkward places. (I *think* they didn't get inferred properly.) Now that we only need TPipelineFunction, the templating is not needed, and this ends up being a more readable version of the version with the wrapper functions.	2022-10-25 15:29:09 -07:00
JMC47	9ef7a3b44c	Merge pull request #11207 from Pokechu22/invalid-normal-count ... VideoCommon: Treat invalid normal count as NormalTangentBinormal	2022-10-25 03:17:19 -04:00
Pokechu22	574939b683	VideoCommon: Treat invalid normal count as NormalTangentBinormal ... See https://bugs.dolphin-emu.org/issues/13070.	2022-10-24 22:36:43 -07:00
TellowKrinkle	fa8134deda	VideoBackends:Metal: Default to presentDrawable when vsync is on	2022-10-24 17:55:30 -05:00
JMC47	b66793194e	Merge pull request #11028 from tellowkrinkle/MetalFixes ... Various Metal renderer improvements	2022-10-24 15:22:37 -04:00
TellowKrinkle	1e9b6f88e4	VideoCommon: Support hot reloading of VS expand	2022-10-22 20:18:02 -05:00
TellowKrinkle	3912fa7a2e	VideoCommon: Add reasons for disabled VS expand	2022-10-22 20:18:02 -05:00
TellowKrinkle	b567f3afcf	VideoCommon: Move repeated point/line expansion code to ShaderGenCommon	2022-10-22 20:13:24 -05:00
TellowKrinkle	0a42c534c3	VideoCommon: Add configuration to prefer VS for line/point expansion	2022-10-22 20:13:24 -05:00
TellowKrinkle	68f49df0f8	VideoCommon: Add vertex shader point and line expansion	2022-10-22 20:13:24 -05:00
JMC47	9222956acd	Merge pull request #10859 from tellowkrinkle/UniformBufferSize ... VideoCommon: Increase uniform stream buffer size to 64mb	2022-10-20 17:13:31 -04:00
JMC47	9aece1810c	Merge pull request #10836 from iwubcode/d3d_uint_fix ... VideoCommon: fix uint shader compiler error when using d3d	2022-10-18 12:12:08 -04:00
Pokechu22	ffed23c059	Simplify saving CP state ... Rather than makring some parts of VertexLoaderManager dirty in some places and some in others, do it all in VideoState. Also, since CPState no longer contains pointers/non-CP data after d039b1bc0d, we can just use p.Do on it instead of manually saving each field.	2022-10-09 19:32:59 -07:00
Pokechu22	05f3bbfa4d	Include tangent/binormal cache in savestates ... This theoretically matters for RS2/RS3, although in practice these games reconfigure it each frame so it shouldn't matter for savestates.	2022-10-09 16:21:49 -07:00
iwubcode	bc360584a3	VideoCommon: add structures to graphics mods to allow for future adding or removing parameters with less code overhead	2022-10-09 00:00:01 -05:00
Admiral H. Curtiss	da27a3e6bc	Merge pull request #11095 from K0bin/misc-vulkan ... Remove special treatment for Android in video settings	2022-10-08 22:24:30 +02:00
TellowKrinkle	a13f09433c	VideoBackends:Metal: Add config option to use presentDrawable	2022-10-08 04:46:07 -05:00
TellowKrinkle	c08de82e90	VideoBackends:Metal: Bring back unified memory config ... Turns out it was helpful. (Most improvement in ubershaders.) This time with much better auto mode.	2022-10-08 04:46:05 -05:00
TellowKrinkle	274d4679ca	VideoBackends:Multiple: More GPUs with broken subgroup ops	2022-10-08 04:44:48 -05:00
Pokechu22	e8221d7948	Common/PointerWrap: Remove DoPOD ... This was added in 385d8e2b15, but became somewhat redundant with Do in 4c7bbd96e4, and completely redundant now that std::is_trivially_copyable_v is well-supported.	2022-10-06 11:25:36 -07:00
Robin Kertels	4e204a9a1a	VideoCommon: Remove special treatment for Android in video settings	2022-10-01 20:53:02 +02:00
Robin Kertels	779fe13e62	VideoCommon: Update EFB peek cache on draw done and tokens ... Massively improves performance in Mario Galaxy on Android.	2022-10-01 18:08:38 +02:00
JMC47	68eda7f887	Merge pull request #11084 from K0bin/qcom-workaround ... Vulkan: Workaround slow vkCmdCopyImageToBuffer on QCom	2022-09-30 15:33:00 -04:00
Robin Kertels	81c817c54d	VideoBackends:Vulkan: Workaround slow vkCmdCopyImageToBuffer on QCom driver	2022-09-30 21:13:42 +02:00
Mai	0c19a1d87c	Merge pull request #11100 from Pokechu22/software-settings-merge ... Use the same settings for the software renderer as other backends	2022-09-29 09:05:51 -04:00
Pokechu22	56fce3ba8a	Software: Remove dedicated texture/frame dumping infrastructure ... Texture dumping can already be done using VideoCommon's system (and in fact the same setting already enabled *both* of these). Dumping objects/TEV stages/texture fetches doesn't currently have an equivalent, but could be added to the FIFO player instead.	2022-09-26 18:25:54 -07:00
Pokechu22	39569392bd	VideoCommon: Add statistics for draw done and token commands	2022-09-26 16:19:54 -07:00
Admiral H. Curtiss	b7855a3a56	Merge pull request #11073 from Hibyehello/Fix-Metal-init ... Add Metal as backend option with Vulkan Disabled	2022-09-23 04:21:23 +02:00
JMC47	22197c09a3	Merge pull request #10781 from tellowkrinkle/UberVertexLoader ... VideoCommon: Add dynamic vertex loader for ubershaders to reduce pipeline count	2022-09-20 17:14:07 -04:00
TellowKrinkle	1eb3aaa548	VideoCommon: Use std::array in PortableVertexDeclaration	2022-09-19 16:28:24 -05:00
TellowKrinkle	dae56a24b8	VideoBackends:D3D12: Dynamic vertex loader support	2022-09-19 16:28:24 -05:00
TellowKrinkle	99533d2840	VideoCommon: Add separate pipeline usage for UberShaders	2022-09-19 16:28:24 -05:00