mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2024-09-20 03:11:51 +02:00
6939590598
Now fails if any commands fail. I noticed that on the buildbot, the arguments to this script can be incorrect (somehow?) which can result in no lint checks happening but the buildbot still passing.
42 lines
997 B
Bash
Executable file
42 lines
997 B
Bash
Executable file
#! /bin/bash
|
|
#
|
|
# Linter script that checks for common style issues in Dolphin's codebase.
|
|
|
|
set -euo pipefail
|
|
|
|
fail=0
|
|
|
|
# Default to staged files, unless a commit was passed.
|
|
COMMIT=${1:---cached}
|
|
|
|
# Get modified files (must be on own line for exit-code handling)
|
|
modified_files=$(git diff --name-only --diff-filter=ACMRTUXB $COMMIT)
|
|
|
|
# Loop through each modified file.
|
|
for f in ${modified_files}; do
|
|
# Filter them.
|
|
if ! echo "${f}" | egrep -q "[.](cpp|h|mm)$"; then
|
|
continue
|
|
fi
|
|
if ! echo "${f}" | egrep -q "^Source/Core"; then
|
|
continue
|
|
fi
|
|
|
|
# Check for clang-format issues.
|
|
d=$(clang-format ${f} | (diff -u "${f}" - || true))
|
|
if ! [ -z "${d}" ]; then
|
|
echo "!!! ${f} not compliant to coding style, here is the fix:"
|
|
echo "${d}"
|
|
fail=1
|
|
fi
|
|
|
|
# Check for newline at EOF.
|
|
last_line="$(tail -c 1 ${f})"
|
|
if [ -n "${last_line}" ]; then
|
|
echo "!!! ${f} not compliant to coding style:"
|
|
echo "Missing newline at end of file"
|
|
fail=1
|
|
fi
|
|
done
|
|
|
|
exit ${fail}
|