mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2024-09-21 03:41:42 +02:00
7d9ad88bc5
It's strange to see GameTracker add its own initial paths in construction, because you might expect a race condition where the GameLoaded signal is emitted before it gets connected to in GameListModel. In fact, this doesn't happen, but only because of how it abuses the Qt signals mechanism to load files asynchronously: GameLoader emits a GameLoaded signal which gets forwarded to the GameTracker::GameLoaded signal _after_ control returns to the event loop, at which point GameListModel has connected. This commit moves the logic of adding initial paths out of GameTracker to a point after the signals are connected, which is more obvious and doesn't rely on how GameTracker implements concurrency. |
||
|---|---|---|
| .. | ||
| GameFile.cpp | ||
| GameFile.h | ||
| GameList.cpp | ||
| GameList.h | ||
| GameListModel.cpp | ||
| GameListModel.h | ||
| GameTracker.cpp | ||
| GameTracker.h | ||
| GridProxyModel.cpp | ||
| GridProxyModel.h | ||
| ListProxyModel.cpp | ||
| ListProxyModel.h | ||