archive/pingora
1
0
Fork 0
mirror of https://github.com/cloudflare/pingora.git synced 2024-09-20 02:31:35 +02:00
Code Issues Projects Releases Packages Wiki Activity

Ignore 0.0.0.0 when checking fd mismatch

Browse source 
Avoid false positive since 0.0.0.0 in some systems is mapped
to other IPs.
This commit is contained in:
Yuchen Wu 2024-07-02 16:30:20 -07:00 committed by Yuchen Wu
parent 09b5e03fb1
commit 2ff09e727d
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.bleep
View file

@ -1 +1 @@
940539c7d0bff45d8182d4eb6c40d099b20ed44e 05356d8d19882e125b57f2b855ec744bec733d40

9
pingora-core/src/protocols/mod.rs
View file

@ -29,6 +29,7 @@ pub use ssl::ALPN;
use async_trait::async_trait; use async_trait::async_trait;
use std::fmt::Debug; use std::fmt::Debug;
use std::net::{IpAddr, Ipv4Addr};
use std::sync::Arc; use std::sync::Arc;
/// Define how a protocol should shutdown its connection. /// Define how a protocol should shutdown its connection.
@ -256,6 +257,14 @@ impl ConnFdReusable for InetSocketAddr {
let fd = fd.as_raw_fd(); let fd = fd.as_raw_fd();
match getpeername::<SockaddrStorage>(fd) { match getpeername::<SockaddrStorage>(fd) {
Ok(peer) => { Ok(peer) => {
const ZERO: IpAddr = IpAddr::V4(Ipv4Addr::new(0, 0, 0, 0));
if self.ip() == ZERO {
// https://www.rfc-editor.org/rfc/rfc1122.html#section-3.2.1.3
// 0.0.0.0 should only be used as source IP not destination
// However in some systems this destination IP is mapped to 127.0.0.1.
// We just skip this check here to avoid false positive mismatch.
return true;
}
let addr = SockaddrStorage::from(*self); let addr = SockaddrStorage::from(*self);
if addr == peer { if addr == peer {
debug!("Inet FD to: {addr} is reusable"); debug!("Inet FD to: {addr} is reusable");