rsnext/test/e2e/app-dir/app-fetch-deduping/app-fetch-deduping.test.ts

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

74 lines
2 KiB
TypeScript
Raw Normal View History

remove `staticWorkerRequestDeduping` flag & unused IPC code (#66655) This flag remained experimental because the IPC implementation didn't play nicely with requests containing large payloads, due to it being stringified as GET parameters. This branching logic also poses challenges for some upcoming work related to detecting IO. This removes the handling for the `experimental.staticWorkerRequestDeduping` flag which we can revisit in the future with a sounder approach. This also cleans up some of the IPC server utilities as it wasn't in use anywhere else. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
2024-06-08 01:42:44 +02:00
import { waitFor } from 'next-test-utils'
import { outdent } from 'outdent'
remove `staticWorkerRequestDeduping` flag & unused IPC code (#66655) This flag remained experimental because the IPC implementation didn't play nicely with requests containing large payloads, due to it being stringified as GET parameters. This branching logic also poses challenges for some upcoming work related to detecting IO. This removes the handling for the `experimental.staticWorkerRequestDeduping` flag which we can revisit in the future with a sounder approach. This also cleans up some of the IPC server utilities as it wasn't in use anywhere else. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
2024-06-08 01:42:44 +02:00
import { isNextDev, nextTestSetup } from 'e2e-utils'
describe('app-fetch-deduping', () => {
remove `staticWorkerRequestDeduping` flag & unused IPC code (#66655) This flag remained experimental because the IPC implementation didn't play nicely with requests containing large payloads, due to it being stringified as GET parameters. This branching logic also poses challenges for some upcoming work related to detecting IO. This removes the handling for the `experimental.staticWorkerRequestDeduping` flag which we can revisit in the future with a sounder approach. This also cleans up some of the IPC server utilities as it wasn't in use anywhere else. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
2024-06-08 01:42:44 +02:00
if (isNextDev) {
describe('during next dev', () => {
const { next } = nextTestSetup({ files: __dirname })
function invocation(cliOutput: string): number {
return cliOutput.match(/Route Handler invoked/g).length
}
it('should dedupe requests called from the same component', async () => {
await next.patchFile(
'app/test/page.tsx',
outdent`
async function getTime() {
const res = await fetch("http://localhost:${next.appPort}/api/time")
return res.text()
}
export default async function Home() {
await getTime()
await getTime()
const time = await getTime()
return <h1>{time}</h1>
}`
)
await next.render('/test')
expect(invocation(next.cliOutput)).toBe(1)
await next.stop()
})
it('should dedupe pending revalidation requests', async () => {
await next.start()
const revalidate = 5
await next.patchFile(
'app/test/page.tsx',
outdent`
async function getTime() {
const res = await fetch("http://localhost:${next.appPort}/api/time", { next: { revalidate: ${revalidate} } })
return res.text()
}
export default async function Home() {
await getTime()
await getTime()
const time = await getTime()
return <h1>{time}</h1>
}`
)
await next.render('/test')
expect(invocation(next.cliOutput)).toBe(1)
// wait for the revalidation to finish
await waitFor(revalidate * 1000 + 1000)
await next.render('/test')
expect(invocation(next.cliOutput)).toBe(2)
})
})
} else {
it('should skip other scenarios', () => {})
return
}
})