archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add name to invalidated span (#29170)

Browse source
This commit is contained in:
Tim Neutkens 2021-09-17 09:34:37 +02:00 committed by GitHub
parent 29ab433222
commit 002ed25087
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/next/build/webpack/plugins/profiling-plugin.ts
View file

@ -28,7 +28,7 @@ export class ProfilingPlugin {
}
traceHookPair(
spanName: string,
spanName: string | (() => string),
startHook: any,
stopHook: any,
{
@ -45,13 +45,11 @@ export class ProfilingPlugin {
) {
let span: Span | undefined
startHook.tap(pluginName, (...params: any[]) => {
const name = typeof spanName === 'function' ? spanName() : spanName
const attributes = attrs ? attrs(...params) : attrs
if (spanName === 'webpack-invalidated' && attributes.name === 'client') {
debugger
}
span = parentSpan
? parentSpan().traceChild(spanName, attributes)
: this.runWebpackSpan.traceChild(spanName, attributes)
? parentSpan().traceChild(name, attributes)
: this.runWebpackSpan.traceChild(name, attributes)
if (onStart) onStart(span)
})
@ -83,14 +81,13 @@ export class ProfilingPlugin {
if (compiler.options.mode === 'development') {
this.traceHookPair(
'webpack-invalidated',
() => `webpack-invalidated-${compiler.name}`,
compiler.hooks.invalid,
compiler.hooks.done,
{
onStart: (span) => webpackInvalidSpans.set(compiler, span),
onStop: () => webpackInvalidSpans.delete(compiler),
attrs: (fileName: any) => ({
name: compiler.name,
trigger: fileName || 'manual',
}),
}