Add additional file serving tests (#12479)

* Test `static/` file name encoding

* Fix `static/` file name encoding

* Add additional file-serving tests

* bump

Co-authored-by: Joe Haddad <joe.haddad@zeit.co>

packages/next/server/next-dev-server.ts

@@ -272,9 +272,21 @@ export default class DevServer extends Server {
   }
 
   protected async hasPage(pathname: string): Promise<boolean> {
+    let normalizedPath: string
+
+    try {
+      normalizedPath = normalizePagePath(pathname)
+    } catch (err) {
+      console.error(err)
+      // if normalizing the page fails it means it isn't valid
+      // so it doesn't exist so don't throw and return false
+      // to ensure we return 404 instead of 500
+      return false
+    }
+
     const pageFile = await findPageFile(
       this.pagesDir!,
-      normalizePagePath(pathname),
+      normalizedPath,
       this.nextConfig.pageExtensions
     )
     return !!pageFile

test-file.txt

@@ -0,0 +1 @@
+this is used for traverse testing

test/integration/file-serving/pages/index.js

@@ -0,0 +1 @@
+export default () => 'hi'

test/integration/file-serving/public/hello world.txt

@@ -0,0 +1 @@
+hi

test/integration/file-serving/static/hello world.txt

@@ -0,0 +1 @@
+hi

test/integration/file-serving/test-file.txt

@@ -0,0 +1 @@
+this is used for traverse testing

test/integration/test-file.txt

@@ -0,0 +1 @@
+this is used for traverse testing

test/lib/next-test-utils.js

@@ -172,7 +172,10 @@ export function runNextCommandDev(argv, stdOut, opts = {}) {
       if (typeof opts.onStdout === 'function') {
         opts.onStdout(message)
       }
-      process.stdout.write(message)
+
+      if (opts.stdout !== false) {
+        process.stdout.write(message)
+      }
     }
 
     function handleStderr(data) {
@@ -180,7 +183,10 @@ export function runNextCommandDev(argv, stdOut, opts = {}) {
       if (typeof opts.onStderr === 'function') {
         opts.onStderr(message)
       }
-      process.stderr.write(message)
+
+      if (opts.stderr !== false) {
+        process.stderr.write(message)
+      }
     }
 
     instance.stdout.on('data', handleStdout)

test/test-file.txt

@@ -0,0 +1 @@
+this is used for traverse testing