archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix actions-navigation deploy test (#66850)

Browse source 
Switches to reading action result from state rather than runtime logs.
This commit is contained in:
Zack Tanner 2024-06-13 16:57:26 -07:00 committed by GitHub
parent 4dd26753d9
commit 02de207967
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
test/deploy-tests-manifest.json
View file

@ -36,7 +36,6 @@
"test/e2e/app-dir/mdx/mdx.test.ts", "test/e2e/app-dir/mdx/mdx.test.ts",
"test/e2e/app-dir/modularizeimports/modularizeimports.test.ts", "test/e2e/app-dir/modularizeimports/modularizeimports.test.ts",
"test/e2e/app-dir/third-parties/basic.test.ts", "test/e2e/app-dir/third-parties/basic.test.ts",
"test/e2e/app-dir/actions-navigation/index.test.ts",
"test/e2e/app-dir/app-static/app-static-custom-handler.test.ts", "test/e2e/app-dir/app-static/app-static-custom-handler.test.ts",
"test/e2e/app-dir/options-request/options-request.test.ts", "test/e2e/app-dir/options-request/options-request.test.ts",
"test/e2e/app-dir/revalidate-dynamic/revalidate-dynamic.test.ts", "test/e2e/app-dir/revalidate-dynamic/revalidate-dynamic.test.ts",

2
test/e2e/app-dir/actions-navigation/app/nested-folder/(foo)/product-category/[...slugs]/actions.js
View file

@ -1,5 +1,5 @@
'use server' 'use server'
export async function addToCart() { export async function addToCart() {
console.log('addToCart') return 'Added to cart!'
} }

6
test/e2e/app-dir/actions-navigation/app/nested-folder/(foo)/product-category/[...slugs]/page.js
View file

@ -1,5 +1,5 @@
'use client' 'use client'
import { useFormStatus } from 'react-dom' import { useFormStatus, useFormState } from 'react-dom'
import { addToCart } from './actions' import { addToCart } from './actions'
function SubmitButton() { function SubmitButton() {
@ -13,10 +13,12 @@ function SubmitButton() {
} }
export default function Page() { export default function Page() {
const [state, formAction] = useFormState(addToCart)
return ( return (
<> <>
<h1>Add to cart</h1> <h1>Add to cart</h1>
<form action={addToCart}> {state && <div id="result">{state}</div>}
<form action={formAction}>
<SubmitButton /> <SubmitButton />
</form> </form>
</> </>

8
test/e2e/app-dir/actions-navigation/index.test.ts
View file

@ -1,5 +1,5 @@
import { nextTestSetup } from 'e2e-utils' import { nextTestSetup } from 'e2e-utils'
import { check, waitFor } from 'next-test-utils' import { check, waitFor, retry } from 'next-test-utils'
describe('app-dir action handling', () => { describe('app-dir action handling', () => {
const { next } = nextTestSetup({ const { next } = nextTestSetup({
@ -40,8 +40,8 @@ describe('app-dir action handling', () => {
await browser.elementByCss('button').click() await browser.elementByCss('button').click()
await check(() => { await retry(async () => {
return (next.cliOutput.match(/addToCart/g) || []).length expect(await browser.elementById('result').text()).toBe('Added to cart!')
}, 1) })
}) })
}) })