archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix pnpm ERR_INVALID_THIS on Node 20 (#51406)

Browse source 
### What?

Fixes pnpm/pnpm#6424

### Why?

So users of Node 20 can contribute to Next.js

### How?

Upgrades pnpm with back compatibility to patch `ERR_INVALID_THIS` error.
If Node 14 support isn't necessary, I'd recommend upgrading to pnpm 8
for continued feature support and committing the lockfile.

---------

Co-authored-by: JJ Kasper <jj@jjsweb.site>
This commit is contained in:
Nick McCurdy 2023-06-16 08:37:11 -04:00 committed by GitHub
parent d6952989a8
commit 1602c2af25
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/actions/next-stats-action/Dockerfile vendored
View file

@ -14,7 +14,7 @@ RUN ln $(which python3) /usr/bin/python
RUN curl -sfLS https://install-node.vercel.app/v18 | bash -s -- -f
# Install node_modules
RUN npm i -g pnpm@7.24.3 yarn@1.22.19
RUN npm i -g pnpm@7.32.2 yarn@1.22.19
RUN cd /next-stats && pnpm install --production
RUN git config --global user.email 'stats@localhost'

2
.github/workflows/build_and_deploy.yml vendored
View file

@ -8,7 +8,7 @@ on:
env:
NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3
PNPM_VERSION: 7.32.2
NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18

2
.github/workflows/build_and_test.yml vendored
View file

@ -9,7 +9,7 @@ on:
env:
NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3
PNPM_VERSION: 7.32.2
NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18
TEST_CONCURRENCY: 6

2
.github/workflows/build_reusable.yml vendored
View file

@ -47,7 +47,7 @@ on:
env:
NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3
PNPM_VERSION: 7.32.2
NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18
TEST_CONCURRENCY: 6

2
.github/workflows/pull_request_stats.yml vendored
View file

@ -7,7 +7,7 @@ name: Generate Pull Request Stats
env:
NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3
PNPM_VERSION: 7.32.2
NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18
TEST_CONCURRENCY: 6

2
.github/workflows/test_examples.yml vendored
View file

@ -14,7 +14,7 @@ on:
name: Test examples
env:
PNPM_VERSION: 7.24.3
PNPM_VERSION: 7.32.2
jobs:
testExamples:

2
.github/workflows/trigger_release.yml vendored
View file

@ -26,7 +26,7 @@ name: Trigger Release
env:
NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.9.6
PNPM_VERSION: 7.24.3
PNPM_VERSION: 7.32.2
NODE_MAINTENANCE_VERSION: 16
NODE_LTS_VERSION: 18

2
azure-pipelines.yml
View file

@ -33,7 +33,7 @@ pr:
variables:
PNPM_CACHE_FOLDER: $(Pipeline.Workspace)/.pnpm-store
PNPM_VERSION: 7.24.3
PNPM_VERSION: 7.32.2
NEXT_TELEMETRY_DISABLED: '1'
node_16_version: ^16.8.0

4
package.json
View file

@ -51,7 +51,7 @@
"clean-trace-jaeger": "node scripts/rm.mjs test/integration/basic/.next && TRACE_TARGET=JAEGER pnpm next build test/integration/basic",
"debug": "cross-env NEXT_TELEMETRY_DISABLED=1 node --inspect packages/next/dist/bin/next",
"postinstall": "git config index.skipHash false && node scripts/install-native.mjs",
"version": "npx pnpm@7.24.3 install --no-frozen-lockfile && IS_PUBLISH=yes ./scripts/check-pre-compiled.sh && git add .",
"version": "npx pnpm@7.32.2 install --no-frozen-lockfile && IS_PUBLISH=yes ./scripts/check-pre-compiled.sh && git add .",
"prepare": "husky install",
"sync-react": "node ./scripts/sync-react.js",
"update-google-fonts": "node ./scripts/update-google-fonts.js"
@ -239,5 +239,5 @@
"engines": {
"node": ">=16.8.0"
},
"packageManager": "pnpm@7.24.3"
"packageManager": "pnpm@7.32.2"
}