archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Updating avg width metrics for google fonts (#41755)

Browse source 
Updating the average with using the string
"aaabcdeeeefghiijklmnnoopqrrssttuvwxyz "

<!--
Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change that you're making:


## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

-->

Co-authored-by: Hannes Bornö <hannes.borno@vercel.com>
This commit is contained in:
Janicklas Ralph 2022-10-24 21:17:32 -07:00 committed by GitHub
parent 10e7d45231
commit 16c7480fcf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12609 additions and 12717 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25320
packages/next/server/google-font-metrics.json
View file

File diff suppressed because it is too large Load diff

6
test/integration/font-optimization/test/index.test.js
View file

@ -332,14 +332,14 @@ describe('Font Optimization', () => {
)
expect(inlineStyle.length).toBe(1)
expect(inlineStyle.html()).toContain(
'@font-face{font-family:"Roboto Fallback";ascent-override:91.03%;descent-override:23.95%;line-gap-override:0.00%;size-adjust:101.92%;src:local("Arial")}'
'@font-face{font-family:"Roboto Fallback";ascent-override:99.23%;descent-override:26.11%;line-gap-override:0.00%;size-adjust:93.49%;src:local("Arial")}'
)
expect(inlineStyleMultiple.length).toBe(1)
expect(inlineStyleMultiple.html()).toContain(
'@font-face{font-family:"Libre Baskerville Fallback";ascent-override:75.85%;descent-override:21.11%;line-gap-override:0.00%;size-adjust:127.88%;src:local("Times New Roman")}'
'@font-face{font-family:"Libre Baskerville Fallback";ascent-override:83.98%;descent-override:23.37%;line-gap-override:0.00%;size-adjust:115.51%;src:local("Times New Roman")}@font-face{font-family:"Open Sans Fallback";ascent-override:108.98%;descent-override:29.87%;line-gap-override:0.00%;size-adjust:98.08%;src:local("Arial")}'
)
expect(inlineStyleMultiple.html()).toContain(
'@font-face{font-family:"Open Sans Fallback";ascent-override:100.16%;descent-override:27.45%;line-gap-override:0.00%;size-adjust:106.71%;src:local("Arial")}'
'@font-face{font-family:"Open Sans Fallback";ascent-override:108.98%;descent-override:29.87%;line-gap-override:0.00%;size-adjust:98.08%;src:local("Arial")}'
)
})
})