Allow for shortened names for certain items (#9949)

* Use smaller name as it's not shortened

* Remove export as it's not used and it'll be shortened

* Update size

Co-authored-by: Joe Haddad <timer150@gmail.com>

packages/next/client/index.js

@@ -4,11 +4,7 @@ import ReactDOM from 'react-dom'
 import HeadManager from './head-manager'
 import { createRouter, makePublicRouterInstance } from 'next/router'
 import mitt from '../next-server/lib/mitt'
-import {
-  loadGetInitialProps,
-  getURL,
-  SUPPORTS_PERFORMANCE_USER_TIMING,
-} from '../next-server/lib/utils'
+import { loadGetInitialProps, getURL, ST } from '../next-server/lib/utils'
 import PageLoader from './page-loader'
 import * as envConfig from '../next-server/lib/runtime-config'
 import { HeadManagerContext } from '../next-server/lib/head-manager-context'
@@ -70,7 +66,7 @@ const appElement = document.getElementById('__next')
 let lastAppProps
 let webpackHMR
 export let router
-export let ErrorComponent
+let ErrorComponent
 let Component
 let App, onPerfEntry
 
@@ -187,7 +183,7 @@ export default async ({ webpackHMR: passedWebpackHMR } = {}) => {
     wrapApp,
     err: initialErr,
     subscription: ({ Component, props, err }, App) => {
-      render({ App, Component, props, err, emitter })
+      render({ App, Component, props, err })
     },
   })
 
@@ -203,7 +199,7 @@ export default async ({ webpackHMR: passedWebpackHMR } = {}) => {
       })
   }
 
-  const renderCtx = { App, Component, props, err: initialErr, emitter }
+  const renderCtx = { App, Component, props, err: initialErr }
   render(renderCtx)
 
   return emitter
@@ -272,7 +268,7 @@ let isInitialRender = typeof ReactDOM.hydrate === 'function'
 let reactRoot = null
 function renderReactElement(reactEl, domEl) {
   // mark start of hydrate/render
-  if (SUPPORTS_PERFORMANCE_USER_TIMING) {
+  if (ST) {
     performance.mark('beforeRender')
   }
 
@@ -297,7 +293,7 @@ function renderReactElement(reactEl, domEl) {
     }
   }
 
-  if (onPerfEntry && SUPPORTS_PERFORMANCE_USER_TIMING) {
+  if (onPerfEntry && ST) {
     if (!(PerformanceObserver in window)) {
       window.addEventListener('load', () => {
         performance.getEntriesByType('paint').forEach(onPerfEntry)
@@ -312,7 +308,7 @@ function renderReactElement(reactEl, domEl) {
 }
 
 function markHydrateComplete() {
-  if (!SUPPORTS_PERFORMANCE_USER_TIMING) return
+  if (!ST) return
 
   performance.mark('afterHydrate') // mark end of hydration
 
@@ -330,7 +326,7 @@ function markHydrateComplete() {
 }
 
 function markRenderComplete() {
-  if (!SUPPORTS_PERFORMANCE_USER_TIMING) return
+  if (!ST) return
 
   performance.mark('afterRender') // mark end of render
   const navStartEntries = performance.getEntriesByName('routeChange', 'mark')

packages/next/next-server/lib/router/router.ts

@@ -11,7 +11,7 @@ import {
   getURL,
   loadGetInitialProps,
   NextPageContext,
-  SUPPORTS_PERFORMANCE_USER_TIMING,
+  ST,
 } from '../utils'
 import { isDynamicRoute } from './utils/is-dynamic'
 import { getRouteMatcher } from './utils/route-matcher'
@@ -268,7 +268,7 @@ export default class Router implements BaseRouter {
         this.isSsr = false
       }
       // marking route changes as a navigation start entry
-      if (SUPPORTS_PERFORMANCE_USER_TIMING) {
+      if (ST) {
         performance.mark('routeChange')
       }
 

packages/next/next-server/lib/utils.ts

@@ -325,8 +325,8 @@ export function formatWithValidation(
   return format(url as any, options)
 }
 
-export const SUPPORTS_PERFORMANCE = typeof performance !== 'undefined'
-export const SUPPORTS_PERFORMANCE_USER_TIMING =
-  SUPPORTS_PERFORMANCE &&
+export const SP = typeof performance !== 'undefined'
+export const ST =
+  SP &&
   typeof performance.mark === 'function' &&
   typeof performance.measure === 'function'

test/integration/size-limit/test/index.test.js

@@ -81,7 +81,7 @@ describe('Production response size', () => {
     )
 
     // These numbers are without gzip compression!
-    const delta = responseSizeKilobytes - 230
+    const delta = responseSizeKilobytes - 228
     expect(delta).toBeLessThanOrEqual(0) // don't increase size
     expect(delta).toBeGreaterThanOrEqual(-1) // don't decrease size without updating target
   })