archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "perf: improve URL validation performance" (#52818)

Browse source 
> https://github.com/nodejs/node/issues/48816

This was an unsafe change that caused errors to the user due to a bug in Node and a fix will get upstreamed soon but in the meantime we should reverse this.

Reverts vercel/next.js#52353
This commit is contained in:
Jimmy Lai 2023-07-18 10:52:18 +02:00 committed by GitHub
parent 299e830b8f
commit 33385aaded
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
packages/next/src/server/app-render/validate-url.tsx
View file

@ -1,25 +1,10 @@
const DUMMY_ORIGIN = 'http://n'
const INVALID_URL_MESSAGE = 'Invalid request URL'
// URL.canParse is supported on Node 19 and 20.
// Node 18 backport is pending.
// Reference: https://github.com/nodejs/node/pull/48345
const supportsCanParse = URL.hasOwnProperty('canParse')
export function validateURL(url: string | undefined): string {
if (url == null) {
if (!url) {
throw new Error(INVALID_URL_MESSAGE)
}
if (supportsCanParse) {
// @ts-ignore
if (!URL.canParse(url, DUMMY_ORIGIN)) {
throw new Error(INVALID_URL_MESSAGE)
}
return url
}
try {
const parsed = new URL(url, DUMMY_ORIGIN)
// Avoid origin change by extra slashes in pathname