archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove legacy handling for suspense option of next/dynamic (#57900)

Browse source 
This part was removed before but added in back during the merging of turbopack and legacy `next-swc` changes. Remove them again
This commit is contained in:
Jiachi Liu 2023-11-01 18:47:32 +01:00 committed by GitHub
parent 337f33b3c9
commit 62267ec7c7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
packages/next-swc/crates/next-transform-dynamic/src/lib.rs
View file

@ -326,7 +326,6 @@ impl Fold for NextDynamicPatcher {
})))];
let mut has_ssr_false = false;
let mut has_suspense = false;
if expr.args.len() == 2 {
if let Expr::Object(ObjectLit {
@ -359,15 +358,6 @@ impl Fold for NextDynamicPatcher {
has_ssr_false = true
}
}
if sym == "suspense" {
if let Some(Lit::Bool(Bool {
value: true,
span: _,
})) = value.as_lit()
{
has_suspense = true
}
}
}
}
}
@ -375,17 +365,10 @@ impl Fold for NextDynamicPatcher {
}
}
// Don't strip the `loader` argument if suspense is true
// See https://github.com/vercel/next.js/issues/36636 for background.
// Also don't strip the `loader` argument for server components (both
// server/client layers), since they're aliased to a
// React.lazy implementation.
if has_ssr_false
&& !has_suspense
&& self.is_server_compiler
&& !self.is_react_server_layer
{
if has_ssr_false && self.is_server_compiler && !self.is_react_server_layer {
expr.args[0] = Lit::Null(Null { span: DUMMY_SP }).as_arg();
}