archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Disable head element lint rule for appDir (#40921)

Browse source 
Only lint `<head>` elements usage in `pages/`, `<head>` should be able
to use in appDir
This commit is contained in:
Jiachi Liu 2022-09-27 00:20:16 +02:00 committed by GitHub
parent 3837aa1cb0
commit 82682a3a53
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/eslint-plugin-next/lib/rules/no-head-element.js
View file

@ -14,7 +14,11 @@ module.exports = {
create: function (context) {
return {
JSXOpeningElement(node) {
if (node.name.name !== 'head') {
const paths = context.getFilename()
const isInAppDir = paths.includes('app/') && !paths.includes('pages/')
// Only lint the <head> element in pages directory
if (node.name.name !== 'head' || isInAppDir) {
return
}

17
test/unit/eslint-plugin-next/no-head-element.test.ts
View file

@ -48,6 +48,21 @@ ruleTester.run('no-head-element', rule, {
`,
filename: 'pages/index.tsx',
},
{
code: `
export default function Layout({ children }) {
return (
<html>
<head>
<title>layout</title>
</head>
<body>{children}</body>
</html>
);
}
`,
filename: './app/layout.js',
},
],
invalid: [
{
@ -63,7 +78,7 @@ ruleTester.run('no-head-element', rule, {
);
}
}`,
filename: 'pages/index.js',
filename: './pages/index.js',
errors: [
{
message: