archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Simplify test checks (#14094)

Browse source 
Fixes #14093
This commit is contained in:
Joe Haddad 2020-06-11 15:02:53 -04:00 committed by GitHub
parent 7e1d174e8e
commit 8ae10601b1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 52 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

59
test/integration/config/test/index.test.js
View file

@ -53,11 +53,7 @@ describe('Configuration', () => {
await check(
() => browser.elementByCss('.hello-world').getComputedCss('font-size'),
{
test(content) {
return content === '100px'
},
}
'100px'
)
} finally {
if (browser) {
@ -75,11 +71,7 @@ describe('Configuration', () => {
browser
.elementByCss('.hello-world')
.getComputedCss('background-color'),
{
test(content) {
return content === 'rgba(0, 0, 255, 1)'
},
}
'rgba(0, 0, 255, 1)'
)
} finally {
if (browser) {
@ -128,18 +120,11 @@ describe('Configuration', () => {
try {
browser = await webdriver(context.appPort, '/webpack-css')
await check(
async () => {
const pTag = await browser.elementByCss('.hello-world')
const initialFontSize = await pTag.getComputedCss('font-size')
return initialFontSize
},
{
test(content) {
return content === '100px'
},
}
)
await check(async () => {
const pTag = await browser.elementByCss('.hello-world')
const initialFontSize = await pTag.getComputedCss('font-size')
return initialFontSize
}, '100px')
const pagePath = join(
__dirname,
@ -159,11 +144,7 @@ describe('Configuration', () => {
await check(
() =>
browser.elementByCss('.hello-world').getComputedCss('font-size'),
{
test(content) {
return content === '200px'
},
}
'200px'
)
} finally {
// Finally is used so that we revert the content back to the original regardless of the test outcome
@ -173,11 +154,7 @@ describe('Configuration', () => {
await check(
() =>
browser.elementByCss('.hello-world').getComputedCss('font-size'),
{
test(content) {
return content === '100px'
},
}
'100px'
)
}
} finally {
@ -196,32 +173,20 @@ describe('Configuration', () => {
browser = await webdriver(context.appPort, '/webpack-css')
await check(
() => browser.elementByCss('.hello-world').getComputedCss('color'),
{
test(content) {
return content === 'rgba(255, 255, 0, 1)'
},
}
'rgba(255, 255, 0, 1)'
)
try {
file.replace('yellow', 'red')
await check(
() => browser.elementByCss('.hello-world').getComputedCss('color'),
{
test(content) {
return content === 'rgba(255, 0, 0, 1)'
},
}
'rgba(255, 0, 0, 1)'
)
} finally {
file.restore()
await check(
() => browser.elementByCss('.hello-world').getComputedCss('color'),
{
test(content) {
return content === 'rgba(255, 255, 0, 1)'
},
}
'rgba(255, 255, 0, 1)'
)
}
} finally {

6
test/integration/css/test/index.test.js
View file

@ -357,11 +357,7 @@ describe('CSS Support', () => {
browser.eval(
`window.getComputedStyle(document.querySelector('.red-text')).color`
),
{
test(content) {
return content === 'rgb(128, 0, 128)'
},
}
'rgb(128, 0, 128)'
)
// ensure text remained