archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update default moduleResolution in tsconfig.json from node to bundler (#51957)

Browse source 
This updates our `moduleResolution` to `bundler` as this matches our heuristics much more closely so is more accurate. This shouldn't be a breaking change is it should be compatible with our previous default. 

Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
This commit is contained in:
Facundo Giuliani 2023-07-18 12:11:09 -03:00 committed by GitHub
parent 3f1b9178cc
commit a26bac9604
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
57 changed files with 59 additions and 57 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/create-next-app/templates/app-tw/ts/tsconfig.json
View file

@ -9,7 +9,7 @@
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
packages/create-next-app/templates/app/ts/tsconfig.json
View file

@ -9,7 +9,7 @@
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
packages/create-next-app/templates/default-tw/ts/tsconfig.json
View file

@ -9,7 +9,7 @@
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
packages/create-next-app/templates/default/ts/tsconfig.json
View file

@ -9,7 +9,7 @@
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
packages/next/src/lib/typescript/writeConfigurationDefaults.ts
View file

@ -58,6 +58,8 @@ function getDesiredCompilerOptions(
moduleResolution: {
// In TypeScript 5.0, `NodeJs` has renamed to `Node10`
parsedValue:
ts.ModuleResolutionKind.Bundler ??
ts.ModuleResolutionKind.NodeNext ??
(ts.ModuleResolutionKind as any).Node10 ??
ts.ModuleResolutionKind.NodeJs,
// All of these values work:

2
test/development/acceptance-app/fixtures/app-hmr-changes/tsconfig.json
View file

@ -10,7 +10,7 @@
"lib": ["dom", "dom.iterable", "esnext"],
"allowJs": true,
"noEmit": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"incremental": true,

2
test/development/basic/define-class-fields/tsconfig.json
View file

@ -12,7 +12,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
}

2
test/development/jsconfig-path-reloading/app/jsconfig.json
View file

@ -10,7 +10,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/development/tsconfig-path-reloading/app/tsconfig.json
View file

@ -10,7 +10,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/app-alias/tsconfig.json
View file

@ -9,7 +9,7 @@
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/app-routes/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/create-next-app-template/tsconfig.json
View file

@ -10,7 +10,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/edge-runtime-node-compatibility/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/interception-middleware-rewrite/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/metadata-suspense/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/parallel-routes-and-interception/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/parallel-routes-not-found/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/root-layout-redirect/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/router-stuck-dynamic-static-segment/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/searchparams-static-bailout/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/underscore-ignore-app-paths/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/app-dir/use-params/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/instrumentation-hook-src/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/e2e/multi-zone/app/apps/first/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve"

2
test/e2e/multi-zone/app/apps/second/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve"

2
test/e2e/new-link-behavior/typescript/tsconfig.json
View file

@ -10,7 +10,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve"

2
test/integration/app-tree/tsconfig.json
View file

@ -10,7 +10,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/integration/app-types/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/integration/custom-server-types/tsconfig.json
View file

@ -11,7 +11,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/draft-mode/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/integration/eslint/with-typescript/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/integration/import-assertion/tsconfig.json
View file

@ -10,7 +10,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve"

2
test/integration/next-image-legacy/svgo-webpack/tsconfig.json
View file

@ -9,7 +9,7 @@
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve"

2
test/integration/next-image-legacy/typescript/tsconfig.json
View file

@ -11,7 +11,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/next-image-new/svgo-webpack/tsconfig.json
View file

@ -9,7 +9,7 @@
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/integration/next-image-new/typescript/tsconfig.json
View file

@ -11,7 +11,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/react-18/app/tsconfig.json
View file

@ -9,7 +9,7 @@
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/integration/relay-graphql-swc-multi-project/project-a/tsconfig.json
View file

@ -12,7 +12,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/relay-graphql-swc-multi-project/project-b/tsconfig.json
View file

@ -12,7 +12,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/relay-graphql-swc-single-project/tsconfig.json
View file

@ -12,7 +12,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

4
test/integration/tsconfig-verifier/test/index.test.js
View file

@ -598,7 +598,7 @@ describe('tsconfig.json verifier', () => {
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",
@ -659,7 +659,7 @@ describe('tsconfig.json verifier', () => {
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/integration/typescript-app-type-declarations/tsconfig.json
View file

@ -12,7 +12,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/typescript-baseurl/tsconfig.json
View file

@ -12,7 +12,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/typescript-custom-tsconfig/web.tsconfig.json
View file

@ -10,7 +10,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve"

2
test/integration/typescript-external-dir/project/tsconfig.json
View file

@ -12,7 +12,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/typescript-external-dir/shared/tsconfig.json
View file

@ -11,7 +11,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/typescript-filtered-files/tsconfig.json
View file

@ -11,7 +11,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/typescript-hmr/tsconfig.json
View file

@ -11,7 +11,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/typescript-ignore-errors/tsconfig.json
View file

@ -11,7 +11,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/typescript-only-remove-type-imports/tsconfig.json
View file

@ -11,7 +11,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/typescript-paths/tsconfig.json
View file

@ -24,7 +24,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/integration/typescript-workspaces-paths/tsconfig.json
View file

@ -24,7 +24,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
}

2
test/integration/typescript/tsconfig.json
View file

@ -11,7 +11,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true
},

2
test/production/deployment-id-handling/app/tsconfig.json
View file

@ -9,7 +9,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/production/jest/relay/app/tsconfig.json
View file

@ -10,7 +10,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "nodenext",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/production/jest/remove-react-properties/app/tsconfig.json
View file

@ -10,7 +10,7 @@
"incremental": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",

2
test/production/middleware-typescript/app/tsconfig.json
View file

@ -11,7 +11,7 @@
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"incremental": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"plugins": [