feat(next-swc): force teardown heap profiler if exists (#47769)

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation or adding/fixing Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md



## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

### What?

This is followup for https://github.com/vercel/next.js/pull/47729, for
some cases (mostly test) it forces child process so normal teardown to
flush may not being called. PR enables force flushing for those process
event. Same as original changes, for the normal next-swc this won't
affect anything.
This commit is contained in:
OJ Kwon 2023-04-17 23:15:36 -07:00 committed by GitHub
parent a9e4b795d7
commit a95611fa76
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -219,7 +219,7 @@ const nextDev: CliCommand = async (argv) => {
const { validateTurboNextConfig } =
require('../lib/turbopack-warning') as typeof import('../lib/turbopack-warning')
const { loadBindings, __isCustomTurbopackBinary } =
const { loadBindings, __isCustomTurbopackBinary, teardownHeapProfiler } =
require('../build/swc') as typeof import('../build/swc')
const { eventCliSession } =
require('../telemetry/events/version') as typeof import('../telemetry/events/version')
@ -286,6 +286,13 @@ const nextDev: CliCommand = async (argv) => {
if (!isCustomTurbopack) {
await telemetry.flush()
}
// There are some cases like test fixtures teardown that normal flush won't hit.
// Force flush those on those case, but don't wait for it.
;['SIGTERM', 'SIGINT', 'beforeExit', 'exit'].forEach((event) =>
process.on(event, () => teardownHeapProfiler())
)
return server
} else {
let cleanupFns: (() => Promise<void> | void)[] = []