archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix assignment of props in WithApollo.getInitialProps (#11236)

Browse source 
The props are being assigned incorrectly based on the `inAppContext`, they should be wrapped in `pageProps` when `inAppContext` is true, not the other way around. This will cause a new apollo client to be created during `getDataFromTree` instead of using the one that has already been created on the server.
This commit is contained in:
Ben Goerdt 2020-03-24 04:11:24 -05:00 committed by GitHub
parent 16a97c87e7
commit db57ad3b30
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
examples/with-apollo/lib/apollo.js
View file

@ -137,9 +137,9 @@ export const withApollo = ({ ssr = false } = {}) => PageComponent => {
// we need to modify their props a little.
let props
if (inAppContext) {
props = { ...pageProps, apolloClient }
} else {
props = { pageProps: { ...pageProps, apolloClient } }
} else {
props = { ...pageProps, apolloClient }
}
// Take the Next.js AppTree, determine which queries are needed to render,