Move client-navigation test to test/development (#55888)

Moves the client-navigation test suite to be isolated as part of
test/development.
Tried to make the minimal amount of changes neccesary to ensure the
tests pass first before using the newer `NextInstance` methods.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

test/development/pages-dir/client-navigation/rendering.ts

@@ -1,14 +1,14 @@
 /* eslint-env jest */
 
 import cheerio from 'cheerio'
+import { type NextInstance } from 'e2e-utils'
 import { getRedboxHeader, hasRedbox } from 'next-test-utils'
 import webdriver from 'next-webdriver'
 import { BUILD_MANIFEST, REACT_LOADABLE_MANIFEST } from 'next/constants'
-import { join } from 'path'
 import url from 'url'
 
-export default function (render, fetch, ctx) {
-  async function get$(path, query) {
+export default function (next: NextInstance, render, fetch, ctx) {
+  async function get$(path: any, query?: any) {
     const html = await render(path, query)
     return cheerio.load(html)
   }
@@ -88,10 +88,8 @@ export default function (render, fetch, ctx) {
       expect(html).toContain(
         '<meta name="viewport" content="width=device-width,initial-scale=1"/>'
       )
-      expect(html.match(/<meta name="viewport" /g).length).toBe(
-        1,
-        'Should contain only one viewport'
-      )
+      // Should contain only one viewport
+      expect(html.match(/<meta name="viewport" /g).length).toBe(1)
       expect(html).not.toContain(
         '<meta name="viewport" content="width=device-width"/>'
       )
@@ -340,11 +338,10 @@ export default function (render, fetch, ctx) {
       // build dynamic page
       await fetch('/dynamic/ssr')
 
-      const buildManifest = require(join('../.next', BUILD_MANIFEST))
-      const reactLoadableManifest = require(join(
-        '../.next',
-        REACT_LOADABLE_MANIFEST
-      ))
+      const buildManifest = await next.readJSON(`.next/${BUILD_MANIFEST}`)
+      const reactLoadableManifest = await next.readJSON(
+        `.next/${REACT_LOADABLE_MANIFEST}`
+      )
       const resources = []
 
       const manifestKey = Object.keys(reactLoadableManifest).find((item) => {

tsconfig.json

@@ -24,6 +24,8 @@
     "test/**/*.test.ts",
     "test/**/*.test.tsx",
     "test/**/test/*",
-    "packages/next/types/webpack.d.ts"
+    "packages/next/types/webpack.d.ts",
+    "test/e2e/pages-dir/client-navigation/index.test.js",
+    "test/e2e/pages-dir/client-navigation/rendering.js"
   ]
 }