archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(turbopack): throws api issues (#64032)

Browse source 
### What

Correctly raises error for the /api, unlike other places we were
suppressing it.

Closes PACK-2900
This commit is contained in:
OJ Kwon 2024-04-03 13:50:30 -07:00 committed by GitHub
parent dbd66e478f
commit fd73584c7f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/next/src/server/dev/turbopack-utils.ts
View file

@ -195,6 +195,9 @@ export function processIssues(
if (issue.severity !== 'warning') {
relevantIssues.add(formatted)
if (isWellKnownError(issue)) {
Log.error(formatted)
}
}
}
@ -406,7 +409,7 @@ export async function handleRouteType({
pageEntrypoints: entrypoints.page,
})
processIssues(currentEntryIssues, key, writtenEndpoint)
processIssues(currentEntryIssues, key, writtenEndpoint, true)
break
}

10
test/integration/edge-runtime-module-errors/test/utils.js
View file

@ -73,10 +73,12 @@ export function expectModuleNotFoundProdError(
) {
const moduleNotSupportedMessage = getUnsupportedModule(moduleName)
expect(stripAnsi(output)).not.toContain(moduleNotSupportedMessage)
const moduleNotFoundMessage = process.env.TURBOPACK
? `Error: Cannot find module '${moduleName}'`
: getModuleNotFound(moduleName)
expect(stripAnsi(output)).toContain(moduleNotFoundMessage)
const moduleNotFoundMessages = [
expect.stringContaining(`Error: Cannot find module '${moduleName}'`),
expect.stringContaining(getModuleNotFound(moduleName)),
]
expect(moduleNotFoundMessages).toContainEqual(stripAnsi(output))
}
export function expectModuleNotFoundDevError(

5
test/turbopack-dev-tests-manifest.json
View file

@ -9651,12 +9651,11 @@
"Edge runtime code with imports Edge API statically importing node.js module throws unsupported module error in dev at runtime and highlights the faulty line",
"Edge runtime code with imports Middleware dynamically importing 3rd party module throws not-found module error in dev at runtime and highlights the faulty line",
"Edge runtime code with imports Middleware importing unused node.js module does not throw in dev at runtime",
"Edge runtime code with imports Middleware statically importing node.js module throws unsupported module error in dev at runtime and highlights the faulty line"
],
"failed": [
"Edge runtime code with imports Middleware statically importing node.js module throws unsupported module error in dev at runtime and highlights the faulty line",
"Edge runtime code with imports Edge API importing unused 3rd party module throws not-found module error in dev at runtime and highlights the faulty line",
"Edge runtime code with imports Middleware importing unused 3rd party module throws not-found module error in dev at runtime and highlights the faulty line"
],
"failed": [],
"pending": [
"Edge runtime code with imports Edge API dynamically importing 3rd party module production mode does not build and reports module not found error",
"Edge runtime code with imports Edge API importing unused 3rd party module production mode does not build and reports module not found error",