Darsh Patel
d68afed6ab
Fix: validatePassword function logic [Fixes 14174 ] ( #14183 )
...
Updated the `validatePassword` function as mentioned in https://github.com/vercel/next.js/issues/14174#issue-638626374
also fixed the password validation logic in `signIn` function
Fixes: https://github.com/vercel/next.js/issues/14174
2020-06-15 12:39:12 +00:00
stefanprobst
66778c7ab0
chore: add retry method to loadable types ( #14152 )
2020-06-15 14:21:03 +02:00
Sebastian Benz
eef40c5948
update AMP Optimizer to v2.5.3 ( #14173 )
2020-06-15 14:17:59 +02:00
Todor Totev
e4f0848c81
[Example] remove getInitialProps from aws-amplify ( #13896 )
...
* Remove getInitialProps
* update package
* Applied requested changes.
* thats essential so im bringing it back
* make sure getstaticprops doesnt throw
* proper versioning
* requested changes
* Updated readme and package.json
* Updated pages
Co-authored-by: Luis Alvarez D <luis@vercel.com>
2020-06-14 18:50:54 -05:00
Tim Neutkens
27f653bb3d
Clean up AMP bundle removal ( #14130 )
...
Drops the entrypoint instead of removing the underlying file.
2020-06-14 12:49:46 +00:00
Robert Valmassoi
05f61b22ad
Fix broken link ( #14158 )
2020-06-13 23:48:14 +00:00
JJ Kasper
10fda8a9b9
Update stats action for running locally ( #14143 )
...
Noticed a few things that could be updated to make running the stats locally better e.g. if the folder name didn't match the name of the repo in the `stats-config.js` file it would fail to run and the `yarn` cache could break diffing from a cached package being used instead
2020-06-13 10:31:12 +00:00
Alexej Dyschelmann
6163f30ad8
[with-recoil example] use functional form of state updaters for simplicity ( #14014 )
...
This is probably a pretty subjective change, but one might argue it less complex and may have minimally less overhead.
2020-06-13 09:04:34 +00:00
Luis Alvarez D
0b4c32c2aa
[Docs] Update custom server docs ( #14147 )
...
[ch3235]
2020-06-13 08:47:13 +00:00
JJ Kasper
0a02efbfcc
Add test for title and routeChangeComplete ( #14132 )
...
This adds a test case for the `document.title` not being updated by the time `routeChangeComplete` is fired. This should have been made consistent with https://github.com/vercel/next.js/pull/13287 so should be able to be closed now
Closes: https://github.com/vercel/next.js/issues/6025
2020-06-12 16:26:10 +00:00
Tim Neutkens
60d1ed2ee5
v9.4.5-canary.12
2020-06-12 11:11:17 +02:00
Li Ming
c16e0e2be1
fix(example): needs TypeScript support ( #14115 )
...
Example: with-ant-design-pro-layout-less needs TypeScript support.
2020-06-12 06:35:00 +00:00
Shu Uesugi
e781c44682
Use envLink for deploy buttons ( #14110 )
...
This is a quick fix for https://github.com/vercel/next.js/pull/14053 - the deploy buttons on CMS examples should be using `envLink` for the links.
## Before
<img width="565" alt="Screen Shot 2020-06-11 at 7 23 58 PM" src="https://user-images.githubusercontent.com/992008/84458119-21d52c80-ac19-11ea-9659-df6830fc7584.png ">
## After
<img width="570" alt="Screen Shot 2020-06-11 at 7 23 33 PM" src="https://user-images.githubusercontent.com/992008/84458089-1255e380-ac19-11ea-81ff-bc2b58af3ea4.png ">
2020-06-12 02:51:19 +00:00
Luis Alvarez D
3f5737eccd
Use the expected import ( #14111 )
2020-06-11 21:29:26 -05:00
Luis Alvarez D
85543a45f1
Update deploy button in the userbase example ( #14107 )
...
Fixes readme updates added in https://github.com/vercel/next.js/pull/14100
2020-06-12 02:23:52 +00:00
Mileta Dulović
f343410773
Fixed Avatar.js component where Strapi CMS would fail when fetching an image ( #14084 )
...
I tried creating CMS with ```Strapi``` by following [this README.MD](https://github.com/M1ck0/next.js/tree/canary/examples/cms-strapi ). After configuring everything I noticed that app isn't working.
This is error that occured on ```yarn dev```
After logging data that is sent to ```<Avatar/>``` component I noticed that ```picture``` is actually an ```Array```.
After modifying code bellow everything works as it should and CMS works properly.
2020-06-12 01:48:27 +00:00
Matthew Sweeney
7e16f7f43b
Update with-userbase Example ( #14100 )
...
This PR updates the `with-userbase` example with the following changes:
- Removes the `vercel.json` file, this is no longer needed with [recent changes](https://vercel.com/docs/v2/build-step#environment-variables ).
- Changes the URL of the Deploy Button to use `?env`, `?envLink`, and `?envDescription` query strings, these prompt for environment variables upon import.
- Updates the instructions to reflect the changes made to the import and deployment process.
2020-06-12 01:20:52 +00:00
Jason Miller
d23c22c544
[Examples] Fix using-preact dev mode issues ( #14098 )
...
Should fix https://github.com/vercel/next.js/pull/13976#issuecomment-641677695
/cc @monsonjeremy - let me know if this work for you.
2020-06-12 00:59:03 +00:00
Luis Alvarez D
2cd691050a
Add new import flow to CMS examples ( #14053 )
...
[ch2502]
- Added new import flow to every CMS example, using the deploy button, and removed `vercel.json`
- Replaced `dotenv` with the new env support in outdated examples
2020-06-11 23:44:23 +00:00
Tim Neutkens
89fffa694d
Remove Head.rewind as it's no longer needed ( #14091 )
...
Fixes #9326
2020-06-11 22:09:06 +00:00
Sebastian Benz
ec90cc83ff
Update AMP Optimizer to v2.5.2 ( #14095 )
...
This addresses the problem of the optimizer postinstall hook causing
delayed installs if run behind a proxy. See https://github.com/ampproject/amp-toolbox/issues/832
Fixes #14070
2020-06-11 19:28:56 +00:00
Joe Haddad
8ae10601b1
Simplify test checks ( #14094 )
...
Fixes #14093
2020-06-11 19:02:53 +00:00
HYUNSANG HAN
7e1d174e8e
Fix route in custom-server-koa example ( #14080 )
...
Links of the example about `custom-server-koa` were wrong, so I fixed them.
2020-06-11 18:44:29 +00:00
Joe Haddad
ec7c3252c3
tests: fail when cannot replace content ( #14087 )
...
Fixes #14085
2020-06-11 18:29:38 +00:00
Todor Totev
c337db8d7e
[Example] remove getInitialProps from aws-amplify-typescript ( #13898 )
...
Related to [11014](https://github.com/vercel/next.js/issues/11014 )
2020-06-11 18:02:58 +00:00
Todor Totev
6c8b7cde7d
[Examples] remove getInitialProps from with-firebase-authentication ( #13895 )
...
Related to [11014](https://github.com/vercel/next.js/issues/11014 )
2020-06-11 17:38:29 +00:00
JJ Kasper
1c057e7792
Add test case for loading 404 on invalid bundle ( #14082 )
...
This adds a test case to ensure hard navigating when a client bundle fails to load is occurring correctly
x-ref: https://github.com/vercel/next.js/issues/13516
2020-06-11 16:59:25 +00:00
Joe Haddad
c2c0e6d677
v9.4.5-canary.11
2020-06-11 10:41:38 -04:00
Joe Haddad
c8b51b5c3a
Revert "Add scroll restoration handling after render is done" ( #14075 )
2020-06-11 10:40:08 -04:00
JJ Kasper
3d6d033a5b
Normalize asPath between SSR and CSR with basePath ( #14040 )
...
To make `asPath` consistent with `basePath` handling this makes sure it is always stripped including on the client under the `asPath` value and from `req.url` in the `serverless-loader`. Additional tests have been added for this behavior to ensure we don't regress on this
Closes: https://github.com/vercel/next.js/issues/14037
Closes: https://github.com/vercel/next.js/issues/14039
2020-06-11 14:06:06 +00:00
Tim Neutkens
90638c7001
v9.4.5-canary.10
2020-06-11 10:57:59 +02:00
Tim Neutkens
76fddcd7ef
Use chunkhash instead of buildId for pages ( #13937 )
...
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2020-06-11 10:57:24 +02:00
Cristian
1ffc7af36a
[Examples] Update with-chakra-ui ( #14035 )
...
* [Examples] Update with-chakra-ui
* Pass theme prop to ThemeProvider
Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com>
2020-06-11 01:34:41 -05:00
Shu Uesugi
30f30af320
Storyblok CMS Example ( #13993 )
...
[ch2842]
- Demo: https://next-blog-storyblok.now.sh/
- Preview Mode: https://next-blog-storyblok.now.sh/api/preview?secret=5nnybHTKlbzkOa6r&slug=draft-post-test
2020-06-10 22:23:28 +00:00
Jason Merino
0defd53564
Small grammar fix. ( #14043 )
2020-06-10 21:42:17 +00:00
Mohamed SADAT
aacfa79ddf
feat(create-next-app): Use CSS and CSS modules in default application template ( #13983 )
...
Hello 👋
This PR is to replace styled-jsx by Global CSS and CSS modules in the default Next.js template according to the issue [#13965 ](https://github.com/vercel/next.js/issues/13965 ) opened by @Timer
2020-06-10 21:25:27 +00:00
Joe Haddad
91664d1d02
Eliminate public folder enumeration ( #14042 )
...
This builds off of @timneutkens's PR instead of updating it because it's his `canary` branch.
Updated to still `stat`, as it's the only way to test the difference between a file and directory.
---
Closes #13506
Fixes #12235
2020-06-10 20:35:34 +00:00
Joe Haddad
80036fd9dd
Fix Fast Refresh with Page Config ( #14041 )
...
Fixes #13978
2020-06-10 19:56:05 +00:00
JJ Kasper
d5493ff24d
Fix dynamic route match and basePath ( #14036 )
...
This correctly strips the `basePath` before generating the `route-matcher` for dynamic routes and adds regression tests to ensure these work correctly with the `basePath` feature
Closes: https://github.com/vercel/next.js/issues/13966
2020-06-10 18:26:57 +00:00
Shu Uesugi
dea4c2cbf4
ButterCMS Example ( #13908 )
...
[ch2580]
**Demo:** https://next-blog-buttercms.now.sh/
**Preview Mode:** https://next-blog-buttercms.now.sh/api/preview?secret=CdEAKMRT4tAwzqiD&slug=draft-post-test
2020-06-10 17:13:10 +00:00
JJ Kasper
ad2c1a8a16
Make sure to watch all next-server files ( #14023 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2020-06-10 11:27:37 -05:00
stefanprobst
caddd355f7
fix: add plugin to recommended eslint-plugin-next config ( #13926 )
...
allow extending the recommended eslint-plugin-next config, without having to specify the plugin name in the plugins array. eslint does not do this automatically, see the note [here](https://eslint.org/docs/developer-guide/working-with-plugins#configs-in-plugins )
2020-06-10 15:01:57 +00:00
Ben Spinks
a9891095ec
Invert colors of compiling indicator ( #13995 )
...
Hi,
This PR inverts the colors for the compiling indicator, closes #13952 .
The second commit makes the styling consistent with the prerender indicator (height and border)
From:
To:
2020-06-10 13:15:35 +00:00
Darsh Patel
f24eb4fd4a
Added .next folder to gitignore for examples/blog-starter ( #14003 )
...
```.next``` folder wasn't in the gitignore file causing .next folder to be tracked by git
2020-06-10 10:09:42 +00:00
Dylan Jhaveri
d5f5b5f29b
with-mux-video update ( #13992 )
...
* function rename
* update package.json dependencies to use `^` for semver. I noticed the package-lock.json is not committed in these examples, which seems to be intentional. Is it advisable to use semver for dependencies? This could actually break if someone clones, installs and a newer version of something has a breakage, but in general it might be nice to have folks installing the latest patch releases for deps.
* use Upchunk 2.0.0. with 1000x [better progress reporting on uploads](https://github.com/muxinc/upchunk/releases/tag/v2.0.0 )
**Notice the progress %**
Upchunk pre 2.0:
Upchunk 2.0:
2020-06-10 07:05:14 +00:00
Joe Haddad
54ac432390
v9.4.5-canary.9
2020-06-10 00:51:04 -04:00
Joe Haddad
d874329d11
Prioritize webpack bootstrapping first ( #13987 )
...
Webpack will randomly execute script order if its runtime is not prioritized before chunks execute.
This seems to be somehow triggered in #13870 because of slightly different script ordering.
This had actually broke CSS, which is why our tests are failing 50% of the time:
Without this PR:
However, it's still problematic to use `async` in development since we rely on script execution order. So, this PR disables `async` in development.
We're exploring `defer` in the future anyway (over `async`), which will be ordered, so I don't mind diverging between dev and prod in this way.
---
Fixes #13911
2020-06-10 04:41:59 +00:00
Luis Alvarez D
43271821f2
[Examples] Move with-typescript-graphql to SSG ( #13854 )
...
Related to https://github.com/vercel/next.js/issues/11014
2020-06-10 04:14:53 +00:00
Luis Alvarez D
9dc902835c
[Examples] Move api-routes-apollo-server-and-client-auth to SSG ( #13849 )
...
Related to https://github.com/vercel/next.js/issues/11014
The authentication method has been replaced with an improved version of the passport example.
2020-06-10 03:46:11 +00:00
James Mosier
aed8b37529
Fix variable shadowing in blog-starter example ( #13988 )
...
Sorry for the super trivial PR. I noticed this while working with the example and figured it might be worth fixing.
2020-06-10 03:30:22 +00:00
