Commit graph

5 commits

Author SHA1 Message Date
edward
c7f43e583d
Fix adding-exmaples.md doc (#46051)
<!--
Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
-->

There are two edit point

First, The url in the doc directed wrong URL.

Second, The instruction in the doc says "Make sure linting passes (you
can run pnpm lint-fix)"
But PR request user to check "Make sure the linting passes by running
`pnpm build && pnpm lint`"
I thought that it need unity and if i run pnpm lint-fix, lots of errors
appear.
So i edit instruction from `pnpm lint-fix` to `pnpm build & pnpm lit`


## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm build && pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

---------

Co-authored-by: JJ Kasper <jj@jjsweb.site>
2023-02-17 22:35:12 -08:00
Will Binns-Smith
d9eb29a9fa
Recommend next-with-deps for running examples (#44667)
Depends on https://github.com/vercel/next.js/pull/44666

This will install `package.json` dependencies in examples before running them.
2023-01-06 21:51:45 +00:00
Alpha
c19c10069f
grammar fix in adding-examples README. (#42152)
Closes https://github.com/vercel/next.js/issues/42151

This PR fixes grammar in adding-examples README.
2022-10-29 22:02:08 -07:00
Balázs Orbán
4cb96fb047
chore(contributing): remove note about eslint-config-next
Since we don't prefer having ESLint as part of the examples anyway.
2022-09-30 00:59:13 +02:00
Balázs Orbán
3ff21ed178
refactor: split up CONTRIBUTING.md (#40515)
Continues #39778

Closes #40499

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The examples guidelines are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
2022-09-16 14:54:58 -07:00