2 commits
Author | SHA1 | Message | Date | |
---|---|---|---|---|
Jimmy Lai
|
a71227a40f
|
parallel routes: fix layout not re-rendering (#48066)
### What? This PR makes the parent layout of parallel routes re-render when the parallel route segments are different or when either of them has a refetch marker. Example: ``` . └── app/ ├── page.ts ├── layout.ts ├── foo/ │ └── page.ts └── @modal/ ├── default.js └── foo/ └── page.ts ``` Here if you navigated to `/foo` from `/`, `@modal/foo/page` would never get re-rendered because the tree would only re-render from `foo/page.ts`. This PR adds a check that checks the router state on navigation to see if the parallel route segments diverge on navigation. Here we would be checking that `@modal/default` is different from `@modal/page` so we would re-render. Also added some logic to make sure that refetch routes are processed first when handling parallel routes. ### Why? See example Closes NEXT-966 Fixes # <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> |
||
Tim Neutkens
|
db2e9b2870
|
Add tests for parallel routes / interception and handle router state patch merging client-side (#45615)
Added tests: - Add tests for interception+parallel and interception - Add test for parallel route tab bar - Add test for back/forward navigation on parallel routes Core changes: - Updated handling of parallel route matcher `@` to produce the correct router tree - Fixed global-error resolving, it was resolving from the `page.js` on each level. It should only live next to the root layout only, so now it resolves when it finds the root layout. - `applyRouterStatePatchToTree` now merges the levels of the original tree and the patch. This ensures parallel routes that are not affected by the response from the server are not removed from the tree. - Ensure cache nodes are not removed when they're not affected by tree patch, this ensures parallel route cache nodes will not be removed when navigating. Other changes: - Added launch app-dir build to launch.json for vscode debugger <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: --> ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> |