archive/rsnext
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
15144 commits 5 branches 0 tags 1.9 GiB
Commit graph

11 commits

Author SHA1 Message Date
JJ Kasper
2ff63b1279
Disable un-necessary lint rule by default (#45813) 
This lint rule is now outdated as our [default supported browserslist is
for the most part
unaffected](https://nextjs.org/docs/basic-features/supported-browsers-features)
now handles `target='_blank'` with `rel='noopener'` automatically
https://caniuse.com/mdn-html_elements_a_implicit_noopener

Users configuring older browsers in their list can still manually enable
this rule if desired.

x-ref: https://github.com/vercel/next.js/pull/37940
x-ref: [slack
thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1676143674720769?thread_ts=1676139395.828479&cid=C03KAR5DCKC)
 2023-02-11 12:35:00 -08:00
Mark Ladyshau
40639b28be
Lint files with mjs, mts, cjs and cts extension by default (#40879) 
## Feature

Fixes #36819. Closes https://github.com/vercel/next.js/pull/37389.

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`
 2022-10-03 19:54:27 +00:00
Balázs Orbán
5793301c60
fix(lint): disable react/no-unknown-property (#40331) 
~(PR https://github.com/jsx-eslint/eslint-plugin-react/pull/3377)
introduced a change in `eslint-plugin-react@7.31.2` that will now show
an error when unknown properties appear on elements. We can opt out of
this by overriding the default.~

As discussed internally, we are turning `react/no-unknown-property` off,
as it might be confusing even if different props are being used, (eg.:
`css` for `emotion`).

It's easy to fix
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-unknown-property.md#rule-options,
but it might not be clear at first glance that Next.js is using
`eslint-plugin-react` internally.

If the user wants to enforce this rule, they can still add it to their
own `rules` config.

Fixes #40321, ref: https://github.com/vercel/next.js/discussions/40269,
https://github.com/vercel/next.js/issues/38333
 2022-09-08 08:21:36 -07:00
JJ Kasper
12e1bb7d32
Ensure eslint plugins dont conflict (#35667) 2022-03-28 12:31:30 -05:00
Houssein Djirdeh
df83ccb7cd
[ESLint] Documentation updates + bug fixes (#26331) 
Documentation:

- Expands the "Migrating Existing Config" section of ESLint doc to explain in more detail
- Minor changes to the "Ignoring ESLint" doc

Bug fixes:

- Adds `browser` and `node` environments to `eslint-config-next`. Closes #26319
- Fixes `no-document-import` rule. Closes #26159
- Fixes `no-page-custom-font` rule. Closes #26160 #26894
 2021-08-05 00:58:06 +00:00
Jefferson Bledsoe
26105e285d
ESLint Config: Adds some more basic a11y rules (#25770) 2021-07-27 17:07:56 +02:00
Houssein Djirdeh
6645248d41
[ESLint] Remove error when file patterns are unmatched + ESLint setup changes (#27119) 
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
 2021-07-16 20:19:08 +02:00
Houssein Djirdeh
ce4f1e889e
[ESLint] Adds --quiet flag, TypeScript resolver and bug fixes (#26280) 2021-06-18 15:17:53 +02:00
Houssein Djirdeh
bbc28ccae0
next lint + ESLint in Create Next App (#25064) 
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
Co-authored-by: Tim Neutkens <timneutkens@me.com>
 2021-06-03 14:01:24 +02:00
Houssein Djirdeh
89dd5c16b5
ESLint Config: Adds alt text rule for Image (#25462) 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
 2021-06-01 09:10:52 +02:00
Houssein Djirdeh
e783b0a2e8
Adds ESLint with default rule-set (#23702) 
This PR re-includes ESLint with some notable changes, namely a guided setup similar to how TypeScript is instantiated in a Next.js application.

To add ESLint to a project, developers will have to create an `.eslintrc` file in the root of their project or add an empty `eslintConfig` object to their `package.json` file.

```js
touch .eslintrc
```

Then running `next build` will show instructions to install the required packages needed:

<img width="862" alt="Screen Shot 2021-04-19 at 7 38 27 PM" src="https://user-images.githubusercontent.com/12476932/115316182-dfd51b00-a146-11eb-830c-90bad20ed151.png">

Once installed and `next build` is run again, `.eslintrc` will be automatically configured to include the default config:

```json
{
  "extends": "next"
}
```

In addition to this change:

- The feature is now under the experimental flag and requires opt-in. After testing and feedback, it will be switched to the top-level namespace and turned on by default.
- A new ESLint shareable configuration package is included that can be extended in any application with `{ extends: 'next' }`
  - This default config extends recommended rule sets from [`eslint-plugin-react`](https://www.npmjs.com/package/eslint-plugin-react), [`eslint-plugin-react-hooks`](https://www.npmjs.com/package/eslint-plugin-react-hooks), and [`eslint-plugin-next`](https://www.npmjs.com/package/@next/eslint-plugin-next)
- All rules in [`eslint-plugin-next`](https://www.npmjs.com/package/@next/eslint-plugin-next) have been modified to include actionable links that show more information to help resolve each issue
 2021-04-30 11:09:07 +00:00