archive/rsnext

Fork 0

Commit graph

Author	SHA1	Message	Date
Steven	064e0c25d7	chore: fix flaky middleware matcher test (#49555 ) ``` ✕ should match query path (2857 ms) ● Middleware custom matchers basePath › should match query path expect(received).toBe(expected) // Object.is equality Expected: "random" Received: "" ``` https://github.com/vercel/next.js/actions/runs/4929337370/jobs/8809028722?pr=49529#step:6:201	2023-05-09 22:37:03 +00:00
Darsh Patel	81f5ed7aa2	Fix: Router.query contains _next when using middleware with dynamic routes (#48753 ) Fixes: #43598 This was a tricky one to find! Not sure why more people aren't complaining about this issue, was super annoying in my use case since links had the wrong URL. ## What? This issue only occurred when basepath was defined and middleware and dynamic pages are being used. Example from the reproduction repo mentioned in the issue tagged: <img width="686" alt="Screenshot 2023-04-23 at 9 32 55 PM" src="https://user-images.githubusercontent.com/11258286/233850968-e14f6b49-858b-410e-b8f9-93c90447090a.png"> ## Why? `nextConfig` wasn't passed to `getNextPathnameInfo` function, hence the basePath wasn't removed from a intermediate variable and that trickled down to cause this issue. Added test case based on the issue reproduction repo --------- Co-authored-by: Jimmy Lai <laijimmy0@gmail.com>	2023-05-09 12:49:27 +02:00

Author

SHA1

Message

Date

Steven

064e0c25d7

chore: fix flaky middleware matcher test (#49555 )

```
    ✕ should match query path (2857 ms)

  ● Middleware custom matchers basePath › should match query path

    expect(received).toBe(expected) // Object.is equality

    Expected: "random"
    Received: ""
```

https://github.com/vercel/next.js/actions/runs/4929337370/jobs/8809028722?pr=49529#step:6:201

2023-05-09 22:37:03 +00:00

Darsh Patel

81f5ed7aa2

Fix: Router.query contains _next when using middleware with dynamic routes (#48753 )

Fixes: #43598

This was a tricky one to find! Not sure why more people aren't
complaining about this issue, was super annoying in my use case since
links had the wrong URL.

## What?
This issue only occurred when basepath was defined and middleware and
dynamic pages are being used.
Example from the reproduction repo mentioned in the issue tagged:
<img width="686" alt="Screenshot 2023-04-23 at 9 32 55 PM"
src="https://user-images.githubusercontent.com/11258286/233850968-e14f6b49-858b-410e-b8f9-93c90447090a.png">


## Why?
`nextConfig` wasn't passed to `getNextPathnameInfo` function, hence the
basePath wasn't removed from a intermediate variable and that trickled
down to cause this issue.

Added test case based on the issue reproduction repo

---------

Co-authored-by: Jimmy Lai <laijimmy0@gmail.com>

2023-05-09 12:49:27 +02:00

2 commits