archive/rsnext

Fork 0

Commit graph

Author	SHA1	Message	Date
JJ Kasper	a92a5caec2	Update test set-up to leverage playwright when able to (#28634 ) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>	2021-09-13 14:36:25 +02:00
Jamie	7c408e7a0f	Fix ISR page re-rendering after revalidate expiry (Fork of #24807 ) (#27335 ) Fixes: #24806 Fixes: #26689 Fixes: #27325 Closes: #24807 @tommarshall has done us a huge favor with his PR https://github.com/vercel/next.js/pull/24807 which outlines exactly the issue and a pragmatic solution. I'm not trying to "steal their work", however, the PR seems to have been stuck for some months. I think there's huge value in this for myself and others as essentially ISR is broken for people running Next.js at scale 😱 This PR has cherry-picked @tommarshall's fine fix and added some integrations tests around page revalidation and the edge case when the cache size is exhausted. ✏️ Edits are enabled, so feel free great Vercel staff and other maintainers to improve my bad tests or surrounding code 🙇 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added	2021-07-20 17:01:42 +00:00

Author

SHA1

Message

Date

JJ Kasper

a92a5caec2

Update test set-up to leverage playwright when able to (#28634 )

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

2021-09-13 14:36:25 +02:00

Jamie

7c408e7a0f

Fix ISR page re-rendering after revalidate expiry (Fork of #24807 ) (#27335 )

Fixes: #24806 
Fixes: #26689
Fixes: #27325
Closes: #24807

@tommarshall has done us a huge favor with his PR https://github.com/vercel/next.js/pull/24807 which outlines exactly the issue and a pragmatic solution.

I'm not trying to "steal their work", however, the PR seems to have been stuck for some months. I think there's huge value in this for myself and others as essentially **ISR is broken** for people running Next.js at scale 😱 

This PR has cherry-picked @tommarshall's fine fix and added some integrations tests around page revalidation and the edge case when the cache size is exhausted.

✏️ Edits are enabled, so feel free great Vercel staff and other maintainers to improve my bad tests or surrounding code 🙇 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

2021-07-20 17:01:42 +00:00

2 commits