Commit graph

812 commits

Author SHA1 Message Date
Chung Wei Leong
78adcd4cdd
fix: github reproduction link validation (#61026)
### What?
In this PR #60988, I think (please correct me if I'm wrong) it was meant
to block GitHub reproduction links like `https://github.com/username` &
`https://github.com`. However, the last regex `github.com` will block
all the github.com links

### Why?
So that people can use a GithHb repo as reproduction link

### How?
Fix the regex, from `github.com` to `github.com$`

Co-authored-by: Steven <steven@ceriously.com>
2024-01-23 21:48:15 +00:00
Sam Ko
ed4dea49ea
chore: upgrade pnpm to 8.14.2 (#60995)
## Changes

- Update all instances of pnpm to the latest v8.14.2

Closes NEXT-2188
2024-01-22 14:12:09 -08:00
Balázs Orbán
b50126cc42
chore: stricter reproduction links (#60988)
### What?

Add some regex patterns to not allow certain github links as
reproduction URLs

### Why?

See https://github.com/vercel/next.js/issues/58248

### How?

See https://github.com/balazsorban44/nissuer#validate-reproduction-urls


Closes NEXT-2185
2024-01-22 18:57:24 +00:00
Balázs Orbán
6217e3fb10
chore: fix core team members (#60900)
### What?

Removing an outdated entry, and fixing the casing of another so Workflow
runs are auto-approved.

### Why?

https://github.com/vercel/next.js/pull/60574 fails the CI Workflow Run,
because of a mismatch in GitHub actor and the actual username set in
`labeler.json`


[Ref](c26bc3f265/validate-job.js (L39-L42)),
[Slack
thread](https://vercel.slack.com/archives/C03S9JCH2Q5/p1705684536884389?thread_ts=1705436555.494229&cid=C03S9JCH2Q5)

Closes NEXT-2172
2024-01-19 10:19:32 -08:00
Balázs Orbán
dc109bf6c9
chore: indicate staleness more prominently in next info output (#60376)
### What?

Improve the `next info` output.

<details>
<summary>Before:
</summary>
<img
src="https://github.com/vercel/next.js/assets/18369201/735da72f-6746-42a0-838d-e10db78b2db3">
</details>

<details>
<summary>After:
</summary>
<img
src="https://github.com/vercel/next.js/assets/18369201/d72c0027-71d9-494c-bb98-dd0fed99c8d9">
</details>

### Why?

People have been ignoring the ask to check `next@canary` before opening
a new issue, which results in triaging overhead. This PR inlines the
warning into `next info` that would make it an extra effort to remove
the warning without reading the message, hopefully leading to not
ignoring the message anymore.

### How?

Reusing the same logic from the version staleness indicator from Error
Overlay.

[Slack
thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1704364764719949)
2024-01-19 18:36:19 +01:00
Sam Ko
3a8436b128
chore: update issue_popular workflow to 90 days (#60860)
## Changes

- Update issue_popular to 90 days for broader look at issues

Closes NEXT-2163
2024-01-19 05:52:27 +00:00
JJ Kasper
a90e5d6e4b
Fix last stable tag for release stats (#60850)
x-ref:
https://github.com/vercel/next.js/actions/runs/7576301894/job/20635069339

Closes NEXT-2159
2024-01-18 14:50:31 -08:00
Ethan Arrowood
8a3881fef0
Update labeler.json (#60843)
Add @Ethan-Arrowood to labeler list
2024-01-18 12:15:15 -08:00
Balázs Orbán
16d1c26985
chore: bump nissuer (#60706)
### What?

Make it more clear that a comment was minimized by a bot.

### Why?

To avoid confusion

### How?

See
1f8f7f977b

[Slack
thread](https://vercel.slack.com/archives/C04DUD7EB1B/p1705315618865229)

Closes NEXT-2111
2024-01-16 16:19:54 -08:00
Sam Ko
e620531480
chore: remove pr_approved workflow & update popular_issues workflow (#60584)
## Changes
- Remove `pr_approved.yml`
- Update popular issues workflow, move to a different Slack channel

Closes NEXT-2089
2024-01-12 21:41:44 +00:00
Sam Ko
cc2bd0de76
chore: update next-repo-info actions (#60559)
## Description
A few changes to
https://github.com/vercel/next.js/tree/canary/.github/actions/next-repo-info
and related workflows.

## Changes
- Update `generateBlocks()` function
- Fix Slack channel title typo
- Fix `issuesAndPullRequests({ ... })` API call


Closes NEXT-2077
2024-01-12 11:19:22 +00:00
Sam Ko
7b73f1137b
chore: add issue_popular workflow (#60543)
## Description
Add a new GitHub workflow that outputs the top 15 :github2: issues (most reactions) in
the last month.

Closes NEXT-2071
2024-01-11 18:27:47 -08:00
Sam Ko
2138facc12
chore: update pull_request_approved workflow (#60537)
## Description
Updating
https://github.com/vercel/next.js/blob/canary/.github/workflows/pull_request_approved.yml
and related.

## Changes
- Fix path so workflow runs
- Update cron schedule to be on a weekly basis on instead of daily
- Update Slack channel

Closes NEXT-2068

---------

Co-authored-by: JJ Kasper <jj@jjsweb.site>
2024-01-11 13:34:42 -08:00
Tobias Koppers
f45a15b621
move custom allocator flag and add rustls-tls comment (#60128)
### What?

enable the custom allocator flag to enable mialloc.
allow to configure custom allocator on napi level.

### Why?

It's faster and we had it enabled before.
It was disable before as `next-core` is used with no default features in
workspace

Native Build: https://github.com/vercel/next.js/actions/runs/7388725004


Closes PACK-2185

---------

Co-authored-by: OJ Kwon <1210596+kwonoj@users.noreply.github.com>
2024-01-11 09:07:56 +01:00
Ahmed Abdelbaset
3c065a1f73
misc: Skip cron workflows on forks (#60487)
Follow up to #60422
2024-01-10 19:17:50 +00:00
OJ Kwon
46370d816b
refactor(next/core): reorganize next.js custom transforms for next-swc/turbopack (#60400)
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change



-->

### What?

This PR refactors organization for the rust side packages to build
`next-swc`.

### Why?

We had some historical legacy around package structures, have ambiguous
name for `core` / `next-core`. One contains swc transform visitor for
the next.js, and the other one is new for turbopack's core next.js
features. In addition to that, there was a package dependency chain
prevents to use `core` in the turobpack / next-swc both, so each time
porting a transformer into turbopack it requires to extract new
dependency to be imported in the both place.

PR touches its organization - while PR is large to touch various files,
the crux is summarized at
2cedd06ea5
:

1. `core` becomes `next-custom-transforms`, also this becomes an
agnostic pkg can be imported in turbopack / wasm / next-swc
2. simplify dependency chain to import next-custom-transforms, organized
as below

```mermaid
flowchart TD
    C(next-custom-transforms) --> A(napi)
    C(next-custom-transforms) --> B(wasm)
    D(next-core) --> A(napi)
    E(next-build) --> A(napi)
    F(next-api) --> A(napi)
    C(next-custom-transforms) --> D
    D(next-core) --> F(next-api)
    D(next-core) --> E(next-build)
```

`impl CustomTransformer` for the each transform still lives in
`next-core`, so turbopack specific dependency is isolated under
`next-core/build/api`.


Closes PACK-2201
Closes PACK-2202

---------

Co-authored-by: hrmny <8845940+ForsakenHarmony@users.noreply.github.com>
2024-01-09 12:23:47 -08:00
Ahmed Abdelbaset
967784b203
ci: skip cron workflows on forks (#60422)
This PR skips running cron workflows outside of `vercel/next.js`

---------

Co-authored-by: Steven <steven@ceriously.com>
2024-01-09 17:41:12 +00:00
Sam Ko
2d9c01099c
chore: update turbo to the latest (#60294)
Update :turbo-new: to the latest (v.1.11.3).

Closes NEXT-2004
2024-01-08 11:17:04 -08:00
Sam Ko
43410c9926
chore: update pnpm to the latest (v8.14.0) (#60295)
Update <picture data-single-emoji=":pnpm:" title=":pnpm:"><img
class="emoji" width="20" height="auto"
src="https://emoji.slack-edge.com/T0CAQ00TU/pnpm/49b40aec15de9c17.png"
alt=":pnpm:" align="absmiddle"></picture> to the latest (v8.14.0).

Closes NEXT-2003
2024-01-05 22:12:04 -05:00
Sam Ko
5acf751663
chore: include required Next.js stages to issue template (#60142)
Include an additional requirement in the [Issue
Template](https://github.com/vercel/next.js/blob/canary/.github/ISSUE_TEMPLATE/1.bug_report.yml)
for adding information about which :nextjs: stage (e.g, `next dev`,
`next build`, & `next start`) is affected in an issue.
2024-01-02 15:03:19 -08:00
Sam Ko
be1b9738c8
chore: add myself to created-by: Next.js team (#60144)
Quick :pr: so the `created-by: Next.js
team` label automatically gets added to my :pr:s.
2024-01-02 14:52:22 -08:00
Jiachi Liu
65d59a2422
chore: add github bug report item type module resolution (#60121)
Add new bug report type of module resolution in GH yml config file

Closes NEXT-1946
2024-01-02 11:44:05 -08:00
lijianan
9ce18c4d5f
chore: update Copyright time from 2023 to 2024 (#60071)
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
2024-01-02 11:06:02 -08:00
Zack Tanner
bd5157c78c
fix integration test workflow (#59508)
This was incorrectly setting the upper bound on the `--group` argument
to our test runners (ie, `11/122`), which was causing a lot of tests to
be missed.

Closes NEXT-1851
2023-12-11 15:33:23 -08:00
OJ Kwon
618c7285a2
ci(test): upload playwright artifacts seperately (#59496)
###

Updating snapshot upload location per suggestion at
https://github.com/vercel/next.js/pull/59469#discussion_r1422943741

Closes PACK-2132

---------

Co-authored-by: Leah <8845940+ForsakenHarmony@users.noreply.github.com>
2023-12-11 19:07:08 +00:00
OJ Kwon
25d58d4c5a
test(runner): preserve browser tracing if test fails (#59469) 2023-12-11 08:21:46 -08:00
Zack Tanner
4dd8c0bb04
ci: only run release commit check on canary releases (#59423)
We don't want to perform this check for stable releases since those are
never initiated by the cron task, as otherwise it would fail when going
from canary -> stable as no commits would land in-between.

Closes NEXT-1836
2023-12-08 21:46:26 +00:00
Jiachi Liu
ef24520b44
Revert "Skip latest commit check for stable release" (#59401) 2023-12-08 11:14:25 +01:00
Jiachi Liu
eaa0e7c1ba
Skip latest commit check for stable release (#59383) 2023-12-07 22:08:02 +01:00
Wyatt Johnson
eab1fe8397
Enable PPR for dynamic = "force-dynamic" (#58779)
This makes some critical modifications to the app render pipeline when
PPR has been enabled for pages with segments defining:

```js
export const dynamic = "force-dynamic"
```

Importantly, it no longer modifies the revalidation time to zero for
those pages, and now falls back to the provided default revalidation
time. When static render occurs, if the page being rendered has a
segment config defining `dynamic === "force-dynamic"`, then it will
postpone at the root of the component tree. This ensures that no render
code is executed for the page, as the entirety of the tree will have
postponed. This fixes the bug where the flight prefetch wasn't generated
correctly as well.
2023-12-06 01:10:00 +00:00
Leah
b88e263f4c
fix dev parallelism in daily turbopack tests (#59287)
Also fixes the retry running on forks (hopefully for real this time)

Closes PACK-2087
2023-12-05 15:41:49 +01:00
Leah
2cc88d7b11
fix missing checkout in daily turbopack reporting (#59256) 2023-12-04 18:54:00 +01:00
Leah
d348e4b569
fix missing echo in daily turbopack reporting (#59255)
### What?

GitHub workflow commands need to be echoed

Closes PACK-2075
2023-12-04 18:02:08 +01:00
Leah
b2e183ec1d
fix typo in daily turbopack integration test reporting (#59251) 2023-12-04 17:08:46 +01:00
Leah
15215d4c96
ci: report daily turbo integration test results from this repo (#58965)
### What?

A follow up for #58267 and #58394.

We no longer need the git branch for history it's stored in datadog now
and we also decided that we no longer need slack reporting.


Closes PACK-2039

---------

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
2023-12-04 16:18:42 +01:00
Zack Tanner
511867ceec
fix variable name in release workflow (#59135)
Follow up to https://github.com/vercel/next.js/pull/59134
2023-11-30 15:19:46 -08:00
Zack Tanner
f241f44b38
skip release if no new commits (#59134)
Prevents publishing canaries if there are no changes

Closes NEXT-1748
2023-11-30 15:07:05 -08:00
Leah
956636c86f
ci: don't retry or notify on failures from forks (#59118)
### Why?

For some reason the retry action can be triggered if there's a PR from
the canary branch of a fork.
https://github.com/vercel/next.js/actions/runs/7040561852/attempts/3



Closes PACK-2062
2023-11-30 13:03:44 +00:00
Jimmy Lai
e17b368760
misc: delete kodiak (#59082)
We don't need the auto merging from kodiak since Github has one.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-1753
2023-11-29 19:38:33 +01:00
Leah
7ce4a02bdc
ci: don't try to upload to datadog for docs only changes (#59068) 2023-11-29 19:25:01 +01:00
JJ Kasper
5b94850d97
Update checkout step (#59079)
When jobs are cancelled we can end up with a bad `.git` tree so this
updates to have a fresh checkout step to avoid this

x-ref:
https://github.com/vercel/next.js/actions/runs/7036193103/job/19148358339?pr=59076
2023-11-29 10:07:22 -08:00
Jimmy Lai
9e33bf6ab9
misc: disable automerge (#59077)
Disabling the auto merging behaviour from kodiak. You can queue stuff up
by adding an automerge label though.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-1751
2023-11-29 18:19:00 +01:00
Balázs Orbán
d6d41dc66d
chore: bump nissuer (issue validator) (#59060)
### What?

Bumping the issue validator action [`nissuer`](https://github.com/balazsorban44/nissuer)

### Why?

It introduces two new features:

- Comments made by members of the Vercel organization are never hidden to avoid hiding useful information. Example: https://github.com/vercel/next.js/actions/runs/6780069984/job/18428144215
- A new option was added to do not allow `https://github.com/vercel/next.js.*` URLs as valid reproductions, as they are non-modified versions. We should require the reporter to go through the process of creating an isolated reproduction that we can clone and verify easily.

### How?

See https://github.com/balazsorban44/nissuer/releases/tag/1.8.0
2023-11-29 14:35:26 +00:00
Zack Tanner
809164d776
Enable PPR tests for test suites (#59030)
Cherry-picks #58708 without the dependency on https://github.com/vercel/next.js/pull/58779

Co-authored-by: Wyatt Johnson <633002+wyattjoh@users.noreply.github.com>
2023-11-29 03:22:45 +00:00
JJ Kasper
05f2c68b7a
Increase default timeout for swc build (#59035)
x-ref:
https://github.com/vercel/next.js/actions/runs/7022943529/attempts/3
2023-11-28 12:15:35 -08:00
Leah
2a8f7ae1b1
Update Turbopack test manifest from GitHub Actions artifact (#58394)
### What?
We can use the GitHub actions artifact (which is already produced right
now) instead of a separate git branch to get the latest test results.

This also means we don't have a dependency back to the turbo repo for
the daily tests.


Closes PACK-1951
2023-11-24 16:48:12 +01:00
Leah
f6babb4273
fix(CI): retry-test action can't use env in if (#58838) 2023-11-23 20:02:41 +01:00
Zack Tanner
0cb1c40400
ci: disable deployment protection for e2e test project (#58830)
Since we reset the test project on every e2e CI run, deployment protection is automatically enabled by default.

This adds an option to the reset project workflow to disable deployment protection. Our test runners need to be able to hit these pages from an unauthenticated browser in order for the tests to work. 

Verified tests are running properly in [this run](https://github.com/vercel/next.js/actions/runs/6971348806/job/18971225559) (fixing any failing tests themselves are out of scope for this PR; will evaluate once the run finishes)

Closes NEXT-1732
2023-11-23 09:41:34 -08:00
Zack Tanner
cbcd59889c
ci: unify reset project script (#58829)
We have identical `resetProject` code used in `bench/vercel` and our e2e workflow action -- this updates the `resetProject` script to side-effects free (hence removing the env var) and shared between bench & e2e

Closes NEXT-1731
2023-11-23 09:40:48 -08:00
Leah
d53ac4efee
chore(CI): add action to auto retry tests on canary and report failures after retries (#58774)
### What?

Due to flaky tests CI will sometimes fail on canary, we want to retry
before reporting them as broken on slack


Closes PACK-2022
2023-11-23 17:45:12 +01:00