archive/rsnext

Fork 0

Commit graph

Author	SHA1	Message	Date
ChanHui	8d45aa9bfb	update @types/react version in examples (#57259 ) ### What? When I ran `npx create-next-app --example with-turbopack` and installed dependencies using `yarn`, I found an typescript error(`'SomeComponent' cannot be used as a JSX component.`). <img src="https://github.com/vercel/next.js/assets/51700274/f6c7e478-c0b1-4ea2-996f-4c0c78e3bb4b" width=400 /> and I realized that the bug is due to the version of @types/react(18.0.x). you can check this issue on [here](https://github.com/vercel/next.js/issues/42292#issuecomment-1594351684) too. ### Why? It seems that there is an error occurring in the @types/react version 18.0.x. ### How? It would be good to change the @types/react version to 18.2.8 in the next.js examples. I think this change will resolve [this issue](https://github.com/vercel/next.js/issues/55080#issue-1884846177) [NestJS documentation](https://nextjs.org/docs/app/building-your-application/configuring/typescript#async-server-component-typescript-error) also states to upgrade the version. Co-authored-by: Lee Robinson <me@leerob.io> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>	2023-10-26 19:52:08 -05:00
leung018	66597be8a7	Add .yarn/install-state.gz to .gitignore (#56637 ) ### Reason for making this change https://yarnpkg.com/getting-started/qa#:~:text=yarn%2Finstall%2Dstate.,your%20workspaces%20all%20over%20again. In the official documentation of `yarn`, it is stated that `.yarn/install-state.gz` is an optimization file that developer shouldn't ever have to commit. However, currently, when running `create-next-app`, `.yarn/install-state.gz` is being commited. ### Remaining work I apologize for only modifying one template initially to initiate the discussion first. If this change is agreed upon, it should be synchronized with other `.gitignore` templates. Would it be possible to follow a similar approach as in https://github.com/vercel/next.js/pull/47241? I would appreciate any assistance in syncing this change.	2023-10-18 16:34:48 +00:00
Luke Bussey	1aab5ee915	(Example) Update with-segment-analytics to use segmentio/analytics-next and app layout (#52327 ) The [with-segment-analytics](https://github.com/vercel/next.js/blob/canary/examples/with-segment-analytics) example is out of date so this PR updates it to use [segmentio/analytics-next](https://github.com/segmentio/analytics-next) with TypeScript and the app layout. --------- Co-authored-by: Lee Robinson <me@leerob.io>	2023-08-30 13:04:38 -05:00

Author

SHA1

Message

Date

ChanHui

8d45aa9bfb

update @types/react version in examples (#57259 )

### What?
When I ran `npx create-next-app --example with-turbopack` and installed
dependencies using `yarn`, I found an typescript error(`'SomeComponent'
cannot be used as a JSX component.`).

<img
src="https://github.com/vercel/next.js/assets/51700274/f6c7e478-c0b1-4ea2-996f-4c0c78e3bb4b"
width=400 />

and I realized that the bug is due to the version of
@types/react(18.0.x).
you can check this issue on
[here](https://github.com/vercel/next.js/issues/42292#issuecomment-1594351684)
too.

### Why?
It seems that there is an error occurring in the @types/react version
18.0.x.

### How?
It would be good to change the @types/react version to 18.2.8 in the
next.js examples.

I think this change will resolve [this
issue](https://github.com/vercel/next.js/issues/55080#issue-1884846177)
[NestJS
documentation](https://nextjs.org/docs/app/building-your-application/configuring/typescript#async-server-component-typescript-error)
also states to upgrade the version.

Co-authored-by: Lee Robinson <me@leerob.io>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

2023-10-26 19:52:08 -05:00

leung018

66597be8a7

Add .yarn/install-state.gz to .gitignore (#56637 )

### Reason for making this change
https://yarnpkg.com/getting-started/qa#:~:text=yarn%2Finstall%2Dstate.,your%20workspaces%20all%20over%20again.
In the official documentation of `yarn`, it is stated that `.yarn/install-state.gz` is an optimization file that developer shouldn't ever have to commit. However, currently, when running `create-next-app`, `.yarn/install-state.gz` is being commited.

### Remaining work
I apologize for only modifying one template initially to initiate the discussion first.

If this change is agreed upon,  it should be synchronized with other `.gitignore` templates. Would it be possible to follow a similar approach as in https://github.com/vercel/next.js/pull/47241? I would appreciate any assistance in syncing this change.

2023-10-18 16:34:48 +00:00

Luke Bussey

1aab5ee915

(Example) Update with-segment-analytics to use segmentio/analytics-next and app layout (#52327 )

The
[with-segment-analytics](https://github.com/vercel/next.js/blob/canary/examples/with-segment-analytics)
example is out of date so this PR updates it to use
[segmentio/analytics-next](https://github.com/segmentio/analytics-next)
with TypeScript and the app layout.

---------

Co-authored-by: Lee Robinson <me@leerob.io>

2023-08-30 13:04:38 -05:00

3 commits