Toru Kobayashi
|
ac6addbf63
|
fix: a11y issues in react-dev-overlay (#49460)
This is a part of fix of #47351
This fixes two issues #47351 mentioned.
1. Buttons must have discernible text
-
https://dequeuniversity.com/rules/axe/4.6/button-name?application=axe-puppeteer
Before:
<img width="549" alt="Screenshot 2023-05-08 at 22 37 00"
src="https://user-images.githubusercontent.com/250407/236839743-3383aea0-f59a-4f2a-9dff-f24de692a97c.png">
This PR:
<img width="447" alt="Screenshot 2023-05-08 at 22 38 50"
src="https://user-images.githubusercontent.com/250407/236839785-3b29b74e-e4db-4ff3-a87c-b69712196264.png">
You can see the accessibility name.
3. Heading levels should only increase by one
-
https://dequeuniversity.com/rules/axe/4.6/heading-order?application=axe-puppeteer
I didn't fix the following issue in this PR because it caused the change
in appearance for the overlay.
I'll fix it as another PR.
2. Elements must have sufficient color contrast
-
https://dequeuniversity.com/rules/axe/4.6/color-contrast?application=axe-puppeteer
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation or adding/fixing Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
|
2023-05-10 12:27:43 +02:00 |
|
Steven
|
11a7117d40
|
chore: cross-platform rm -rf script (#49529)
- Closes https://github.com/vercel/next.js/issues/42433
- Closes https://github.com/vercel/next.js/pull/43105
- Closes https://github.com/vercel/next.js/pull/49522
|
2023-05-10 01:14:37 +00:00 |
|
vercel-release-bot
|
f02cc9f849
|
v13.4.2-canary.4
|
2023-05-10 00:28:37 +00:00 |
|
vercel-release-bot
|
8d228780e7
|
v13.4.2-canary.3
|
2023-05-09 01:27:04 +00:00 |
|
vercel-release-bot
|
3a5501e678
|
v13.4.2-canary.2
|
2023-05-08 19:41:35 +00:00 |
|
vercel-release-bot
|
660d531b6a
|
v13.4.2-canary.1
|
2023-05-08 16:14:45 +00:00 |
|
vercel-release-bot
|
c93747eb33
|
v13.4.2-canary.0
|
2023-05-08 09:19:39 +00:00 |
|
vercel-release-bot
|
92ff2dd7bb
|
v13.4.1
|
2023-05-05 12:31:07 +00:00 |
|
vercel-release-bot
|
2c37ec01c5
|
v13.4.1-canary.2
|
2023-05-05 11:07:10 +00:00 |
|
vercel-release-bot
|
fd319d3922
|
v13.4.1-canary.1
|
2023-05-04 23:10:22 +00:00 |
|
vercel-release-bot
|
acd22802e0
|
v13.4.1-canary.0
|
2023-05-04 19:35:52 +00:00 |
|
vercel-release-bot
|
fb12a6dc87
|
v13.4.0
|
2023-05-04 16:35:51 +00:00 |
|
JJ Kasper
|
4c407c1635
|
v13.3.5-canary.12
|
2023-05-04 09:21:03 -07:00 |
|
vercel-release-bot
|
10af8c80ca
|
v13.3.5-canary.11
|
2023-05-04 13:53:41 +00:00 |
|
vercel-release-bot
|
83e7d6be8e
|
v13.3.5-canary.10
|
2023-05-04 12:57:28 +00:00 |
|
vercel-release-bot
|
dc99c18ef1
|
v13.3.5-canary.9
|
2023-05-04 10:32:05 +00:00 |
|
vercel-release-bot
|
c5406fc67e
|
v13.3.5-canary.8
|
2023-05-04 01:58:22 +00:00 |
|
vercel-release-bot
|
b7c213fc8e
|
v13.3.5-canary.7
|
2023-05-03 20:18:25 +00:00 |
|
vercel-release-bot
|
467539c19e
|
v13.3.5-canary.6
|
2023-05-03 15:08:15 +00:00 |
|
vercel-release-bot
|
56de0b2ba8
|
v13.3.5-canary.5
|
2023-05-03 06:00:23 +00:00 |
|
vercel-release-bot
|
3caf6de7a6
|
v13.3.5-canary.4
|
2023-05-03 01:01:16 +00:00 |
|
vercel-release-bot
|
d539c764d1
|
v13.3.5-canary.3
|
2023-05-02 09:54:31 +00:00 |
|
vercel-release-bot
|
191e4977a5
|
v13.3.5-canary.2
|
2023-05-02 00:31:46 +00:00 |
|
lijianan
|
eea3f34bc2
|
chore: use includes replace indexOf (#48901)
use includes replace indexOf
|
2023-05-02 00:07:04 +00:00 |
|
vercel-release-bot
|
95d41fbcb1
|
v13.3.5-canary.1
|
2023-05-01 14:23:49 +00:00 |
|
vercel-release-bot
|
c1f15b0ee6
|
v13.3.5-canary.0
|
2023-05-01 12:55:41 +00:00 |
|
vercel-release-bot
|
48323c9dfe
|
v13.3.4
|
2023-05-01 10:35:36 +00:00 |
|
vercel-release-bot
|
bc8f5d8afc
|
v13.3.4-canary.0
|
2023-05-01 10:04:08 +00:00 |
|
vercel-release-bot
|
0b07616eb2
|
v13.3.3
|
2023-05-01 09:07:32 +00:00 |
|
vercel-release-bot
|
b2c6f01242
|
v13.3.3-canary.2
|
2023-05-01 07:42:45 +00:00 |
|
vercel-release-bot
|
8e4888f1f6
|
v13.3.3-canary.1
|
2023-04-30 18:41:24 +00:00 |
|
vercel-release-bot
|
ae00e1206f
|
v13.3.3-canary.0
|
2023-04-30 13:26:24 +00:00 |
|
vercel-release-bot
|
57878be65f
|
v13.3.2
|
2023-04-29 19:17:57 +00:00 |
|
vercel-release-bot
|
6668e97666
|
v13.3.2-canary.14
|
2023-04-29 17:53:12 +00:00 |
|
vercel-release-bot
|
e66c6250ce
|
v13.3.2-canary.13
|
2023-04-28 22:55:36 +00:00 |
|
vercel-release-bot
|
c94122dc2c
|
v13.3.2-canary.12
|
2023-04-28 09:25:25 +00:00 |
|
vercel-release-bot
|
3efbb1a14f
|
v13.3.2-canary.11
|
2023-04-27 15:21:01 +00:00 |
|
vercel-release-bot
|
80a9454faf
|
v13.3.2-canary.10
|
2023-04-27 10:56:05 +00:00 |
|
vercel-release-bot
|
ffefb31efb
|
v13.3.2-canary.9
|
2023-04-27 08:27:05 +00:00 |
|
vercel-release-bot
|
0cfa3fce23
|
v13.3.2-canary.8
|
2023-04-27 03:40:24 +00:00 |
|
vercel-release-bot
|
1c0c61a66c
|
v13.3.2-canary.7
|
2023-04-26 08:38:47 +00:00 |
|
vercel-release-bot
|
9863935f44
|
v13.3.2-canary.6
|
2023-04-25 09:13:29 +00:00 |
|
vercel-release-bot
|
79c73887cd
|
v13.3.2-canary.5
|
2023-04-25 01:30:47 +00:00 |
|
vercel-release-bot
|
2f6ff0dab3
|
v13.3.2-canary.4
|
2023-04-24 22:21:45 +00:00 |
|
vercel-release-bot
|
2196cbe405
|
v13.3.2-canary.3
|
2023-04-24 14:16:49 +00:00 |
|
vercel-release-bot
|
1e9d53ebae
|
v13.3.2-canary.2
|
2023-04-24 09:23:39 +00:00 |
|
vercel-release-bot
|
e720a1efa4
|
v13.3.2-canary.1
|
2023-04-24 08:14:15 +00:00 |
|
vercel-release-bot
|
2bfde63b78
|
v13.3.2-canary.0
|
2023-04-23 21:57:48 +00:00 |
|
vercel-release-bot
|
6423285451
|
v13.3.1
|
2023-04-21 22:04:41 +00:00 |
|
vercel-release-bot
|
455de08b30
|
v13.3.1-canary.19
|
2023-04-21 20:59:00 +00:00 |
|
