Commit graph

418 commits

Author SHA1 Message Date
Jan Kaifer
efe1742668
Update bug report template to make it clear we require repro (#43735)
Co-authored-by: Steven <steven@ceriously.com>
2022-12-06 15:07:35 +01:00
LongYinan
cbf87e1ebf
Build test binary in Docker image (#43745)
<!--
Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ]
[e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
2022-12-06 13:17:03 +08:00
Alfred Mountfield
324de6bf7a
Fix typos in 1.bug_report.yml (#43697)
Found some tiny typos when using the bug template.

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm build && pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
2022-12-04 13:35:10 -08:00
JJ Kasper
90f022aeb6
Update test config (#43661)
Updates our test config to take advantage of more concurrency and also
updates to leverage the playwright docker image to reduce flakes from
actions/setup-node stalling or playwright dependencies stalling on `apt
install`.

This reduces our test times from upwards of 30 minutes down to back
around 15 minutes.
2022-12-03 19:49:00 -08:00
JJ Kasper
6b863fe294
Apply publish step optimizations (#43620)
Follow-up to https://github.com/vercel/next.js/pull/32337 this removes
the un-necessary step where we fetch all of the tags which requires
pulling a lot of un-necessary git history inflating cache size and
publish times.

The only reason these tags were needing to be fetched is due to an issue
in how the `actions/checkout` step works
(https://github.com/actions/checkout/issues/882).

This reduces the publish times by at least 4 minutes by removing the
tags fetching step
https://github.com/vercel/next.js/actions/runs/3598569786/jobs/6061449995#step:16:14

As a further optimization this adds concurrency to the `npm publish`
calls themselves to hopefully reduce time spent there as well.
2022-12-01 21:48:51 -08:00
Balázs Orbán
2906b51f12
chore: fix issue labeler (#43606) 2022-12-01 16:09:33 +01:00
Balázs Orbán
4ee933db92
chore: add issue labeler (#43599)
Follow-up of #43228. This PR adds a new [GitHub Action](https://github.com/github/issue-labeler) that matches the
issue's body for the [dropdown list items](6cacd5a7c4/.github/ISSUE_TEMPLATE/1.bug_report.yml (L26-L48)) and adds the relevant labels to the issue for triaging automatically.
2022-12-01 12:00:42 +00:00
Balázs Orbán
b0aa73b4cf chore: disable auto-labeling 2022-11-30 17:53:53 +01:00
Balázs Orbán
7bd170387f chore: don't comment twice 2022-11-30 15:59:39 +01:00
Balázs Orbán
81aebe953b chore: fix issue verifier 2022-11-30 12:43:18 +01:00
Balázs Orbán
396f9cc60a Merge branch 'canary' of https://github.com/vercel/next.js into canary 2022-11-30 12:15:39 +01:00
Balázs Orbán
5003de7b2d chore: fix issue verifier issues 2022-11-30 12:15:35 +01:00
Balázs Orbán
ef20244851
chore: add area dropdown to bug report template (#43228)
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-11-29 19:34:15 +01:00
Balázs Orbán
cd02e5cf18 chore: hardcode path for issue validator 2022-11-29 19:15:06 +01:00
Balázs Orbán
fa26819340 chore: move comments of issue validator 2022-11-29 19:06:23 +01:00
Balázs Orbán
0d2f92a27e chore: fix issue validator 2022-11-29 19:04:08 +01:00
Balázs Orbán
f0625662f4
chore: update issue verifier (#43339)
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-11-29 18:39:41 +01:00
Jan Kaifer
a2df178554
Add links to PR template (#43239) 2022-11-22 16:12:35 +01:00
JJ Kasper
5d39daaf1c
Update tests config (#43204)
Testing if this reduces flakiness we've been seeing
2022-11-21 14:39:47 -08:00
JJ Kasper
f4b4c09f94
Eagerly build swc binaries on change (#43142)
This is a follow-up to leveraging the turbo remote cache and this now
eagerly updates the cache on merge to canary when swc files changed so
that it doesn't have to wait for a publish to update.
2022-11-19 18:09:47 -08:00
JJ Kasper
cb8eeefcaa
Update build-wasm to checkout directly (#43054)
The full cache doesn't need to be downloaded so we can do a direct
checkout for the repo instead which should be faster.
2022-11-17 15:19:40 -08:00
JJ Kasper
9a3386454b
Fix build-wasm-dev docs skip (#42961)
Fixes:
https://github.com/vercel/next.js/actions/runs/3473074412/jobs/5804720931
2022-11-15 10:41:49 -08:00
JJ Kasper
91ef3303c3
Fix cache collision for swc darwin (#42960)
Ensures we have the actual target passed into turbo for all builds so
it's considered for the cache key.

Fixes:
https://github.com/vercel/next.js/actions/runs/3472341903/jobs/5803170296
2022-11-15 10:33:03 -08:00
JJ Kasper
ea9c5aac5f
Update caching for swc turbo builds (#42929)
Updates to leverage turbo remote caching for the swc builds and
normalize the package versions to prevent repo version bumps from
un-necessarily invalidating the cache.

Full cache hits can be seen in this test run
https://github.com/vercel/next.js/actions/runs/3469932131/jobs/5797559609
2022-11-15 08:24:04 -08:00
JJ Kasper
c3993c828f
Update to latest version of turbo CLI (#42803)
Continuation of https://github.com/vercel/next.js/pull/42711 fixing
latest turbo usage in musl environment

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
2022-11-14 11:52:12 -08:00
OJ Kwon
784d9a73d8
build(next-swc): update turbopack to latest (#42733) 2022-11-10 11:52:48 +01:00
JJ Kasper
abaaf80f51
Revert "Update to latest version of turbo CLI (#42711)"
This reverts commit 2c199c4c19.
2022-11-09 21:15:36 -08:00
JJ Kasper
2c199c4c19
Update to latest version of turbo CLI (#42711)
Ensures we have latest patches in turbo CLI. 

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
2022-11-09 18:22:15 -08:00
Balázs Orbán
fa916e4e67
chore: encourage adding reproductions to issues (#42667)
Issues being reported without a reproduction take longer to
triage/resolve. To make the process faster, we should encourage people
always to add one.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
2022-11-08 17:44:25 -08:00
JJ Kasper
10f2c5a76e
Update swc builds (#42393)
x-ref:
https://github.com/vercel/next.js/actions/runs/3382765061/jobs/5618315815

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
2022-11-02 21:19:04 -07:00
Jim Cresswell
0cb17627a8
docs: clarify PR template instructions (#41957)
Running "pnpm lint" on a documentation change won't work unless "pnpm
build" has previously been run, e.g. on a fresh checkout of a fork after
clicking the published docs "edit this on GitHub" button.

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: Steven <steven@ceriously.com>
2022-10-27 15:04:50 -07:00
Koen Punt
bad43cf0d6
fix example command in issue template for create-next-app (#41803)
<!--
Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

Co-authored-by: Steven <steven@ceriously.com>
2022-10-26 01:17:04 -07:00
LongYinan
13f6eff4cc
Pin build image version (#41704)
https://github.com/vercel/next.js/actions/runs/3310071458
2022-10-23 22:22:28 -07:00
Tim Neutkens
14c9376899
BREAKING CHANGE: Remove React 17 (#41629)
Next.js 13 will require React 18.

In this PR I've only updated the peerDependency and removed the test runs in GH actions. Further cleanup will follow later, this allows us to remove the code supporting it later.



## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)


Co-authored-by: Jiachi Liu <4800338+huozhi@users.noreply.github.com>
2022-10-21 22:20:36 +00:00
Balázs Orbán
2cafe367ac chore: clarify issue template for examples 2022-10-20 17:03:31 +02:00
JJ Kasper
2551978fa4
Increase timeout-minutes for dev jobs 2022-10-19 17:04:41 -07:00
Jaril
008a962df8
Run all dev tests with replay on retry (#41168)
<!--
Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

@ijjk WIP here.

Co-authored-by: JJ Kasper <jj@jjsweb.site>
2022-10-19 15:15:36 -07:00
JJ Kasper
ad1e8dd65d
Bump test timeout-minutes for test dev 2022-10-15 11:42:11 -07:00
JJ Kasper
c66b8f3926
Update bench options in stats-config (#41432)
x-ref:
https://github.com/vercel/next.js/actions/runs/3252514635/jobs/5338830017
x-ref:
https://github.com/vercel/next.js/actions/runs/3250842765/jobs/5335182082
2022-10-14 18:17:45 -07:00
LongYinan
e505e7545b
Upgrade next-swc-napi to NAPI-RS v2 (#40094)
Build succeed https://github.com/vercel/next.js/actions/runs/3243091429
2022-10-13 13:07:14 -07:00
Maxim Baz
de8ae7313f
Support aarch64 Linux with page size >= 16k (#41229)
Fixes https://github.com/vercel/next.js/issues/39311

Backport of upstream patch https://github.com/swc-project/swc/pull/6075

More details are described in https://github.com/swc-project/swc/issues/5967

I confirm that the swc plugin, when compiled with this patch, works on my Linux aarch64 machine.

This will work on all aarch64 Linux systems, the patch is configuring jemalloc to use largest possible page size, instead of taking the value from the machine where you are compiling it. 

And here's the compiled binary, if you want to give it a go!

[next-swc.linux-arm64-gnu.node.zip](https://github.com/vercel/next.js/files/9728262/next-swc.linux-arm64-gnu.node.zip)


Let me know if that makes sense! 🙂
2022-10-12 06:13:06 +00:00
JJ Kasper
09d642a700
Bump E2E test timeout minutes 2022-10-11 13:42:27 -07:00
JJ Kasper
188acd249c
Fix errors entry in codeowners 2022-10-05 22:10:23 -07:00
JJ Kasper
5af1a930a2
Add more test job timeouts (#41162)
This adds some upper bound time limits on our test jobs to ensure we
aren't slipping on test times or letting CI job stall and waste
concurrency.
2022-10-04 11:13:31 -07:00
Jiachi Liu
3e8af93220
Align pnpm version (#41123)
Align pnpm version in build pipelines with 7.3.0 to make sure lock files
are generated correctly
2022-10-03 17:07:52 +02:00
OJ Kwon
3b34602426
build(next/swc): consolidate swc_core dependency version (#41043)
<!--
Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->

This PR utilizes cargo's new feature from latest release (1.64.0),
inheriting dependency from a workspace.

In short, top-level workspace cargo manifest can specify a version of
dependency to use, then actual packages uses it without re-declaring
version per each via workspace = true. This will help to dedupe
different versions of packages, also potentially avoid conflicts if
forgot to bump up specific versions.

In this pr only touches swc_core, which is a base dependency we use in
several place. One another benefit for this is bump up PR can be lot
more simplified, only need to update single Cargo.toml when we bump up.

Note rust-toolchain has updated to use nightly version after 1.64.0 to
enable this.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
2022-09-30 12:59:32 -07:00
Jaril
06607e3dd1
Add Replay integration for dev e2e tests (#40955)
<!--
Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

@ijjk moving this here.

Co-authored-by: JJ Kasper <jj@jjsweb.site>
2022-09-29 14:45:10 -07:00
JJ Kasper
bc685142aa
Increase other timeouts 2022-09-27 13:11:15 -07:00
JJ Kasper
3a6d91b293
Increase playwright install timeout to 5 min 2022-09-27 12:54:14 -07:00
JJ Kasper
9657f99eed
Add timeout to playwright setup job (#40960)
The `npm i` step sometimes stall due to the network in GitHub actions so
this adds a timeout so we aren't wasting CI time on this.

x-ref:
https://github.com/vercel/next.js/actions/runs/3136162957/jobs/5092826951
2022-09-27 09:41:22 -07:00