archive/rsnext

Fork 0

Commit graph

Author	SHA1	Message	Date
JJ Kasper	19013a5e3f	Ensure next.url is used instead of next.appPort (#44163 ) `appPort` shouldn't be used unless absolutely necessary as `next.url` is more specific and allows more control. x-ref: https://github.com/vercel/next.js/actions/runs/3734223762/jobs/6336069606	2022-12-19 13:29:50 -08:00
Balázs Orbán	9639fe704c	Ensure we don't poll page in development when notFound: true is returned (#34352 ) Fixes: #34342 Visiting the following page will call gSSP indefinitely in a loop and logs errors from `on-demand-entries-client`: ```js const Home = () => null export default Home export function getServerSideProps() { console.log("gssp called") return { notFound: true } } ``` We should not keep fetching the page if it returns 404 as it can introduce unnecessary data requests. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>	2022-02-16 18:53:48 +00:00

Author

SHA1

Message

Date

JJ Kasper

19013a5e3f

Ensure next.url is used instead of next.appPort (#44163 )

`appPort` shouldn't be used unless absolutely necessary as `next.url` is
more specific and allows more control.

x-ref:
https://github.com/vercel/next.js/actions/runs/3734223762/jobs/6336069606

2022-12-19 13:29:50 -08:00

Balázs Orbán

9639fe704c

Ensure we don't poll page in development when notFound: true is returned (#34352 )

Fixes: #34342

Visiting the following page will call gSSP indefinitely in a loop and logs errors from `on-demand-entries-client`:
```js
const Home = () => null
export default Home
        
export function getServerSideProps() {
  console.log("gssp called")
  return { notFound: true }
}
```

We should not keep fetching the page if it returns 404 as  it can introduce unnecessary data requests.

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`



Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>

2022-02-16 18:53:48 +00:00

2 commits