Talha Zekeriya Durmuş
16131e2d49
Fix #46621 - include status code in cache ( #47096 )
...
Fixes #46621
As explained here https://github.com/vercel/next.js/issues/46621 ,
> Using fetch to retrieve data inside a page on server side, the
response status code is incorrect when simply loading/reloading the
page. It looks like nextjs is caching the response without taking into
account the status code.
In following code we do not add status code information to the cache.
https://github.com/vercel/next.js/blob/canary/packages/next/src/server/lib/patch-fetch.ts#L189-L206
However we are accessing this status code in
https://github.com/vercel/next.js/blob/canary/packages/next/src/server/lib/patch-fetch.ts#L247-L250
---------
Co-authored-by: JJ Kasper <jj@jjsweb.site>
2023-03-13 21:37:22 -07:00
JJ Kasper
acb174455f
Fix generateStaticParams check in app dir ( #47051 )
...
This ensures our `params` checking works properly with `app` dir.
x-ref: [slack thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1678659475821299 )
2023-03-13 00:05:35 +00:00
JJ Kasper
bfc3849b1f
Update generateStaticParams handling with fetch cache ( #46906 )
...
This ensures we leverage the fetch cache when calling
`generateStaticParams` and also ensures paths with
`generateStaticParams` without `dynamicParams = false` don't error when
only partial params are provided.
x-ref: [slack
thread](https://vercel.slack.com/archives/C035J346QQL/p1678149362238089 )
2023-03-07 22:59:06 -08:00
JJ Kasper
9c36a3204a
Update app-static e2e test ( #46900 )
...
This ensures we properly check for the none cached content correctly
x-ref:
https://github.com/vercel/next.js/actions/runs/4351711739/jobs/7603961011
2023-03-07 12:51:37 -08:00
JJ Kasper
8f5ffed72e
Update fetch cache handling with POST requests ( #46856 )
...
This updates to no longer skip caching POST or authed requests with the
fetch cache and instead we bail when `cookies()` or `headers()` is used
prior which is a better heuristic to signal user specific data would be
related to the fetch request.
x-ref: [slack
thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1678130069138849 )
## Bug
- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md )
2023-03-06 21:30:29 -08:00
JJ Kasper
ed51bd870b
Fix static to dynamic on revalidate ( #46668 )
...
Since it's perfectly valid to do an authorized request during revalidate we shouldn't consider this a reason to throw the static to dynamic error during runtime. If an authorized request is done during build and caching isn't enabled for a path it will still bail from being turned into a Prerender.
x-ref: [slack thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1677734108126679 )
## Bug
- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md )
2023-03-02 10:14:56 +00:00
JJ Kasper
abf8a42326
Fix static to dynamic error in dev ( #46597 )
...
This corrects the static to dynamic error incorrectly showing in
development since we don't have enough information to accurately know if
this error should be thrown or not unless a build has been done.
Fixes: https://github.com/vercel/next.js/issues/46436
x-ref: [slack
thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1677637140906959 )
## Bug
- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md )
2023-02-28 23:37:12 -08:00
JJ Kasper
4ac4b757d4
Update fetch cache internal handling ( #46522 )
...
x-ref:
https://github.com/vercel/next.js/actions/runs/4288511720/jobs/7470646795
x-ref:
https://github.com/vercel/next.js/actions/runs/4288511720/jobs/7470647108
x-ref:
https://github.com/vercel/next.js/actions/runs/4288511720/jobs/7470647255
2023-02-27 21:39:11 -08:00
JJ Kasper
aa614635d6
Update fetch cache key ( #46513
...
x-ref: [slack
thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1677461963151879?thread_ts=1677360662.652689&cid=C042LHPJ1NX )
## Bug
- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md )
2023-02-27 14:14:14 -08:00
JJ Kasper
ebed7396f5
Ensure fetch fields are detected with RequestInit ( #46398 )
...
This ensures we properly detect fetch fields when a `new Request()` is passed to fetch instead of a separate `init` param.
Fixes: [slack thread](https://vercel.slack.com/archives/C035J346QQL/p1677264109548949 )
Closes: https://github.com/vercel/next.js/issues/46349
## Bug
- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md )
2023-02-25 15:50:51 +00:00
JJ Kasper
725a4de0ef
Fix failing app-static deploy test ( #46395 )
...
x-ref:
https://github.com/vercel/next.js/actions/runs/4267518385/jobs/7429540548
2023-02-24 18:03:09 -08:00
JJ Kasper
c5336132c3
Fix fetch cache key inputs and encoding ( #46392
...
This ensures we properly filter caching on uncachable request methods by
default and correct encoding handling in edge runtime.
Fixes: https://github.com/vercel/next.js/issues/46349
x-ref: [slack
thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1677253242022489 )
## Bug
- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md )
2023-02-24 16:44:47 -08:00
JJ Kasper
99a7a34f96
Ensure generateStaticParams works in route ( #46310 )
...
x-ref: [slack
thread](https://vercel.slack.com/archives/C04DUD7EB1B/p1677165000745519 )
## Bug
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md )
---------
Co-authored-by: Jimmy Lai <laijimmy0@gmail.com>
2023-02-23 18:33:08 +01:00
JJ Kasper
5792533781
Update app cache handler loading ( #46290
...
Follow-up to https://github.com/vercel/next.js/pull/46287 this updates
how we load the cache handler for the incremental cache so it's
compatible with edge and also adds regression testing with a custom
handler.
2023-02-23 01:19:59 -08:00
JJ Kasper
6d25125ff1
Update app dir cache heuristics ( #46287 )
...
x-ref: https://github.com/vercel/next.js/pull/46271
x-ref: https://github.com/vercel/next.js/pull/46081
2023-02-23 07:59:38 +00:00
Shu Ding
ff05d9b7b5
Skip pre-rendering the default param when no params are provided ( #46265 )
...
Closes #45850 .
## Bug
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md )
## Feature
- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ]
[e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md )
## Documentation / Examples
- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md )
---------
Co-authored-by: JJ Kasper <jj@jjsweb.site>
2023-02-22 14:59:19 -08:00
Luba Kravchenko
9d2824e995
Update app dir cache handling ( #46081 )
...
Updates handling for app dir caching for edge runtime and adds additional tests.
x-ref: NEXT-511
Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
2023-02-22 07:10:25 +00:00
JJ Kasper
1253a3035f
Add ISR handling for app routes ( #46133 )
...
Follow-up to https://github.com/vercel/next.js/pull/45716 this updates
the ISR handling for app routes. This also ensures the E2E deploy tests
are running for the `app-routes` test suite.
fixes NEXT-509
Relies on https://github.com/vercel/vercel/pull/9489
---------
2023-02-21 15:25:42 -08:00
Jan Kaifer
659a75177b
Update error message for dynamic = "error" ( #45432 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-01 11:20:35 +00:00
JJ Kasper
e868f77ede
Update app cache handling in development ( #45248 )
2023-01-25 11:51:53 -08:00
JJ Kasper
f931a636e1
Add debug info to static bailout message ( #45192 )
2023-01-23 13:25:00 -08:00
JJ Kasper
ad48202432
Ensure force-dynamic is honored during build ( #45015 )
2023-01-18 11:24:48 -08:00
JJ Kasper
6b7c69fa4d
Add proper error when app path switches static to dynamic ( #44989 )
2023-01-18 10:24:35 -08:00
JJ Kasper
25b5845a0a
Fix app ISR handling with no generateStaticParams ( #44787 )
2023-01-11 15:28:03 -08:00
Wyatt Johnson
ed59ad525a
Change NextInstance.fetch Signature ( #44575 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-01-05 16:31:03 +01:00
Jan Kaifer
6713ce4cab
Move tests into their test folder ( #44183 )
2022-12-21 14:16:52 +01:00
