archive/rsnext

Fork 0

Commit graph

Author	SHA1	Message	Date
Tim Neutkens	f260328900	BREAKING CHANGE: Enable newNextLinkBehavior (#41459 ) - Enable newNextLinkBehavior. See #36436 - Run next/link codemod on test suite Note that from when this lands on apps trying canary will need to run the new-link codemod in order to upgrade. Ideally we have to detect `<a>` while rendering the new link and warn for it. Co-authored-by: Steven <steven@ceriously.com>	2022-10-17 21:20:28 -04:00
JJ Kasper	a92a5caec2	Update test set-up to leverage playwright when able to (#28634 ) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>	2021-09-13 14:36:25 +02:00
JJ Kasper	38bd1a024c	Re-enable scroll restoration behind flag (#14046 ) This updates the scroll position saving to occur as the scroll position changes instead of trying to do it when the navigation is changing since the `popState` event doesn't allow us to update the leaving history state once the `popState` has occurred. The order of events that was previously attempted to save scroll position on a `popState` event (back/forward navigation) 1. history.state is already updated with state from `popState` 2. we replace state with the currently rendered page adding scroll info 3. we replace state again with the `popState` event state overriding scroll info Using this approach the above event order is no longer in conflict since we don't attempt to populate the state with scroll position while it's leaving the state and instead do it while it is still the active state in history This approach resembles existing solutions: https://www.npmjs.com/package/scroll-behavior https://twitter.com/ryanflorence/status/1029121580855488512 Fixes: https://github.com/vercel/next.js/issues/13990 Fixes: #12530 x-ref: https://github.com/vercel/next.js/pull/14075	2020-07-06 14:27:45 +00:00

Author

SHA1

Message

Date

Tim Neutkens

f260328900

BREAKING CHANGE: Enable newNextLinkBehavior (#41459 )

- Enable newNextLinkBehavior. See #36436 
- Run next/link codemod on test suite

Note that from when this lands on apps trying canary will need to run
the new-link codemod in order to upgrade.
Ideally we have to detect `<a>` while rendering the new link and warn
for it.

Co-authored-by: Steven <steven@ceriously.com>

2022-10-17 21:20:28 -04:00

JJ Kasper

a92a5caec2

Update test set-up to leverage playwright when able to (#28634 )

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

2021-09-13 14:36:25 +02:00

JJ Kasper

38bd1a024c

Re-enable scroll restoration behind flag (#14046 )

This updates the scroll position saving to occur as the scroll position changes instead of trying to do it when the navigation is changing since the `popState` event doesn't allow us to update the leaving history state once the `popState` has occurred. 

The order of events that was previously attempted to save scroll position on a `popState` event (back/forward navigation)

1. history.state is already updated with state from `popState`
2. we replace state with the currently rendered page adding scroll info
3. we replace state again with the `popState` event state overriding scroll info

Using this approach the above event order is no longer in conflict since we don't attempt to populate the state with scroll position while it's leaving the state and instead do it while it is still the active state in history

This approach resembles existing solutions:
https://www.npmjs.com/package/scroll-behavior
https://twitter.com/ryanflorence/status/1029121580855488512

Fixes: https://github.com/vercel/next.js/issues/13990
Fixes: #12530
x-ref: https://github.com/vercel/next.js/pull/14075

2020-07-06 14:27:45 +00:00

3 commits