c6320ed87a
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> I took some time and [wrote a codemod](https://gist.github.com/wyattjoh/0d4464427506cb02062a4729ca906b62) that replaces the old usage of the `createNextDescribe` with the new `nextTestSetup`. You'll likely have to turn on hiding of whitespace in order to review, but this should primarily introduce no changes to the test structure other than using the new mechanism now. Closes NEXT-3178
97 lines
2.7 KiB
TypeScript
97 lines
2.7 KiB
TypeScript
import { nextTestSetup } from 'e2e-utils'
|
|
import { check, waitFor } from 'next-test-utils'
|
|
import path from 'path'
|
|
|
|
describe('multi-zone', () => {
|
|
const { next, isNextDev, skipped } = nextTestSetup({
|
|
files: path.join(__dirname, 'app'),
|
|
skipDeployment: true,
|
|
buildCommand: 'pnpm build',
|
|
startCommand: (global as any).isNextDev ? 'pnpm dev' : 'pnpm start',
|
|
packageJson: {
|
|
scripts: {
|
|
dev: 'node server.js',
|
|
build: 'next build apps/host && next build apps/guest',
|
|
start: 'NODE_ENV=production node server.js',
|
|
'post-build': 'echo done',
|
|
},
|
|
},
|
|
dependencies: require('./app/package.json').dependencies,
|
|
})
|
|
|
|
if (skipped) {
|
|
return
|
|
}
|
|
|
|
it.each([
|
|
{ pathname: '/', content: ['hello from host app'] },
|
|
{ pathname: '/guest', content: ['hello from guest app'] },
|
|
{
|
|
pathname: '/blog/post-1',
|
|
content: ['hello from host app /blog/[slug]'],
|
|
},
|
|
{
|
|
pathname: '/guest/blog/post-1',
|
|
content: ['hello from guest app /blog/[slug]'],
|
|
},
|
|
{
|
|
pathname: '/guest/another/post-1',
|
|
content: ['hello from guest app /another/[slug]'],
|
|
},
|
|
])(
|
|
'should correctly respond for $pathname',
|
|
async ({ pathname, content }) => {
|
|
const res = await next.fetch(pathname, {
|
|
redirect: 'manual',
|
|
})
|
|
expect(res.status).toBe(200)
|
|
|
|
const html = await res.text()
|
|
|
|
for (const item of content) {
|
|
expect(html).toContain(item)
|
|
}
|
|
}
|
|
)
|
|
|
|
if (isNextDev) {
|
|
async function runHMRTest(app: string) {
|
|
const isHostApp = app === 'host'
|
|
const browser = await next.browser(isHostApp ? '/' : app)
|
|
expect(await browser.elementByCss('body').text()).toContain(
|
|
`hello from ${app} app`
|
|
)
|
|
const initialTimestamp = await browser.elementById('now').text()
|
|
|
|
expect(await browser.elementByCss('body').text()).not.toContain(
|
|
'hmr content'
|
|
)
|
|
|
|
await waitFor(1000)
|
|
|
|
// verify that the page isn't unexpectedly reloading in the background
|
|
const newTimestamp = await browser.elementById('now').text()
|
|
expect(newTimestamp).toBe(initialTimestamp)
|
|
|
|
// trigger HMR
|
|
const filePath = `apps/${app}/pages/index.tsx`
|
|
const content = await next.readFile(filePath)
|
|
|
|
const patchedContent = content.replace(
|
|
`const editedContent = ''`,
|
|
`const editedContent = 'hmr content'`
|
|
)
|
|
await next.patchFile(filePath, patchedContent)
|
|
|
|
await check(() => browser.elementByCss('body').text(), /hmr content/)
|
|
|
|
// restore original content
|
|
await next.patchFile(filePath, content)
|
|
}
|
|
|
|
it('should support HMR in both apps', async () => {
|
|
await runHMRTest('host')
|
|
await runHMRTest('guest')
|
|
})
|
|
}
|
|
})
|