No description
Find a file
Jimmy Lai 11deaaa82b
edge-ssr: bundle next/dist as ESM for better tree-shaking (#40251)
# Context

Edge SSR'd routes cold boot performances are proportional to the
executed code size.

In order to improve it, we are trying to optimize for the bundle size of
a packed Edge SSR route.

This PR adds ESM compilation targets for all Next.js dist packages and
use them to bundle Edge SSR'd route.

This allows us to leverage the better tree shaking/DCE for ESM modules
in webpack in order to decrease the overall bundle size.

This PR also enables minifying Edge SSR routes. Since we don't control
which minifier might be used later (if any), it's best if we provide an
already optimised bundle.

<img width="903" alt="image"
src="https://user-images.githubusercontent.com/11064311/190005211-b7cb2c58-a56a-44b0-8ee4-fd3f603e41bd.png">

This is a 10ms cold boot win per my benchmarking script, which I'll put
in a subsequent PR.

Not done yet:
- ~~swap exported requires in `next/link` (and others) etc to point them
to the esm modules version~~

<!--
Thanks for opening a PR! Your contribution is much appreciated.
In order to make sure your PR is handled as smoothly as possible we
request that you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [x] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The examples guidelines are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: Shu Ding <g@shud.in>
2022-09-26 16:56:16 -07:00
.github Update publish script to skip lerna (#40815) 2022-09-22 16:22:17 -07:00
.husky Replace pre-commit with husky (#38350) 2022-07-06 11:14:16 -05:00
.vscode refactor: split up CONTRIBUTING.md (#40515) 2022-09-16 14:54:58 -07:00
bench refactor: split up CONTRIBUTING.md (#40515) 2022-09-16 14:54:58 -07:00
contributing refactor: split up CONTRIBUTING.md (#40515) 2022-09-16 14:54:58 -07:00
docs [docs] Update Cypress config file name (#40849) 2022-09-23 20:46:12 +00:00
errors update url for React Hydration Documentation (#40883) 2022-09-26 12:35:12 -07:00
examples Correct link for "Deploy" button (#40894) 2022-09-26 12:51:31 -07:00
packages edge-ssr: bundle next/dist as ESM for better tree-shaking (#40251) 2022-09-26 16:56:16 -07:00
scripts Update publish to skip private package (#40822) 2022-09-22 17:49:44 -07:00
test Should resolve esm external module imports on server (#40865) 2022-09-26 15:46:01 -07:00
.alexignore Enable Alex documentation linting for docs (#26598) 2021-06-25 11:40:50 -05:00
.alexrc Add section to next/future/image docs about Known Browser Bugs (#39759) 2022-08-20 00:21:00 +00:00
.eslintignore chore: check against npm version in issue validator (#38915) 2022-08-25 11:43:20 -05:00
.eslintrc.json Enable additional TypeScript ESLint rules (#39640) 2022-08-16 11:08:40 +00:00
.gitattributes the way towards webpack 5 typings (#29105) 2021-09-21 19:17:16 +02:00
.gitignore Update .gitignore to include @next/swc-wasm-nodejs (#38025) 2022-06-25 22:53:54 -05:00
.npmrc declare pnpm7 as engine (#37303) 2022-05-30 13:13:36 +00:00
.prettierignore chore: check against npm version in issue validator (#38915) 2022-08-25 11:43:20 -05:00
.prettierignore_staged chore: check against npm version in issue validator (#38915) 2022-08-25 11:43:20 -05:00
.prettierrc.json Prettier trailingComma default value to es5 since 2.0 (#14391) 2020-06-22 13:25:24 +02:00
azure-pipelines.yml Add docs condition for all azure steps (#38519) 2022-07-11 11:15:25 -05:00
CODE_OF_CONDUCT.md updated code of conduct to v2.1 (#34208) 2022-02-10 18:11:42 -06:00
contributing.md refactor: split up CONTRIBUTING.md (#40515) 2022-09-16 14:54:58 -07:00
jest.config.js Don't swallow test failures caused by POSIX signals (#32688) 2021-12-21 12:52:07 -06:00
lerna.json v12.3.2-canary.9 2022-09-26 16:57:56 +02:00
license.md Update license year 2022-01-13 16:02:34 +01:00
lint-staged.config.js Replace pre-commit with husky (#38350) 2022-07-06 11:14:16 -05:00
package.json Upgrade react@experimental (#40885) 2022-09-25 21:35:05 +02:00
plopfile.js refactor: split up CONTRIBUTING.md (#40515) 2022-09-16 14:54:58 -07:00
pnpm-lock.yaml v12.3.2-canary.9 2022-09-26 16:57:56 +02:00
pnpm-workspace.yaml Update to leverage pnpm for monorepo (#37259) 2022-05-28 23:35:16 -05:00
readme.md Monorepo (#5341) 2018-10-01 01:02:10 +02:00
release.js Fix labels for release sections 2021-11-21 13:11:54 +01:00
run-tests.js Update test failure logging (#39655) 2022-08-16 15:14:37 +01:00
SECURITY.md Add link to security email directly. (#33358) 2022-01-15 21:33:43 -06:00
test-file.txt Add additional file serving tests (#12479) 2020-05-04 11:58:19 -05:00
tsconfig-tsec.json Integrate tsec into the linting process (#33746) 2022-02-24 16:59:18 -08:00
tsconfig.json Adds tests to ensure eslint-plugin-next's available rules are properly exported and recommended rules are correctly defined. (#38183) 2022-06-30 11:31:33 -05:00
tsec-exemptions.json Fix various Trusted Types violations without use of policy (#34726) 2022-05-05 00:11:36 +00:00
turbo.json Update to leverage turbo for build/prepublish (#37280) 2022-05-30 19:05:27 -05:00
UPGRADING.md Move upgrading guide to /docs (#10727) 2020-02-28 23:46:18 +01:00
vercel.json Silence GH Comments for Preview URLs (#18766) 2020-11-03 21:59:47 +00:00

Next.js

Getting Started

Visit https://nextjs.org/learn to get started with Next.js.

Documentation

Visit https://nextjs.org/docs to view the full documentation.

Who is using Next.js?

Next.js is used by the world's leading companies. Check out the Next.js Showcase to learn more.

Community

The Next.js community can be found on GitHub Discussions, where you can ask questions, voice ideas, and share your projects.

To chat with other community members you can join the Next.js Discord.

Our Code of Conduct applies to all Next.js community channels.

Contributing

Please see our contributing.md.

Good First Issues

We have a list of good first issues that contain bugs that have a relatively limited scope. This is a great place to get started, gain experience, and get familiar with our contribution process.

Authors

Security

If you believe you have found a security vulnerability in Next.js, we encourage you to responsibly disclose this and not open a public issue. We will investigate all legitimate reports. Email security@vercel.com to disclose any security vulnerabilities.

https://vercel.com/security