1cf1198cab
The first implementation had limitation wrt to static routes so this is a "simpler" approach to making interception work. This also fixes a few bugs. In this PR: - changed the computation of the referrer route to now live on the client state, since it's the only place where you can accurately keep track of that. One router state was not sufficient, we needed a delta of two states to guess which route had changed when having parallel routes in the tree. - uses rewrites as the basis for interception now instead of route handlers, this means that we have to do some sketchy logic to make the rules work since they only handle regexes whereas we have `path/like/[this]` - dev server now reloads rewrites as well when needed <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> |
||
---|---|---|
.. | ||
_allow-underscored-root-directory | ||
actions | ||
app | ||
app-a11y | ||
app-alias | ||
app-basepath | ||
app-css | ||
app-edge | ||
app-edge-global | ||
app-external | ||
app-middleware | ||
app-prefetch | ||
app-rendering | ||
app-routes | ||
app-routes-trailing-slash | ||
app-static | ||
app-validation | ||
asset-prefix | ||
async-component-preload | ||
autoscroll-with-css-modules | ||
back-button-download-bug | ||
create-next-app-template | ||
create-root-layout | ||
dynamic | ||
dynamic-href | ||
edge-runtime-node-compatibility | ||
experimental-react | ||
global-error | ||
hooks | ||
i18n-hybrid | ||
import | ||
interpolability-with-pages | ||
layout-params | ||
mdx | ||
metadata | ||
metadata-dynamic-routes | ||
metadata-missing-metadata-base | ||
metadata-suspense | ||
navigation | ||
next-font | ||
next-image | ||
not-found | ||
pages-to-app-routing | ||
parallel-routes-and-interception | ||
rewrites-redirects | ||
root-layout | ||
root-layout-redirect | ||
route-page-manifest-bug | ||
router-autoscroll | ||
router-stuck-dynamic-static-segment | ||
rsc-basic | ||
searchparams-static-bailout | ||
set-cookies | ||
similar-pages-paths | ||
test-template/{{ toFileName name }} | ||
trailingslash | ||
underscore-ignore-app-paths | ||
use-params | ||
use-selected-layout-segment-s | ||
with-babel |