cb729c1087
Currently there's an experimental option in `next.config.js` that lets you define default subset(s) to preload for all your fonts. [docs](https://nextjs.org/docs/basic-features/font-optimization#specifying-a-subset)
Over time we haven't seen much use of this option, and we are defining the subsets in the font function call in all our examples/docs. Imo it would be fine to drop this option.
This PR removes that experimental option. If you happen to use it you'll get a build error with [a link](f67af163cd/errors/google-fonts-missing-subsets.md).
Next step (breaking change for next major) would probably be to remove the preload and subsets properties from `next/font/google` calls, and just have something like [`preloadSubsets´](https://vercel.slack.com/archives/C8EAN8A94/p1674868993169559?thread_ts=1674707555.461809&cid=C8EAN8A94) that is required.
145 lines
4.3 KiB
TypeScript
145 lines
4.3 KiB
TypeScript
import cheerio from 'cheerio'
|
|
import { createNext, FileRef } from 'e2e-utils'
|
|
import { NextInstance } from 'test/lib/next-modes/base'
|
|
import { renderViaHTTP } from 'next-test-utils'
|
|
import { join } from 'path'
|
|
|
|
const mockedGoogleFontResponses = require.resolve(
|
|
'./google-font-mocked-responses.js'
|
|
)
|
|
|
|
const isDev = (global as any).isNextDev
|
|
|
|
describe('next/font/google with-font-declarations-file', () => {
|
|
let next: NextInstance
|
|
|
|
if ((global as any).isNextDeploy) {
|
|
it('should skip next deploy for now', () => {})
|
|
return
|
|
}
|
|
|
|
beforeAll(async () => {
|
|
next = await createNext({
|
|
files: {
|
|
pages: new FileRef(
|
|
join(__dirname, 'with-font-declarations-file/pages')
|
|
),
|
|
components: new FileRef(
|
|
join(__dirname, 'with-font-declarations-file/components')
|
|
),
|
|
'fonts.js': new FileRef(
|
|
join(__dirname, 'with-font-declarations-file/fonts.js')
|
|
),
|
|
'my-font.woff2': new FileRef(
|
|
join(__dirname, 'with-font-declarations-file/my-font.woff2')
|
|
),
|
|
},
|
|
env: {
|
|
NEXT_FONT_GOOGLE_MOCKED_RESPONSES: mockedGoogleFontResponses,
|
|
},
|
|
})
|
|
})
|
|
afterAll(() => next.destroy())
|
|
|
|
test('preload correct files at /inter', async () => {
|
|
const html = await renderViaHTTP(next.url, '/inter')
|
|
const $ = cheerio.load(html)
|
|
|
|
// Preconnect
|
|
expect($('link[rel="preconnect"]').length).toBe(0)
|
|
|
|
if (isDev) {
|
|
// In dev all fonts will be preloaded since it's before DCE
|
|
expect($('link[as="font"]').length).toBe(4)
|
|
} else {
|
|
// Preload
|
|
expect($('link[as="font"]').length).toBe(2)
|
|
// From /_app
|
|
expect($('link[as="font"]').get(0).attribs).toEqual({
|
|
as: 'font',
|
|
crossorigin: 'anonymous',
|
|
href: '/_next/static/media/0812efcfaefec5ea-s.p.woff2',
|
|
rel: 'preload',
|
|
type: 'font/woff2',
|
|
'data-next-font': 'size-adjust',
|
|
})
|
|
// From /inter
|
|
expect($('link[as="font"]').get(1).attribs).toEqual({
|
|
as: 'font',
|
|
crossorigin: 'anonymous',
|
|
href: '/_next/static/media/4a7f86e553ee7e51-s.p.woff2',
|
|
rel: 'preload',
|
|
type: 'font/woff2',
|
|
'data-next-font': 'size-adjust',
|
|
})
|
|
}
|
|
})
|
|
|
|
test('preload correct files at /roboto', async () => {
|
|
const html = await renderViaHTTP(next.url, '/roboto')
|
|
const $ = cheerio.load(html)
|
|
|
|
// Preconnect
|
|
expect($('link[rel="preconnect"]').length).toBe(0)
|
|
|
|
if (isDev) {
|
|
// In dev all fonts will be preloaded since it's before DCE
|
|
expect($('link[as="font"]').length).toBe(4)
|
|
} else {
|
|
// Preload
|
|
expect($('link[as="font"]').length).toBe(2)
|
|
// From /_app
|
|
expect($('link[as="font"]').get(0).attribs).toEqual({
|
|
as: 'font',
|
|
crossorigin: 'anonymous',
|
|
href: '/_next/static/media/0812efcfaefec5ea-s.p.woff2',
|
|
rel: 'preload',
|
|
type: 'font/woff2',
|
|
'data-next-font': 'size-adjust',
|
|
})
|
|
// From /roboto
|
|
expect($('link[as="font"]').get(1).attribs).toEqual({
|
|
as: 'font',
|
|
crossorigin: 'anonymous',
|
|
href: '/_next/static/media/9a7e84b4dd095b33-s.p.woff2',
|
|
rel: 'preload',
|
|
type: 'font/woff2',
|
|
'data-next-font': 'size-adjust',
|
|
})
|
|
}
|
|
})
|
|
|
|
test('preload correct files at /local-font', async () => {
|
|
const html = await renderViaHTTP(next.url, '/local-font')
|
|
const $ = cheerio.load(html)
|
|
|
|
// Preconnect
|
|
expect($('link[rel="preconnect"]').length).toBe(0)
|
|
|
|
if (isDev) {
|
|
// In dev all fonts will be preloaded since it's before DCE
|
|
expect($('link[as="font"]').length).toBe(4)
|
|
} else {
|
|
// Preload
|
|
expect($('link[as="font"]').length).toBe(2)
|
|
// From /_app
|
|
expect($('link[as="font"]').get(0).attribs).toEqual({
|
|
as: 'font',
|
|
crossorigin: 'anonymous',
|
|
href: '/_next/static/media/0812efcfaefec5ea-s.p.woff2',
|
|
rel: 'preload',
|
|
type: 'font/woff2',
|
|
'data-next-font': 'size-adjust',
|
|
})
|
|
// From /local-font
|
|
expect($('link[as="font"]').get(1).attribs).toEqual({
|
|
as: 'font',
|
|
crossorigin: 'anonymous',
|
|
href: '/_next/static/media/2a931eed088772c9-s.p.woff2',
|
|
rel: 'preload',
|
|
type: 'font/woff2',
|
|
'data-next-font': 'size-adjust',
|
|
})
|
|
}
|
|
})
|
|
})
|